qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH v5 00/22] parallels: Add full dirty bitmap support
Date: Mon, 11 Mar 2024 19:18:28 +0100	[thread overview]
Message-ID: <20240311181850.73013-1-alexander.ivanov@virtuozzo.com> (raw)

Parallels format driver:
* make some preparation
* add dirty bitmap saving
* make dirty bitmap RW
* fix broken checks
* refactor leak check
* add parallels format support to several tests

You could find these patches in my repo:
https://github.com/AlexanderIvanov-Virtuozzo/qemu/tree/parallels-v5

v5:
6: Returned a comment about fallocate.
10: Added a motivation of used_bitmap usage to the commit message.
11: Renamed 'limit' variable. Added a few error messages. Fixed
    'remaining' value by extension header size. Simplified bh and l1_table
    pointer calculation. Added clusters cleaning after error. Add return
    value to parallels_store_persistent_dirty_bitmaps().
12: New patch, all the next patches will be shifted by 1. Added header
    unclean check to dirty bitmap loading.
13: Placed dirty bitmap loading after used bitmap initialization.
14: New patch, all the next patches will be shifted by 2. Preserved
    extensions cluster for non-transient extensions.
16: (previous numeration): Dropped the patch because the next patch deleted
    all the code of this patch. All the next patches will be shifted by 1.
18: Moved used bitmap parallels_check_unused_clusters() to parallels_check_leak().
19: Removed redundant bdrv_pwrite_zeroes() (see a note in the commit message).
    Added a break to outside-of-image clusters at image opening.

v4:
4: A new patch with limitation of search in parallels_mark_used.
5: Previously 4. Search is limited to (cluster_index + count).
6: Previously 5. Added GRAPH_RDLOCK annotation, added a note in the commit
   message.
11: Previously 10. Added GRAPH_RDLOCK annotation.
16-18: Added GRAPH_RDLOCK annotations.

v3:
1: Fixed the order of g_free() and s->used_bmap = NULL.
3,4: Made mark_used() a global function before mark_unused() addition. In
     this way we can avoid compilation warnings.
5-9: Patches shifted.
11: Added GRAPH_RDLOCK annotation to parallels_inactivate(). Guard
    parallels_close() with GRAPH_RDLOCK_GUARD_MAINLOOP().
12-21: Patches shifted.

v2:
1: New patch to fix double free error.
4: Fixed clusters leaks.
15: Fixed (end_off != s->used_bmap_size) handling in parallels_truncate_unused_clusters().
16,17: Changed the sequence of the patches - in this way we have correct leaks check.

Alexander Ivanov (21):
  parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap()
  parallels: Move inactivation code to a separate function
  parallels: Make mark_used() a global function
  parallels: Limit search in parallels_mark_used to the last marked
    claster
  parallels: Add parallels_mark_unused() helper
  parallels: Move host clusters allocation to a separate function
  parallels: Set data_end value in parallels_check_leak()
  parallels: Recreate used bitmap in parallels_check_leak()
  parallels: Add a note about used bitmap in parallels_check_duplicate()
  parallels: Create used bitmap even if checks needed
  parallels: Add dirty bitmaps saving
  parallels: Let image extensions work in RW mode
  parallels: Preserve extensions cluster for non-transient extensions
  parallels: Handle L1 entries equal to one
  parallels: Make a loaded dirty bitmap persistent
  parallels: Reverse a conditional in parallels_check_leak() to reduce
    indents
  parallels: Check unused clusters in parallels_check_leak()
  parallels: Remove unnecessary data_end field
  tests: Add parallels images support to test 165
  tests: Turned on 256, 299, 304 and block-status-cache for parallels
    format
  tests: Add parallels format support to image-fleecing

Denis V. Lunev (1):
  parallels: drop dirty bitmap data if the image was not properly closed

 block/parallels-ext.c                       | 243 ++++++++++++-
 block/parallels.c                           | 367 ++++++++++++--------
 block/parallels.h                           |  14 +-
 tests/qemu-iotests/165                      |  40 ++-
 tests/qemu-iotests/256                      |   2 +-
 tests/qemu-iotests/299                      |   2 +-
 tests/qemu-iotests/304                      |   2 +-
 tests/qemu-iotests/tests/block-status-cache |   2 +-
 tests/qemu-iotests/tests/image-fleecing     |  13 +-
 9 files changed, 502 insertions(+), 183 deletions(-)

-- 
2.40.1



             reply	other threads:[~2024-03-11 18:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 18:18 Alexander Ivanov [this message]
2024-03-11 18:18 ` [PATCH v5 01/22] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 02/22] parallels: Move inactivation code to a separate function Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 03/22] parallels: Make mark_used() a global function Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the last marked claster Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 06/22] parallels: Move host clusters allocation to a separate function Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 07/22] parallels: Set data_end value in parallels_check_leak() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 08/22] parallels: Recreate used bitmap " Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 09/22] parallels: Add a note about used bitmap in parallels_check_duplicate() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 10/22] parallels: Create used bitmap even if checks needed Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 11/22] parallels: Add dirty bitmaps saving Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 13/22] parallels: Let image extensions work in RW mode Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 14/22] parallels: Preserve extensions cluster for non-transient extensions Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 15/22] parallels: Handle L1 entries equal to one Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 16/22] parallels: Make a loaded dirty bitmap persistent Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 17/22] parallels: Reverse a conditional in parallels_check_leak() to reduce indents Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 18/22] parallels: Check unused clusters in parallels_check_leak() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 19/22] parallels: Remove unnecessary data_end field Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 20/22] tests: Add parallels images support to test 165 Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 21/22] tests: Turned on 256, 299, 304 and block-status-cache for parallels format Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 22/22] tests: Add parallels format support to image-fleecing Alexander Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240311181850.73013-1-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).