From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH v5 22/22] tests: Add parallels format support to image-fleecing
Date: Mon, 11 Mar 2024 19:18:50 +0100 [thread overview]
Message-ID: <20240311181850.73013-23-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20240311181850.73013-1-alexander.ivanov@virtuozzo.com>
Use a different bitmap name for parallels images because their has own ID
format, and can't contain an arbitrary string.
Replace hardcoded 'qcow2' format to iotests.imgfmt.
Add 'parallels' to supported formats.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
tests/qemu-iotests/tests/image-fleecing | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/tests/image-fleecing b/tests/qemu-iotests/tests/image-fleecing
index 5e3b2c7e46..dd940b7203 100755
--- a/tests/qemu-iotests/tests/image-fleecing
+++ b/tests/qemu-iotests/tests/image-fleecing
@@ -28,7 +28,7 @@ import iotests
from iotests import log, qemu_img, qemu_io
iotests.script_initialize(
- supported_fmts=['qcow2'],
+ supported_fmts=['qcow2', 'parallels'],
supported_platforms=['linux'],
required_fmts=['copy-before-write'],
unsupported_imgopts=['compat']
@@ -61,12 +61,17 @@ def do_test(vm, use_cbw, use_snapshot_access_filter, base_img_path,
if push_backup:
assert use_cbw
+ if iotests.imgfmt == 'parallels':
+ bitmap_name = '00000000-0000-0000-0000-000000000000'
+ else:
+ bitmap_name = 'bitmap0'
+
log('--- Setting up images ---')
log('')
qemu_img('create', '-f', iotests.imgfmt, base_img_path, '64M')
if bitmap:
- qemu_img('bitmap', '--add', base_img_path, 'bitmap0')
+ qemu_img('bitmap', '--add', base_img_path, bitmap_name)
if use_snapshot_access_filter:
assert use_cbw
@@ -75,7 +80,7 @@ def do_test(vm, use_cbw, use_snapshot_access_filter, base_img_path,
qemu_img('create', '-f', 'qcow2', fleece_img_path, '64M')
if push_backup:
- qemu_img('create', '-f', 'qcow2', target_img_path, '64M')
+ qemu_img('create', '-f', iotests.imgfmt, target_img_path, '64M')
for p in patterns:
qemu_io('-f', iotests.imgfmt,
@@ -130,7 +135,7 @@ def do_test(vm, use_cbw, use_snapshot_access_filter, base_img_path,
}
if bitmap:
- fl_cbw['bitmap'] = {'node': src_node, 'name': 'bitmap0'}
+ fl_cbw['bitmap'] = {'node': src_node, 'name': bitmap_name}
log(vm.qmp('blockdev-add', fl_cbw))
--
2.40.1
prev parent reply other threads:[~2024-03-11 18:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 18:18 [PATCH v5 00/22] parallels: Add full dirty bitmap support Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 01/22] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 02/22] parallels: Move inactivation code to a separate function Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 03/22] parallels: Make mark_used() a global function Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the last marked claster Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 06/22] parallels: Move host clusters allocation to a separate function Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 07/22] parallels: Set data_end value in parallels_check_leak() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 08/22] parallels: Recreate used bitmap " Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 09/22] parallels: Add a note about used bitmap in parallels_check_duplicate() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 10/22] parallels: Create used bitmap even if checks needed Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 11/22] parallels: Add dirty bitmaps saving Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 13/22] parallels: Let image extensions work in RW mode Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 14/22] parallels: Preserve extensions cluster for non-transient extensions Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 15/22] parallels: Handle L1 entries equal to one Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 16/22] parallels: Make a loaded dirty bitmap persistent Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 17/22] parallels: Reverse a conditional in parallels_check_leak() to reduce indents Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 18/22] parallels: Check unused clusters in parallels_check_leak() Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 19/22] parallels: Remove unnecessary data_end field Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 20/22] tests: Add parallels images support to test 165 Alexander Ivanov
2024-03-11 18:18 ` [PATCH v5 21/22] tests: Turned on 256, 299, 304 and block-status-cache for parallels format Alexander Ivanov
2024-03-11 18:18 ` Alexander Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311181850.73013-23-alexander.ivanov@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).