From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, mst@redhat.com
Subject: [PATCH v3 00/20] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS
Date: Tue, 12 Mar 2024 17:10:30 +0100 [thread overview]
Message-ID: <20240312161050.2248814-1-imammedo@redhat.com> (raw)
Changelog:
v3:
* whitespace missed by checkpatch
* fix idndent in QAPI
* reorder 17/20 before 1st 'auto' can be used
* pick up acks
v2:
* QAPI style fixes (Markus Armbruster <armbru@redhat.com>)
* squash 11/19 into 10/19 (Ani Sinha <anisinha@redhat.com>)
* split '[PATCH 09/19] smbios: build legacy mode code only for 'pc' machine'
in 3 smaller patches, to make it more readable
smbios: add smbios_add_usr_blob_size() helper
smbios: rename/expose structures/bitmaps used by both legacy and modern code
smbios: build legacy mode code only for 'pc' machine
* pick up acks
Windows (10) bootloader when running on top of SeaBIOS, fails to find
SMBIOSv3 entry point. Tracing it shows that it looks for v2 anchor markers
only and not v3. Tricking it into believing that entry point is found
lets Windows successfully locate and parse SMBIOSv3 tables. Whether it
will be fixed on Windows side is not clear so here goes a workaround.
Idea is to try build v2 tables if QEMU configuration permits,
and fallback to v3 tables otherwise. That will mask Windows issue
form majority of users.
However if VM configuration can't be described (typically large VMs)
by v2 tables, QEMU will use SMBIOSv3 and Windows will hit the issue
again. In this case complain to Microsoft and/or use UEFI instead of
SeaBIOS (requires reinstall).
Default compat setting of smbios-entry-point-type after series
for pc/q35 machines:
* 9.0-newer: 'auto'
* 8.1-8.2: '64'
* 8.0-older: '32'
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2008
CC: imammedo@redhat.com
CC: mst@redhat.com
Igor Mammedov (20):
tests: smbios: make it possible to write SMBIOS only test
tests: smbios: add test for -smbios type=11 option
tests: smbios: add test for legacy mode CLI options
smbios: cleanup smbios_get_tables() from legacy handling
smbios: get rid of smbios_smp_sockets global
smbios: get rid of smbios_legacy global
smbios: avoid mangling user provided tables
smbios: don't check type4 structures in legacy mode
smbios: add smbios_add_usr_blob_size() helper
smbios: rename/expose structures/bitmaps used by both legacy and
modern code
smbios: build legacy mode code only for 'pc' machine
smbios: handle errors consistently
smbios: get rid of global smbios_ep_type
smbios: clear smbios_type4_count before building tables
smbios: extend smbios-entry-point-type with 'auto' value
smbios: in case of entry point is 'auto' try to build v2 tables 1st
smbios: error out when building type 4 table is not possible
tests: acpi/smbios: whitelist expected blobs
pc/q35: set SMBIOS entry point type to 'auto' by default
tests: acpi: update expected SSDT.dimmpxm blob
hw/i386/fw_cfg.h | 3 +-
include/hw/firmware/smbios.h | 28 +-
hw/arm/virt.c | 6 +-
hw/i386/Kconfig | 1 +
hw/i386/fw_cfg.c | 14 +-
hw/i386/pc.c | 4 +-
hw/i386/pc_piix.c | 4 +
hw/i386/pc_q35.c | 3 +
hw/loongarch/virt.c | 7 +-
hw/riscv/virt.c | 6 +-
hw/smbios/Kconfig | 2 +
hw/smbios/meson.build | 4 +
hw/smbios/smbios.c | 481 +++++++++++----------------
hw/smbios/smbios_legacy.c | 185 +++++++++++
hw/smbios/smbios_legacy_stub.c | 15 +
qapi/machine.json | 5 +-
tests/data/acpi/q35/SSDT.dimmpxm | Bin 1815 -> 1815 bytes
tests/data/smbios/type11_blob | Bin 0 -> 11 bytes
tests/data/smbios/type11_blob.legacy | Bin 0 -> 10 bytes
tests/qtest/bios-tables-test.c | 81 ++++-
20 files changed, 533 insertions(+), 316 deletions(-)
create mode 100644 hw/smbios/smbios_legacy.c
create mode 100644 hw/smbios/smbios_legacy_stub.c
create mode 100644 tests/data/smbios/type11_blob
create mode 100644 tests/data/smbios/type11_blob.legacy
--
2.39.3
next reply other threads:[~2024-03-12 16:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 16:10 Igor Mammedov [this message]
2024-03-12 16:10 ` [PATCH v3 01/20] tests: smbios: make it possible to write SMBIOS only test Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 02/20] tests: smbios: add test for -smbios type=11 option Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 03/20] tests: smbios: add test for legacy mode CLI options Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 04/20] smbios: cleanup smbios_get_tables() from legacy handling Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 05/20] smbios: get rid of smbios_smp_sockets global Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 06/20] smbios: get rid of smbios_legacy global Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 07/20] smbios: avoid mangling user provided tables Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 08/20] smbios: don't check type4 structures in legacy mode Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 09/20] smbios: add smbios_add_usr_blob_size() helper Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 10/20] smbios: rename/expose structures/bitmaps used by both legacy and modern code Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 11/20] smbios: build legacy mode code only for 'pc' machine Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 12/20] smbios: handle errors consistently Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 13/20] smbios: get rid of global smbios_ep_type Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 14/20] smbios: clear smbios_type4_count before building tables Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 15/20] smbios: extend smbios-entry-point-type with 'auto' value Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 16/20] smbios: in case of entry point is 'auto' try to build v2 tables 1st Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 17/20] smbios: error out when building type 4 table is not possible Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 18/20] tests: acpi/smbios: whitelist expected blobs Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 19/20] pc/q35: set SMBIOS entry point type to 'auto' by default Igor Mammedov
2024-03-12 16:10 ` [PATCH v3 20/20] tests: acpi: update expected SSDT.dimmpxm blob Igor Mammedov
2024-03-12 17:31 ` [PATCH v3 00/20] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS Michael S. Tsirkin
2024-03-13 8:49 ` Igor Mammedov
2024-03-13 9:10 ` Michael S. Tsirkin
2024-03-13 22:51 ` Michael S. Tsirkin
2024-03-12 17:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312161050.2248814-1-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).