From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 6/7] tests/unit/test-throttle: Avoid unintended integer division
Date: Tue, 12 Mar 2024 18:38:09 +0000 [thread overview]
Message-ID: <20240312183810.557768-7-peter.maydell@linaro.org> (raw)
In-Reply-To: <20240312183810.557768-1-peter.maydell@linaro.org>
In test_compute_wait() we do
double units = bkt.max / 10;
which does an integer division and then assigns it to a double variable,
and similarly later on in the expression for an assertion.
Use 10.0 so that we do a floating point division and calculate the
exact value, rather than doing an integer division.
Spotted by Coverity.
Resolves: Coverity CID 1432564
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
tests/unit/test-throttle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c
index 2146cfacd36..24032a02667 100644
--- a/tests/unit/test-throttle.c
+++ b/tests/unit/test-throttle.c
@@ -127,13 +127,13 @@ static void test_compute_wait(void)
bkt.avg = 10;
bkt.max = 200;
for (i = 0; i < 22; i++) {
- double units = bkt.max / 10;
+ double units = bkt.max / 10.0;
bkt.level += units;
bkt.burst_level += units;
throttle_leak_bucket(&bkt, NANOSECONDS_PER_SECOND / 10);
wait = throttle_compute_wait(&bkt);
g_assert(double_cmp(bkt.burst_level, 0));
- g_assert(double_cmp(bkt.level, (i + 1) * (bkt.max - bkt.avg) / 10));
+ g_assert(double_cmp(bkt.level, (i + 1) * (bkt.max - bkt.avg) / 10.0));
/* We can do bursts for the 2 seconds we have configured in
* burst_length. We have 100 extra milliseconds of burst
* because bkt.level has been leaking during this time.
--
2.34.1
next prev parent reply other threads:[~2024-03-12 18:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 18:38 [PATCH 0/7] various: 7 minor Coverity fixes Peter Maydell
2024-03-12 18:38 ` [PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line Peter Maydell
2024-03-12 19:23 ` Thomas Huth
2024-03-13 6:52 ` Thomas Huth
2024-03-12 18:38 ` [PATCH 2/7] tests/unit/socket-helpers: Don't close(-1) Peter Maydell
2024-03-22 11:51 ` Thomas Huth
2024-03-12 18:38 ` [PATCH 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() Peter Maydell
2024-03-12 18:38 ` [PATCH 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions Peter Maydell
2024-03-12 18:38 ` [PATCH 5/7] hw/nvram/mac_nvram: Report failure to write data Peter Maydell
2024-03-12 20:19 ` Philippe Mathieu-Daudé
2024-03-12 18:38 ` Peter Maydell [this message]
2024-03-12 19:22 ` [PATCH 6/7] tests/unit/test-throttle: Avoid unintended integer division Thomas Huth
2024-03-12 18:38 ` [PATCH 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure Peter Maydell
2024-03-12 20:20 ` Philippe Mathieu-Daudé
2024-03-12 19:06 ` [PATCH 0/7] various: 7 minor Coverity fixes Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312183810.557768-7-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).