From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 5/8] linux-user/elfload: Don't close an unopened file descriptor
Date: Tue, 12 Mar 2024 08:41:12 -1000 [thread overview]
Message-ID: <20240312184115.365415-6-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240312184115.365415-1-richard.henderson@linaro.org>
Fixes Coverity CID: 1534964
Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 4dbca05646..26d4c1d6b3 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -4522,7 +4522,9 @@ static int elf_core_dump(int signr, const CPUArchState *env)
ret = -errno;
mmap_unlock();
cpu_list_unlock();
- close(fd);
+ if (fd >= 0) {
+ close(fd);
+ }
return ret;
}
#endif /* USE_ELF_CORE_DUMP */
--
2.34.1
next prev parent reply other threads:[~2024-03-12 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 18:41 [PULL 0/8] tcg + linux-user patch queue Richard Henderson
2024-03-12 18:41 ` [PULL 1/8] linux-user: Add FIFREEZE and FITHAW ioctls Richard Henderson
2024-03-12 18:41 ` [PULL 2/8] linux-user: Implement PR_{GET,SET}_CHILD_SUBREAPER Richard Henderson
2024-03-12 18:41 ` [PULL 3/8] linux-user: Implement PR_{GET,SET}_SPECULATION_CTRL Richard Henderson
2024-03-12 18:41 ` [PULL 4/8] linux-user: Implement PR_GET_TID_ADDRESS Richard Henderson
2024-03-12 18:41 ` Richard Henderson [this message]
2024-03-12 18:41 ` [PULL 6/8] linux-user/elfload: Fully initialize struct target_elf_prpsinfo Richard Henderson
2024-03-12 18:41 ` [PULL 7/8] tcg/aarch64: Fix tcg_out_cmp for test comparisons Richard Henderson
2024-03-12 18:41 ` [PULL 8/8] tcg/aarch64: Fix tcg_out_brcond " Richard Henderson
2024-03-13 12:36 ` [PULL 0/8] tcg + linux-user patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312184115.365415-6-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).