From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 8/8] tcg/aarch64: Fix tcg_out_brcond for test comparisons
Date: Tue, 12 Mar 2024 08:41:15 -1000 [thread overview]
Message-ID: <20240312184115.365415-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240312184115.365415-1-richard.henderson@linaro.org>
When converting test vs UINT32_MAX to compare vs 0, we need to
adjust the condition to match.
Fixes: 34aff3c2e06 ("tcg/aarch64: Generate CBNZ for TSTNE of UINT32_MAX")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/aarch64/tcg-target.c.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index 38446c167e..56fc9cb9e0 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -1464,6 +1464,7 @@ static void tcg_out_brcond(TCGContext *s, TCGType ext, TCGCond c, TCGArg a,
case TCG_COND_TSTNE:
/* tst xN,0xffffffff; b.ne L -> cbnz wN,L */
if (b_const && b == UINT32_MAX) {
+ c = tcg_tst_eqne_cond(c);
ext = TCG_TYPE_I32;
need_cmp = false;
break;
--
2.34.1
next prev parent reply other threads:[~2024-03-12 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 18:41 [PULL 0/8] tcg + linux-user patch queue Richard Henderson
2024-03-12 18:41 ` [PULL 1/8] linux-user: Add FIFREEZE and FITHAW ioctls Richard Henderson
2024-03-12 18:41 ` [PULL 2/8] linux-user: Implement PR_{GET,SET}_CHILD_SUBREAPER Richard Henderson
2024-03-12 18:41 ` [PULL 3/8] linux-user: Implement PR_{GET,SET}_SPECULATION_CTRL Richard Henderson
2024-03-12 18:41 ` [PULL 4/8] linux-user: Implement PR_GET_TID_ADDRESS Richard Henderson
2024-03-12 18:41 ` [PULL 5/8] linux-user/elfload: Don't close an unopened file descriptor Richard Henderson
2024-03-12 18:41 ` [PULL 6/8] linux-user/elfload: Fully initialize struct target_elf_prpsinfo Richard Henderson
2024-03-12 18:41 ` [PULL 7/8] tcg/aarch64: Fix tcg_out_cmp for test comparisons Richard Henderson
2024-03-12 18:41 ` Richard Henderson [this message]
2024-03-13 12:36 ` [PULL 0/8] tcg + linux-user patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312184115.365415-9-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).