From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Lukas Stockner <lstockner@genesiscloud.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0
Date: Wed, 13 Mar 2024 06:24:23 -0400 [thread overview]
Message-ID: <20240313062349-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b1607b82-cfca-4461-a2cd-ac3cf8344bba@linaro.org>
On Wed, Mar 13, 2024 at 11:22:43AM +0100, Philippe Mathieu-Daudé wrote:
> On 13/3/24 11:14, Philippe Mathieu-Daudé wrote:
> > On 13/3/24 07:50, Michael S. Tsirkin wrote:
> > > Document that PCIe Gen5/Gen6 speeds are only in QAPI
> > > since 9.0 - the rest is since 4.0.
> > >
> > > Cc: Lukas Stockner <lstockner@genesiscloud.com>
> > > Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > > Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds")
>
> (BTW if you have to repost your pullreq as v2, you could
> squash this change).
Does not break bisect in any way, it's a comment so I do
not see a reason to squash.
> > > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > > qapi/common.json | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> >
prev parent reply other threads:[~2024-03-13 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 6:50 [PATCH] qapi: document PCIe Gen5/Gen6 speeds since 9.0 Michael S. Tsirkin
2024-03-13 10:14 ` Philippe Mathieu-Daudé
2024-03-13 10:22 ` Philippe Mathieu-Daudé
2024-03-13 10:24 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313062349-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lstockner@genesiscloud.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).