* [PATCH] linux-user: replace calloc() with g_new0()
@ 2024-03-17 17:17 Nguyen Dinh Phi
2024-03-17 20:38 ` Alex Bennée
2024-04-06 19:31 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Nguyen Dinh Phi @ 2024-03-17 17:17 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Nguyen Dinh Phi, qemu-devel
Use glib allocation as recommended by the coding convention
Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
---
linux-user/main.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 9277df2e9d..149e35432e 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -928,11 +928,7 @@ int main(int argc, char **argv, char **envp)
* Prepare copy of argv vector for target.
*/
target_argc = argc - optind;
- target_argv = calloc(target_argc + 1, sizeof (char *));
- if (target_argv == NULL) {
- (void) fprintf(stderr, "Unable to allocate memory for target_argv\n");
- exit(EXIT_FAILURE);
- }
+ target_argv = g_new0(char *, target_argc + 1);
/*
* If argv0 is specified (using '-0' switch) we replace
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] linux-user: replace calloc() with g_new0()
2024-03-17 17:17 [PATCH] linux-user: replace calloc() with g_new0() Nguyen Dinh Phi
@ 2024-03-17 20:38 ` Alex Bennée
2024-04-06 19:31 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2024-03-17 20:38 UTC (permalink / raw)
To: Nguyen Dinh Phi; +Cc: Laurent Vivier, qemu-devel
Nguyen Dinh Phi <phind.uet@gmail.com> writes:
> Use glib allocation as recommended by the coding convention
>
> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> ---
> linux-user/main.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 9277df2e9d..149e35432e 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -928,11 +928,7 @@ int main(int argc, char **argv, char **envp)
> * Prepare copy of argv vector for target.
> */
> target_argc = argc - optind;
> - target_argv = calloc(target_argc + 1, sizeof (char *));
> - if (target_argv == NULL) {
> - (void) fprintf(stderr, "Unable to allocate memory for target_argv\n");
> - exit(EXIT_FAILURE);
> - }
> + target_argv = g_new0(char *, target_argc + 1);
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] linux-user: replace calloc() with g_new0()
2024-03-17 17:17 [PATCH] linux-user: replace calloc() with g_new0() Nguyen Dinh Phi
2024-03-17 20:38 ` Alex Bennée
@ 2024-04-06 19:31 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2024-04-06 19:31 UTC (permalink / raw)
To: Nguyen Dinh Phi, Laurent Vivier; +Cc: qemu-devel
On 3/17/24 07:17, Nguyen Dinh Phi wrote:
> Use glib allocation as recommended by the coding convention
>
> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> ---
> linux-user/main.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 9277df2e9d..149e35432e 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -928,11 +928,7 @@ int main(int argc, char **argv, char **envp)
> * Prepare copy of argv vector for target.
> */
> target_argc = argc - optind;
> - target_argv = calloc(target_argc + 1, sizeof (char *));
> - if (target_argv == NULL) {
> - (void) fprintf(stderr, "Unable to allocate memory for target_argv\n");
> - exit(EXIT_FAILURE);
> - }
> + target_argv = g_new0(char *, target_argc + 1);
>
> /*
> * If argv0 is specified (using '-0' switch) we replace
Queued, thanks.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-06 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-17 17:17 [PATCH] linux-user: replace calloc() with g_new0() Nguyen Dinh Phi
2024-03-17 20:38 ` Alex Bennée
2024-04-06 19:31 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).