From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net,
zhao1.liu@intel.com, chao.p.peng@intel.com,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: [PATCH v2 1/3] qom/object_interfaces: Remove unnecessary local error check
Date: Mon, 18 Mar 2024 11:32:08 +0800 [thread overview]
Message-ID: <20240318033211.459006-2-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20240318033211.459006-1-zhenzhong.duan@intel.com>
The original error handling code indicates "local_err is always set",
and error_propagate() can handle the case that local_err is NULL.
Use err label instead of out label for error path.
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
qom/object_interfaces.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index e0833c8bfe..70179877f1 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -111,14 +111,14 @@ Object *user_creatable_add_type(const char *type, const char *id,
obj = object_new(type);
object_set_properties_from_qdict(obj, qdict, v, &local_err);
if (local_err) {
- goto out;
+ goto err;
}
if (id != NULL) {
object_property_try_add_child(object_get_objects_root(),
id, obj, &local_err);
if (local_err) {
- goto out;
+ goto err;
}
}
@@ -126,15 +126,13 @@ Object *user_creatable_add_type(const char *type, const char *id,
if (id != NULL) {
object_property_del(object_get_objects_root(), id);
}
- goto out;
- }
-out:
- if (local_err) {
- error_propagate(errp, local_err);
- object_unref(obj);
- return NULL;
+ goto err;
}
return obj;
+err:
+ error_propagate(errp, local_err);
+ object_unref(obj);
+ return NULL;
}
void user_creatable_add_qapi(ObjectOptions *options, Error **errp)
--
2.34.1
next prev parent reply other threads:[~2024-03-18 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 3:32 [PATCH v2 0/3] Simplify user_creatable_add_type error path Zhenzhong Duan
2024-03-18 3:32 ` Zhenzhong Duan [this message]
2024-03-18 3:32 ` [PATCH v2 2/3] qom/object_interfaces: Make object_set_properties_from_qdict return bool Zhenzhong Duan
2024-03-18 8:56 ` Zhao Liu
2024-03-18 3:32 ` [PATCH v2 3/3] qom/object_interfaces: Remove local_err in user_creatable_add_type Zhenzhong Duan
2024-03-18 8:57 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318033211.459006-2-zhenzhong.duan@intel.com \
--to=zhenzhong.duan@intel.com \
--cc=berrange@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).