From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net,
zhao1.liu@intel.com, chao.p.peng@intel.com,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: [PATCH v2 3/3] qom/object_interfaces: Remove local_err in user_creatable_add_type
Date: Mon, 18 Mar 2024 11:32:10 +0800 [thread overview]
Message-ID: <20240318033211.459006-4-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20240318033211.459006-1-zhenzhong.duan@intel.com>
In user_creatable_add_type, there is mixed usage of ERRP_GUARD and
local_err. This makes error_abort not taking effect in those callee
functions with &local_err passed.
Now that we already use ERRP_GUARD, remove local_err and pass errp.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
qom/object_interfaces.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index e17e2de46d..2067bf2230 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -84,7 +84,6 @@ Object *user_creatable_add_type(const char *type, const char *id,
ERRP_GUARD();
Object *obj;
ObjectClass *klass;
- Error *local_err = NULL;
if (id != NULL && !id_wellformed(id)) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "id", "an identifier");
@@ -112,16 +111,16 @@ Object *user_creatable_add_type(const char *type, const char *id,
assert(qdict);
obj = object_new(type);
- if (!object_set_properties_from_qdict(obj, qdict, v, &local_err)) {
+ if (!object_set_properties_from_qdict(obj, qdict, v, errp)) {
goto err;
}
if (id != NULL && !object_property_try_add_child(object_get_objects_root(),
- id, obj, &local_err)) {
+ id, obj, errp)) {
goto err;
}
- if (!user_creatable_complete(USER_CREATABLE(obj), &local_err)) {
+ if (!user_creatable_complete(USER_CREATABLE(obj), errp)) {
if (id != NULL) {
object_property_del(object_get_objects_root(), id);
}
@@ -129,7 +128,6 @@ Object *user_creatable_add_type(const char *type, const char *id,
}
return obj;
err:
- error_propagate(errp, local_err);
object_unref(obj);
return NULL;
}
--
2.34.1
next prev parent reply other threads:[~2024-03-18 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 3:32 [PATCH v2 0/3] Simplify user_creatable_add_type error path Zhenzhong Duan
2024-03-18 3:32 ` [PATCH v2 1/3] qom/object_interfaces: Remove unnecessary local error check Zhenzhong Duan
2024-03-18 3:32 ` [PATCH v2 2/3] qom/object_interfaces: Make object_set_properties_from_qdict return bool Zhenzhong Duan
2024-03-18 8:56 ` Zhao Liu
2024-03-18 3:32 ` Zhenzhong Duan [this message]
2024-03-18 8:57 ` [PATCH v2 3/3] qom/object_interfaces: Remove local_err in user_creatable_add_type Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318033211.459006-4-zhenzhong.duan@intel.com \
--to=zhenzhong.duan@intel.com \
--cc=berrange@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).