qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
	"Pavel Dovgalyuk" <Pavel.Dovgalyuk@ispras.ru>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"John Snow" <jsnow@redhat.com>, "Cleber Rosa" <crosa@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>
Subject: [PATCH v5 21/24] tests/avocado: reverse_debugging.py test auto-snapshot mode
Date: Tue, 19 Mar 2024 01:46:18 +1000	[thread overview]
Message-ID: <20240318154621.2361161-22-npiggin@gmail.com> (raw)
In-Reply-To: <20240318154621.2361161-1-npiggin@gmail.com>

This runs the recording phase with a periodic auto-snapshot.

It also runs the machine for 5 seconds after creating the initial
address map, so as to alow time for a some auto snapshots to be
taken.

In the replay mode a reverse-debugging sequence is added where the
test is run to the end, and reverse-stepped from there. This should
load the last auto-snapshot taken.

The test hangs on x86-64 and aarch64 with autosnapshots, so it is
disabled for them.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 tests/avocado/reverse_debugging.py | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/tests/avocado/reverse_debugging.py b/tests/avocado/reverse_debugging.py
index 185f055cf9..36e5e1be05 100644
--- a/tests/avocado/reverse_debugging.py
+++ b/tests/avocado/reverse_debugging.py
@@ -41,6 +41,9 @@ class ReverseDebugging(LinuxKernelTest):
     # first 10 instructions are stepped.
     verify_end = True
 
+    # Enable the autosnapshot test, requires long_trace = True.
+    autosnapshot = True
+
     # If first_step_workaround is true, check whether the first step moved
     # icount, and if not then step again.
     first_step_workaround = False
@@ -56,9 +59,14 @@ def run_vm(self, record, shift, args, replay_path, image_path, port):
             logger.info('replaying the execution...')
             mode = 'replay'
         vm.add_args('-gdb', 'tcp::%d' % port, '-S')
-        vm.add_args('-icount', 'shift=%s,rr=%s,rrfile=%s,rrsnapshot=init' %
-                    (shift, mode, replay_path),
-                    '-net', 'none')
+        if self.autosnapshot:
+            vm.add_args('-icount', 'shift=%s,rr=%s,rrfile=%s,rrsnapshot=init'
+                                   ',rrsnapmode=periodic,rrsnapcount=10,'
+                                   'rrsnaptime=1' % (shift, mode, replay_path))
+        else:
+            vm.add_args('-icount', 'shift=%s,rr=%s,rrfile=%s,rrsnapshot=init'
+                                   % (shift, mode, replay_path))
+        vm.add_args('-net', 'none')
         vm.add_args('-drive', 'file=%s,if=none,id=disk0' % image_path)
         if args:
             vm.add_args(*args)
@@ -192,8 +200,12 @@ def reverse_debugging(self, shift=7, args=None):
 
         logger.info('continue running')
         self.gdb_cont_nowait(g)
-        logger.info('running for 1s...')
-        time.sleep(1)
+        if self.autosnapshot:
+            logger.info('running for 5s...')
+            time.sleep(5)
+        else:
+            logger.info('running for 1s...')
+            time.sleep(1)
         logger.info('stopping to read final icount')
         vm.qmp('stop')
         self.gdb_break(g)
@@ -322,6 +334,9 @@ class ReverseDebugging_X86_64(ReverseDebugging):
     # the trace precisely on x86.
     verify_end = False
 
+    # x86 doesn't like autosnapshot
+    autosnapshot = False
+
     def get_pc(self, g):
         return self.get_reg_le(g, self.REG_PC) \
             + self.get_reg_le(g, self.REG_CS) * 0x10
@@ -355,6 +370,9 @@ class ReverseDebugging_AArch64(ReverseDebugging):
     # the trace precisely on aarch64.
     verify_end = False
 
+    # aarch64 doesn't like autosnapshot
+    autosnapshot = False
+
     def test_aarch64_virt(self):
         """
         :avocado: tags=arch:aarch64
-- 
2.42.0



  parent reply	other threads:[~2024-03-18 15:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 15:45 [PATCH v5 00/24] replay: fixes and new test cases Nicholas Piggin
2024-03-18 15:45 ` [PATCH v5 01/24] scripts/replay-dump.py: Update to current rr record format Nicholas Piggin
2024-03-18 15:45 ` [PATCH v5 02/24] scripts/replay-dump.py: rejig decoders in event number order Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 03/24] tests/avocado: excercise scripts/replay-dump.py in replay tests Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 04/24] replay: allow runstate shutdown->running when replaying trace Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 05/24] Revert "replay: stop us hanging in rr_wait_io_event" Nicholas Piggin
2024-03-19 17:58   ` Alex Bennée
2024-03-18 15:46 ` [PATCH v5 06/24] tests/avocado: replay_kernel.py add x86-64 q35 machine test Nicholas Piggin
2024-03-19 17:58   ` Alex Bennée
2024-03-18 15:46 ` [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device Nicholas Piggin
2024-03-19 19:17   ` Alex Bennée
2024-03-18 15:46 ` [PATCH v5 08/24] replay: Fix migration use of clock Nicholas Piggin
2024-03-19 20:40   ` Alex Bennée
2024-03-20  4:48     ` Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 09/24] replay: Fix migration replay_mutex locking Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 10/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state Nicholas Piggin
2024-03-19 20:41   ` Alex Bennée
2024-04-05  6:53   ` Pavel Dovgalyuk
2024-03-18 15:46 ` [PATCH v5 11/24] virtio-net: Use virtual time for RSC timers Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 12/24] savevm: Fix load_snapshot error path crash Nicholas Piggin
2024-03-19 20:49   ` Alex Bennée
2024-03-18 15:46 ` [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards Nicholas Piggin
2024-03-19 17:57   ` Alex Bennée
2024-03-20  4:34     ` Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 14/24] tests/avocado: reverse_debugging.py mark aarch64 and pseries as not flaky Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 15/24] tests/avocado: reverse_debugging.py add test for x86-64 q35 machine Nicholas Piggin
2024-03-19 20:50   ` Alex Bennée
2024-03-18 15:46 ` [PATCH v5 16/24] tests/avocado: reverse_debugging.py verify addresses between record and replay Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 17/24] tests/avocado: reverse_debugging.py stop VM before sampling icount Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 18/24] tests/avocado: reverse_debugging reverse-step at the end of the trace Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 19/24] tests/avocado: reverse_debugging.py add snapshot testing Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 20/24] replay: simple auto-snapshot mode for record Nicholas Piggin
2024-04-05  6:56   ` Pavel Dovgalyuk
2024-03-18 15:46 ` Nicholas Piggin [this message]
2024-03-18 15:46 ` [PATCH v5 22/24] target/ppc: fix timebase register reset state Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 23/24] spapr: Fix vpa dispatch count for record-replay Nicholas Piggin
2024-03-18 15:46 ` [PATCH v5 24/24] tests/avocado: replay_linux.py add ppc64 pseries test Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318154621.2361161-22-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=Pavel.Dovgalyuk@ispras.ru \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).