From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 0/3 for 9.0] Fix TLS support for chardevs and incoming data loss on EOF
Date: Mon, 18 Mar 2024 18:23:27 +0000 [thread overview]
Message-ID: <20240318182330.96738-1-berrange@redhat.com> (raw)
This fixes a problem with TLS support on chardevs that Thomas has
previously attempted to deal with:
https://lists.nongnu.org/archive/html/qemu-devel/2024-02/msg06915.html
Unfortunately that fix caused unexpected side effects that resulted
in premature termination of the TLS connection. See patch 2 for
details.
I've since identified the root cause of the problem that Thomas was
trying to fix - bad assumptions about GSource 'prepare' functions
always being run. See patch 3 for details.
Patch 3 re-exposed a bug we've know about for a while whereby incoming
data on chardevs is sometimes discarded when POLLHUP is reported at the
same time. This required patch 1 to be applied before doing the revert
in patch 3, otherwise test-char would now very frequently fail.
So we get 2 bug fixes for the price of one :-)
Daniel P. Berrangé (3):
chardev: lower priority of the HUP GSource in socket chardev
Revert "chardev/char-socket: Fix TLS io channels sending too much data
to the backend"
Revert "chardev: use a child source for qio input source"
chardev/char-io.c | 55 +++++++++++++++++++++++++++++++++++++++----
chardev/char-socket.c | 22 ++++++++++++++---
2 files changed, 69 insertions(+), 8 deletions(-)
--
2.43.0
next reply other threads:[~2024-03-18 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 18:23 Daniel P. Berrangé [this message]
2024-03-18 18:23 ` [PATCH 1/3 for 9.0] chardev: lower priority of the HUP GSource in socket chardev Daniel P. Berrangé
2024-03-18 19:17 ` Marc-André Lureau
2024-03-19 8:10 ` Thomas Huth
2024-03-18 18:23 ` [PATCH 2/3 for 9.0] Revert "chardev/char-socket: Fix TLS io channels sending too much data to the backend" Daniel P. Berrangé
2024-03-18 19:09 ` Marc-André Lureau
2024-03-19 13:14 ` Daniel P. Berrangé
2024-03-19 8:09 ` Thomas Huth
2024-03-18 18:23 ` [PATCH 3/3 for 9.0] Revert "chardev: use a child source for qio input source" Daniel P. Berrangé
2024-03-18 20:20 ` Marc-André Lureau
2024-03-19 11:07 ` Daniel P. Berrangé
2024-03-19 8:29 ` Thomas Huth
2024-03-19 9:32 ` [PATCH 0/3 for 9.0] Fix TLS support for chardevs and incoming data loss on EOF Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318182330.96738-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).