* [PATCH 1/2] aspeed: Make the ast2600-a3 SoC not user creatable
@ 2024-03-19 15:09 Cédric Le Goater
2024-03-19 15:09 ` [PATCH 2/2] aspeed: Make the ast1030-a1 " Cédric Le Goater
2024-03-19 15:50 ` [PATCH 1/2] aspeed: Make the ast2600-a3 " Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Cédric Le Goater @ 2024-03-19 15:09 UTC (permalink / raw)
To: Cédric Le Goater, Peter Maydell, Andrew Jeffery,
Joel Stanley
Cc: Cédric Le Goater, Thomas Huth, qemu-arm, qemu-devel
Aspeed SoCs are complex devices that can not be specified on the
command line. Fix that to avoid QEMU aborts.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227
Fixes: f25c0ae1079d ("aspeed/soc: Add AST2600 support")
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/arm/aspeed_ast2600.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
index 8a47d82d8371..03d115846e4d 100644
--- a/hw/arm/aspeed_ast2600.c
+++ b/hw/arm/aspeed_ast2600.c
@@ -743,6 +743,8 @@ static void aspeed_soc_ast2600_class_init(ObjectClass *oc, void *data)
AspeedSoCClass *sc = ASPEED_SOC_CLASS(oc);
dc->realize = aspeed_soc_ast2600_realize;
+ /* Reason: The Aspeed SoC can only be instantiated from a board */
+ dc->user_creatable = false;
sc->name = "ast2600-a3";
sc->valid_cpu_types = valid_cpu_types;
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] aspeed: Make the ast1030-a1 SoC not user creatable
2024-03-19 15:09 [PATCH 1/2] aspeed: Make the ast2600-a3 SoC not user creatable Cédric Le Goater
@ 2024-03-19 15:09 ` Cédric Le Goater
2024-03-19 15:50 ` Philippe Mathieu-Daudé
2024-03-19 15:50 ` [PATCH 1/2] aspeed: Make the ast2600-a3 " Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Cédric Le Goater @ 2024-03-19 15:09 UTC (permalink / raw)
To: Cédric Le Goater, Peter Maydell, Andrew Jeffery,
Joel Stanley
Cc: Cédric Le Goater, Thomas Huth, qemu-arm, qemu-devel
Aspeed SoCs are complex devices that can not be specified on the
command line. Fix that to avoid QEMU aborts.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227
Fixes: 356b230ed138 ("aspeed/soc : Add AST1030 support")
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/arm/aspeed_ast10x0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c
index 2634e0f6544e..9f98ad8e87ae 100644
--- a/hw/arm/aspeed_ast10x0.c
+++ b/hw/arm/aspeed_ast10x0.c
@@ -424,6 +424,8 @@ static void aspeed_soc_ast1030_class_init(ObjectClass *klass, void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
AspeedSoCClass *sc = ASPEED_SOC_CLASS(dc);
+ /* Reason: The Aspeed SoC can only be instantiated from a board */
+ dc->user_creatable = false;
dc->realize = aspeed_soc_ast1030_realize;
sc->name = "ast1030-a1";
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] aspeed: Make the ast2600-a3 SoC not user creatable
2024-03-19 15:09 [PATCH 1/2] aspeed: Make the ast2600-a3 SoC not user creatable Cédric Le Goater
2024-03-19 15:09 ` [PATCH 2/2] aspeed: Make the ast1030-a1 " Cédric Le Goater
@ 2024-03-19 15:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 15:50 UTC (permalink / raw)
To: Cédric Le Goater, Cédric Le Goater, Peter Maydell,
Andrew Jeffery, Joel Stanley
Cc: Thomas Huth, qemu-arm, qemu-devel
On 19/3/24 16:09, Cédric Le Goater wrote:
> Aspeed SoCs are complex devices that can not be specified on the
> command line. Fix that to avoid QEMU aborts.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227
> Fixes: f25c0ae1079d ("aspeed/soc: Add AST2600 support")
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/arm/aspeed_ast2600.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] aspeed: Make the ast1030-a1 SoC not user creatable
2024-03-19 15:09 ` [PATCH 2/2] aspeed: Make the ast1030-a1 " Cédric Le Goater
@ 2024-03-19 15:50 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 15:50 UTC (permalink / raw)
To: Cédric Le Goater, Cédric Le Goater, Peter Maydell,
Andrew Jeffery, Joel Stanley
Cc: Thomas Huth, qemu-arm, qemu-devel
On 19/3/24 16:09, Cédric Le Goater wrote:
> Aspeed SoCs are complex devices that can not be specified on the
> command line. Fix that to avoid QEMU aborts.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227
> Fixes: 356b230ed138 ("aspeed/soc : Add AST1030 support")
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/arm/aspeed_ast10x0.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-19 15:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 15:09 [PATCH 1/2] aspeed: Make the ast2600-a3 SoC not user creatable Cédric Le Goater
2024-03-19 15:09 ` [PATCH 2/2] aspeed: Make the ast1030-a1 " Cédric Le Goater
2024-03-19 15:50 ` Philippe Mathieu-Daudé
2024-03-19 15:50 ` [PATCH 1/2] aspeed: Make the ast2600-a3 " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).