From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9123BC54E68 for ; Thu, 21 Mar 2024 13:49:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnIm9-0000oW-Ot; Thu, 21 Mar 2024 09:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnIm8-0000oN-0y for qemu-devel@nongnu.org; Thu, 21 Mar 2024 09:48:08 -0400 Received: from mail-dm6nam11on2084.outbound.protection.outlook.com ([40.107.223.84] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnIm5-0002W6-Pp for qemu-devel@nongnu.org; Thu, 21 Mar 2024 09:48:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHh6WOB1+OX9msKmL13DPkWha/IlmiLfPxlkAchZ7bhGtimQ4c7pPtFBrJhD4nME221k9BfvpLFDCHZklTbuGf7sUAh+phCAHaSdzr1sj0+qJsOPWKAscHKhmLHXyjdJ81Aqhvk5KV+hdRPhwCsfJM/wKbZdUtI2O9JcwWfBFqVsadGHwhUod9IFcw9e3b0vaidsP/cMkv5Hu0G4NdURrQi/yrL+U84eK3fVZh92hSRNFoOe71GhZz1046OsEKS3wORp9bOwJZuwgTHBWAhnviE4wGyydzSEzCvaiTm+YWtlUHNCf1yyPn6rMFTdGVtrTUavvSO+6LcihBM0AwI4cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=olwHZXTcu4U6XXEs4yDcvWO4O0vqOn1EHft+LK+aDR0=; b=iy2huy3affVErjicRGXDKOifbqA0YfoC8ufQ7wXRs2zVghh6L7m4HBX6die68MZg62pxRx7CYR3OgaZbV/gEDfWRttZfQzQfLjqydnfqbCmpsT7UWsVuRBuDgQ0Y8Tyg9mdny/lzRGHC73HHlr2etIw5srxiALd8o/OFOsGCukNshxuWy4idqQL1j5MG5eahGQ+rEnPnLBnWUdzU4v6QAcxHraTc4E72C15ztG+/S8OWnJpnxsRk9nxGUz8WlskIQ6eBfnquGPkCS4RMpJtxfbyvRV7GlSlCD91pY1xRFUD5rs8jgaIgfM7nXfQ12uqMz4tDYt5a6eB4dageY5Z0RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=olwHZXTcu4U6XXEs4yDcvWO4O0vqOn1EHft+LK+aDR0=; b=Kqn1kPgJ+zAkDqJTr/6usp0MBNquf2TfboYhLdXbB3HRrowt7ceM9G2xsKK0SMM4YdII/enVmKy80WnXS+U9mBC87YHQku+HiNiZ2uqIe9nJ1ieLAbtla81b5Murtn6J6OhzFx/7TZ4Gizj+1cTB2v9fX67i14ShDaVHAeCMYE8= Received: from CH5PR02CA0019.namprd02.prod.outlook.com (2603:10b6:610:1ed::12) by BL3PR12MB6572.namprd12.prod.outlook.com (2603:10b6:208:38f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.34; Thu, 21 Mar 2024 13:42:59 +0000 Received: from CH1PEPF0000A349.namprd04.prod.outlook.com (2603:10b6:610:1ed:cafe::48) by CH5PR02CA0019.outlook.office365.com (2603:10b6:610:1ed::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend Transport; Thu, 21 Mar 2024 13:42:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A349.mail.protection.outlook.com (10.167.244.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Thu, 21 Mar 2024 13:42:59 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Mar 2024 08:42:58 -0500 Date: Thu, 21 Mar 2024 08:42:22 -0500 To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= CC: , , Tom Lendacky , Paolo Bonzini , "Markus Armbruster" , Pankaj Gupta , "Xiaoyao Li" , Isaku Yamahata Subject: Re: [PATCH v3 47/49] hw/i386/sev: Add support to encrypt BIOS when SEV-SNP is enabled Message-ID: <20240321134222.dsp4zswwm23ryxss@amd.com> References: <20240320083945.991426-1-michael.roth@amd.com> <20240320083945.991426-48-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A349:EE_|BL3PR12MB6572:EE_ X-MS-Office365-Filtering-Correlation-Id: 6aca1df4-b58f-4101-47ed-08dc49acd285 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NuZPfhne9eDWObU0SDlG2H02JGaXPNe1rTF4wWCKnJ/uP8D3AgKAUZDI2B9KHWyW/mhRUTiQItrQN93FkhCwE8zfQTRznbGBz86GJ0lreJ4fHFsvzdOBdkqiP8D9LHC/ndMDe+PxCnZacxVJVW2wkF2T6/PG0CxY9DfPp9MgB9urbkZgDJwHuK1sxzLnPcZeDYQTCtheFa9q1b/aCEAVDnX9RKXHB3/ccZoPK+G6t65OBIJTkDOrXlNEXrh0Su+1msrLsqatsLyMcc8ibZ4qhdwA5ipIDpg3Ut9fi0n2TonxgatDgZbCEi4bLDMUQ2jyQfk6HEsKnHyH5BUQdxS3vmM1Jl7k/lA7ySxBx6L5BP4BrkynaXMbG4Av1t9MS/zLjD7GHf/td/3zUxNfq9lkV3I6tRul23A7SVnWx4pk+ZjD5pB15v7RHtYlG0R10vnOpVAoaKDLZs4KcJDbKloXmc/qu3zTyG7q3K+R9cVR/2YwwVTOGLQMpWSYdh4dm+VeaXEyy8Ihbd+8Bw9yBg+StPAXunECu9NCZJ5xGmxV/SoCzjGDJUCOqKAwZgbRIa8gLi+nh5B2LVefdX/u7NZUEuirdXZbmQuPsTs0Eir5zLU/6DTHITC4kdWq9KRqoepxSll2cnvbCwbvNW09gqpOZdrqvg5JPoAIb2+X9WQYCVw9ngtu1BYeSRri+TEtJHCvI4/GUH6oXerOA06PCm6MXA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(376005)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 13:42:59.4295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6aca1df4-b58f-4101-47ed-08dc49acd285 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A349.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6572 Received-SPF: permerror client-ip=40.107.223.84; envelope-from=Michael.Roth@amd.com; helo=NAM11-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Michael Roth From: Michael Roth via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Mar 20, 2024 at 12:22:34PM +0000, Daniel P. Berrangé wrote: > On Wed, Mar 20, 2024 at 03:39:43AM -0500, Michael Roth wrote: > > TODO: Brijesh as author, me as co-author (vice-versa depending) > > drop flash handling? we only support BIOS now > > A reminder that this commit message needs fixing. Sorry, definitely meant to fix this one up before submitting. I've gone ahead and force-pushed an updated tree to same qemu-v3-rc branch. The only change is proper attribution/commit message for this patch: https://github.com/AMDESE/qemu/commit/c54618a1cc23f2398e6c3af6f3cf140c4901347c -Mike > > > > > Signed-off-by: Michael Roth > > --- > > hw/i386/pc_sysfw.c | 12 +++++++----- > > hw/i386/x86.c | 2 +- > > include/hw/i386/x86.h | 2 +- > > target/i386/sev-sysemu-stub.c | 2 +- > > target/i386/sev.c | 15 +++++++++++---- > > target/i386/sev.h | 2 +- > > 6 files changed, 22 insertions(+), 13 deletions(-) > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| >