* [PATCH] hw/ppc/spapr: Include missing 'sysemu/tcg.h' header
@ 2024-03-22 16:24 Philippe Mathieu-Daudé
2024-03-26 4:57 ` Harsh Prateek Bora
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-22 16:24 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-ppc, Harsh Prateek Bora, Nicholas Piggin,
Daniel Henrique Barboza, David Gibson,
Philippe Mathieu-Daudé
"sysemu/tcg.h" declares tcg_enabled(), and is implicitly included.
Include it explicitly to avoid the following error when refactoring
headers:
hw/ppc/spapr.c:2612:9: error: call to undeclared function 'tcg_enabled'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (tcg_enabled()) {
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index c417f9dd52..e9bc97fee0 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -35,6 +35,7 @@
#include "sysemu/sysemu.h"
#include "sysemu/hostmem.h"
#include "sysemu/numa.h"
+#include "sysemu/tcg.h"
#include "sysemu/qtest.h"
#include "sysemu/reset.h"
#include "sysemu/runstate.h"
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/ppc/spapr: Include missing 'sysemu/tcg.h' header
2024-03-22 16:24 [PATCH] hw/ppc/spapr: Include missing 'sysemu/tcg.h' header Philippe Mathieu-Daudé
@ 2024-03-26 4:57 ` Harsh Prateek Bora
0 siblings, 0 replies; 2+ messages in thread
From: Harsh Prateek Bora @ 2024-03-26 4:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-ppc, Nicholas Piggin, Daniel Henrique Barboza, David Gibson
On 3/22/24 21:54, Philippe Mathieu-Daudé wrote:
> "sysemu/tcg.h" declares tcg_enabled(), and is implicitly included.
> Include it explicitly to avoid the following error when refactoring
> headers:
>
> hw/ppc/spapr.c:2612:9: error: call to undeclared function 'tcg_enabled'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> if (tcg_enabled()) {
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index c417f9dd52..e9bc97fee0 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -35,6 +35,7 @@
> #include "sysemu/sysemu.h"
> #include "sysemu/hostmem.h"
> #include "sysemu/numa.h"
> +#include "sysemu/tcg.h"
> #include "sysemu/qtest.h"
> #include "sysemu/reset.h"
> #include "sysemu/runstate.h"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-26 4:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-22 16:24 [PATCH] hw/ppc/spapr: Include missing 'sysemu/tcg.h' header Philippe Mathieu-Daudé
2024-03-26 4:57 ` Harsh Prateek Bora
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).