From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: svens@stackframe.org, deller@gmx.de
Subject: [PATCH v2 4/7] target/hppa: Fix ADD/SUB trap on overflow for narrow mode
Date: Sat, 23 Mar 2024 07:29:51 -1000 [thread overview]
Message-ID: <20240323172954.1041480-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240323172954.1041480-1-richard.henderson@linaro.org>
From: Sven Schnelle <svens@stackframe.org>
Fixes: c53e401ed9ff ("target/hppa: Remove TARGET_REGISTER_BITS")
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240321184228.611897-2-svens@stackframe.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hppa/translate.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 2cb91956da..ceb739c54a 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -1126,6 +1126,9 @@ static void do_add(DisasContext *ctx, unsigned rt, TCGv_i64 in1,
if (is_tsv || cond_need_sv(c)) {
sv = do_add_sv(ctx, dest, in1, in2);
if (is_tsv) {
+ if (!d) {
+ tcg_gen_ext32s_i64(sv, sv);
+ }
/* ??? Need to include overflow from shift. */
gen_helper_tsv(tcg_env, sv);
}
@@ -1217,6 +1220,9 @@ static void do_sub(DisasContext *ctx, unsigned rt, TCGv_i64 in1,
if (is_tsv || cond_need_sv(c)) {
sv = do_sub_sv(ctx, dest, in1, in2);
if (is_tsv) {
+ if (!d) {
+ tcg_gen_ext32s_i64(sv, sv);
+ }
gen_helper_tsv(tcg_env, sv);
}
}
--
2.34.1
next prev parent reply other threads:[~2024-03-23 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 17:29 [PATCH for-9.0 v2 0/7] target/hppa: more small fixes Richard Henderson
2024-03-23 17:29 ` [PATCH v2 1/7] target/hppa: Fix BE,L set of sr0 Richard Henderson
2024-03-23 20:53 ` Helge Deller
2024-03-23 17:29 ` [PATCH v2 2/7] target/hppa: Fix B,GATE for wide mode Richard Henderson
2024-03-23 17:29 ` [PATCH v2 3/7] target/hppa: Handle unit conditions " Richard Henderson
2024-03-23 17:29 ` Richard Henderson [this message]
2024-03-23 17:29 ` [PATCH v2 5/7] target/hppa: Mark interval timer write as io Richard Henderson
2024-03-23 20:58 ` Helge Deller
2024-03-23 17:29 ` [PATCH v2 6/7] target/hppa: Tidy read of interval timer Richard Henderson
2024-03-23 20:58 ` Helge Deller
2024-03-23 17:29 ` [PATCH v2 7/7] target/hppa: Fix EIRR, EIEM versus icount Richard Henderson
2024-03-23 21:00 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240323172954.1041480-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).