* [PULL 0/7] target-arm queue @ 2024-03-25 12:35 Peter Maydell 2024-03-25 12:35 ` [PULL 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line Peter Maydell ` (6 more replies) 0 siblings, 7 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel It's been quiet on the arm front this week, so all I have is these coverity fixes I posted a while back... -- PMM The following changes since commit 853546f8128476eefb701d4a55b2781bb3a46faa: Merge tag 'pull-loongarch-20240322' of https://gitlab.com/gaosong/qemu into staging (2024-03-22 10:59:57 +0000) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20240325 for you to fetch changes up to 55c79639d553c1b7a82b4cde781ad5f316f45b0e: tests/qtest/libqtest.c: Check for g_setenv() failure (2024-03-25 10:41:01 +0000) ---------------------------------------------------------------- target-arm queue: * Fixes for seven minor coverity issues ---------------------------------------------------------------- Peter Maydell (7): tests/qtest/npcm7xx_emc_test: Don't leak cmd_line tests/unit/socket-helpers: Don't close(-1) net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() hw/misc/pca9554: Correct error check bounds in get/set pin functions hw/nvram/mac_nvram: Report failure to write data tests/unit/test-throttle: Avoid unintended integer division tests/qtest/libqtest.c: Check for g_setenv() failure hw/misc/pca9554.c | 4 ++-- hw/nvram/mac_nvram.c | 5 ++++- net/af-xdp.c | 3 +-- tests/qtest/libqtest.c | 6 +++++- tests/qtest/npcm7xx_emc-test.c | 4 ++-- tests/unit/socket-helpers.c | 4 +++- tests/unit/test-throttle.c | 4 ++-- 7 files changed, 19 insertions(+), 11 deletions(-) ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PULL 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 2024-03-25 12:35 ` [PULL 2/7] tests/unit/socket-helpers: Don't close(-1) Peter Maydell ` (5 subsequent siblings) 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel In test_rx() and test_tx() we allocate a GString *cmd_line but never free it. This is pretty harmless in a test case, but Coverity spotted it. Resolves: Coverity CID 1507122 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-id: 20240312183810.557768-2-peter.maydell@linaro.org --- tests/qtest/npcm7xx_emc-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/npcm7xx_emc-test.c b/tests/qtest/npcm7xx_emc-test.c index 63f6cadb5cc..2e1a1a6d702 100644 --- a/tests/qtest/npcm7xx_emc-test.c +++ b/tests/qtest/npcm7xx_emc-test.c @@ -789,7 +789,7 @@ static void emc_test_ptle(QTestState *qts, const EMCModule *mod, int fd) static void test_tx(gconstpointer test_data) { const TestData *td = test_data; - GString *cmd_line = g_string_new("-machine quanta-gsj"); + g_autoptr(GString) cmd_line = g_string_new("-machine quanta-gsj"); int *test_sockets = packet_test_init(emc_module_index(td->module), cmd_line); QTestState *qts = qtest_init(cmd_line->str); @@ -814,7 +814,7 @@ static void test_tx(gconstpointer test_data) static void test_rx(gconstpointer test_data) { const TestData *td = test_data; - GString *cmd_line = g_string_new("-machine quanta-gsj"); + g_autoptr(GString) cmd_line = g_string_new("-machine quanta-gsj"); int *test_sockets = packet_test_init(emc_module_index(td->module), cmd_line); QTestState *qts = qtest_init(cmd_line->str); -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 2/7] tests/unit/socket-helpers: Don't close(-1) 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell 2024-03-25 12:35 ` [PULL 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 2024-03-25 12:35 ` [PULL 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() Peter Maydell ` (4 subsequent siblings) 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel In socket_check_afunix_support() we call socket(PF_UNIX, SOCK_STREAM, 0) to see if it works, but we call close() on the result whether it worked or not. Only close the fd if the socket() call succeeded. Spotted by Coverity. Resolves: Coverity CID 1497481 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-id: 20240312183810.557768-3-peter.maydell@linaro.org --- tests/unit/socket-helpers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/unit/socket-helpers.c b/tests/unit/socket-helpers.c index 6de27baee2e..f3439cc4e52 100644 --- a/tests/unit/socket-helpers.c +++ b/tests/unit/socket-helpers.c @@ -160,7 +160,6 @@ void socket_check_afunix_support(bool *has_afunix) int fd; fd = socket(PF_UNIX, SOCK_STREAM, 0); - close(fd); #ifdef _WIN32 *has_afunix = (fd != (int)INVALID_SOCKET); @@ -168,5 +167,8 @@ void socket_check_afunix_support(bool *has_afunix) *has_afunix = (fd >= 0); #endif + if (*has_afunix) { + close(fd); + } return; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell 2024-03-25 12:35 ` [PULL 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line Peter Maydell 2024-03-25 12:35 ` [PULL 2/7] tests/unit/socket-helpers: Don't close(-1) Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 2024-03-25 12:35 ` [PULL 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions Peter Maydell ` (3 subsequent siblings) 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel In net_init_af_xdp() we parse the arguments and allocate a buffer of ints into sock_fds. However, although we free this in the error exit path, we don't ever free it in the successful return path. Coverity spots this leak. Switch to g_autofree so we don't need to manually free the array. Resolves: Coverity CID 1534906 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-id: 20240312183810.557768-4-peter.maydell@linaro.org --- net/af-xdp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/af-xdp.c b/net/af-xdp.c index 38e600703a3..01c5fb914ec 100644 --- a/net/af-xdp.c +++ b/net/af-xdp.c @@ -446,7 +446,7 @@ int net_init_af_xdp(const Netdev *netdev, NetClientState *nc, *nc0 = NULL; unsigned int ifindex; uint32_t prog_id = 0; - int *sock_fds = NULL; + g_autofree int *sock_fds = NULL; int64_t i, queues; Error *err = NULL; AFXDPState *s; @@ -516,7 +516,6 @@ int net_init_af_xdp(const Netdev *netdev, return 0; err: - g_free(sock_fds); if (nc0) { qemu_del_net_client(nc0); } -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell ` (2 preceding siblings ...) 2024-03-25 12:35 ` [PULL 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 2024-03-25 12:35 ` [PULL 5/7] hw/nvram/mac_nvram: Report failure to write data Peter Maydell ` (2 subsequent siblings) 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel In pca9554_get_pin() and pca9554_set_pin(), we try to detect an incorrect pin value, but we get the condition wrong, using ">" when ">=" was intended. This has no actual effect, because in pca9554_initfn() we use the correct test when creating the properties and so we'll never be called with an out of range value. However, Coverity complains about the mismatch between the check and the later use of the pin value in a shift operation. Use the correct condition. Resolves: Coverity CID 1534917 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-id: 20240312183810.557768-5-peter.maydell@linaro.org --- hw/misc/pca9554.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/pca9554.c b/hw/misc/pca9554.c index 778b32e4430..5e31696797d 100644 --- a/hw/misc/pca9554.c +++ b/hw/misc/pca9554.c @@ -160,7 +160,7 @@ static void pca9554_get_pin(Object *obj, Visitor *v, const char *name, error_setg(errp, "%s: error reading %s", __func__, name); return; } - if (pin < 0 || pin > PCA9554_PIN_COUNT) { + if (pin < 0 || pin >= PCA9554_PIN_COUNT) { error_setg(errp, "%s invalid pin %s", __func__, name); return; } @@ -187,7 +187,7 @@ static void pca9554_set_pin(Object *obj, Visitor *v, const char *name, error_setg(errp, "%s: error reading %s", __func__, name); return; } - if (pin < 0 || pin > PCA9554_PIN_COUNT) { + if (pin < 0 || pin >= PCA9554_PIN_COUNT) { error_setg(errp, "%s invalid pin %s", __func__, name); return; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 5/7] hw/nvram/mac_nvram: Report failure to write data 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell ` (3 preceding siblings ...) 2024-03-25 12:35 ` [PULL 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 2024-03-25 12:35 ` [PULL 6/7] tests/unit/test-throttle: Avoid unintended integer division Peter Maydell 2024-03-25 12:35 ` [PULL 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure Peter Maydell 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel There's no way for the macio_nvram device to report failure to write data, but we can at least report it to the user with error_report() as we do in other devices like xlnx-efuse. Spotted by Coverity. Resolves: Coverity CID 1507628 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-id: 20240312183810.557768-6-peter.maydell@linaro.org --- hw/nvram/mac_nvram.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c index 5f9d16fb3e3..59277fbc776 100644 --- a/hw/nvram/mac_nvram.c +++ b/hw/nvram/mac_nvram.c @@ -48,7 +48,10 @@ static void macio_nvram_writeb(void *opaque, hwaddr addr, trace_macio_nvram_write(addr, value); s->data[addr] = value; if (s->blk) { - blk_pwrite(s->blk, addr, 1, &s->data[addr], 0); + if (blk_pwrite(s->blk, addr, 1, &s->data[addr], 0) < 0) { + error_report("%s: write of NVRAM data to backing store failed", + blk_name(s->blk)); + } } } -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 6/7] tests/unit/test-throttle: Avoid unintended integer division 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell ` (4 preceding siblings ...) 2024-03-25 12:35 ` [PULL 5/7] hw/nvram/mac_nvram: Report failure to write data Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 2024-03-25 12:35 ` [PULL 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure Peter Maydell 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel In test_compute_wait() we do double units = bkt.max / 10; which does an integer division and then assigns it to a double variable, and similarly later on in the expression for an assertion. Use 10.0 so that we do a floating point division and calculate the exact value, rather than doing an integer division. Spotted by Coverity. Resolves: Coverity CID 1432564 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-id: 20240312183810.557768-7-peter.maydell@linaro.org --- tests/unit/test-throttle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c index 2146cfacd36..24032a02667 100644 --- a/tests/unit/test-throttle.c +++ b/tests/unit/test-throttle.c @@ -127,13 +127,13 @@ static void test_compute_wait(void) bkt.avg = 10; bkt.max = 200; for (i = 0; i < 22; i++) { - double units = bkt.max / 10; + double units = bkt.max / 10.0; bkt.level += units; bkt.burst_level += units; throttle_leak_bucket(&bkt, NANOSECONDS_PER_SECOND / 10); wait = throttle_compute_wait(&bkt); g_assert(double_cmp(bkt.burst_level, 0)); - g_assert(double_cmp(bkt.level, (i + 1) * (bkt.max - bkt.avg) / 10)); + g_assert(double_cmp(bkt.level, (i + 1) * (bkt.max - bkt.avg) / 10.0)); /* We can do bursts for the 2 seconds we have configured in * burst_length. We have 100 extra milliseconds of burst * because bkt.level has been leaking during this time. -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell ` (5 preceding siblings ...) 2024-03-25 12:35 ` [PULL 6/7] tests/unit/test-throttle: Avoid unintended integer division Peter Maydell @ 2024-03-25 12:35 ` Peter Maydell 6 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2024-03-25 12:35 UTC (permalink / raw) To: qemu-devel Coverity points out that g_setenv() can fail and we don't check for this in qtest_inproc_init(). In practice this will only fail if a memory allocation failed in setenv() or if the caller passed an invalid architecture name (e.g. one with an '=' in it), so rather than requiring the callsite to check for failure, make g_setenv() failure fatal here, similarly to what we did in commit aca68d95c515. Resolves: Coverity CID 1497485 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-id: 20240312183810.557768-8-peter.maydell@linaro.org --- tests/qtest/libqtest.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index f33a2108610..d8f80d335e7 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1814,7 +1814,11 @@ QTestState *qtest_inproc_init(QTestState **s, bool log, const char* arch, * way, qtest_get_arch works for inproc qtest. */ gchar *bin_path = g_strconcat("/qemu-system-", arch, NULL); - g_setenv("QTEST_QEMU_BINARY", bin_path, 0); + if (!g_setenv("QTEST_QEMU_BINARY", bin_path, 0)) { + fprintf(stderr, + "Could not set environment variable QTEST_QEMU_BINARY\n"); + exit(1); + } g_free(bin_path); return qts; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PULL 0/7] target-arm queue @ 2023-07-17 12:47 Peter Maydell 2023-07-17 19:12 ` Richard Henderson 0 siblings, 1 reply; 18+ messages in thread From: Peter Maydell @ 2023-07-17 12:47 UTC (permalink / raw) To: qemu-devel A last small test of bug fixes before rc1. thanks -- PMM The following changes since commit ed8ad9728a9c0eec34db9dff61dfa2f1dd625637: Merge tag 'pull-tpm-2023-07-14-1' of https://github.com/stefanberger/qemu-tpm into staging (2023-07-15 14:54:04 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230717 for you to fetch changes up to c2c1c4a35c7c2b1a4140b0942b9797c857e476a4: hw/nvram: Avoid unnecessary Xilinx eFuse backstore write (2023-07-17 11:05:52 +0100) ---------------------------------------------------------------- target-arm queue: * hw/arm/sbsa-ref: set 'slots' property of xhci * linux-user: Remove pointless NULL check in clock_adjtime handling * ptw: Fix S1_ptw_translate() debug path * ptw: Account for FEAT_RME when applying {N}SW, SA bits * accel/tcg: Zero-pad PC in TCG CPU exec trace lines * hw/nvram: Avoid unnecessary Xilinx eFuse backstore write ---------------------------------------------------------------- Peter Maydell (5): linux-user: Remove pointless NULL check in clock_adjtime handling target/arm/ptw.c: Add comments to S1Translate struct fields target/arm: Fix S1_ptw_translate() debug path target/arm/ptw.c: Account for FEAT_RME when applying {N}SW, SA bits accel/tcg: Zero-pad PC in TCG CPU exec trace lines Tong Ho (1): hw/nvram: Avoid unnecessary Xilinx eFuse backstore write Yuquan Wang (1): hw/arm/sbsa-ref: set 'slots' property of xhci accel/tcg/cpu-exec.c | 4 +-- accel/tcg/translate-all.c | 2 +- hw/arm/sbsa-ref.c | 1 + hw/nvram/xlnx-efuse.c | 11 ++++-- linux-user/syscall.c | 12 +++---- target/arm/ptw.c | 90 +++++++++++++++++++++++++++++++++++++++++------ 6 files changed, 98 insertions(+), 22 deletions(-) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PULL 0/7] target-arm queue 2023-07-17 12:47 [PULL 0/7] target-arm queue Peter Maydell @ 2023-07-17 19:12 ` Richard Henderson 0 siblings, 0 replies; 18+ messages in thread From: Richard Henderson @ 2023-07-17 19:12 UTC (permalink / raw) To: Peter Maydell, qemu-devel On 7/17/23 13:47, Peter Maydell wrote: > A last small test of bug fixes before rc1. > > thanks > -- PMM > > The following changes since commit ed8ad9728a9c0eec34db9dff61dfa2f1dd625637: > > Merge tag 'pull-tpm-2023-07-14-1' ofhttps://github.com/stefanberger/qemu-tpm into staging (2023-07-15 14:54:04 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230717 > > for you to fetch changes up to c2c1c4a35c7c2b1a4140b0942b9797c857e476a4: > > hw/nvram: Avoid unnecessary Xilinx eFuse backstore write (2023-07-17 11:05:52 +0100) > > ---------------------------------------------------------------- > target-arm queue: > * hw/arm/sbsa-ref: set 'slots' property of xhci > * linux-user: Remove pointless NULL check in clock_adjtime handling > * ptw: Fix S1_ptw_translate() debug path > * ptw: Account for FEAT_RME when applying {N}SW, SA bits > * accel/tcg: Zero-pad PC in TCG CPU exec trace lines > * hw/nvram: Avoid unnecessary Xilinx eFuse backstore write Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate. r~ ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PULL 0/7] target-arm queue @ 2022-11-04 11:35 Peter Maydell 2022-11-05 12:34 ` Stefan Hajnoczi 0 siblings, 1 reply; 18+ messages in thread From: Peter Maydell @ 2022-11-04 11:35 UTC (permalink / raw) To: qemu-devel Hi; this pull request has a collection of bug fixes for rc0. The big one is the trusted firmware boot regression fix. thanks -- PMM The following changes since commit ece5f8374d0416a339f0c0a9399faa2c42d4ad6f: Merge tag 'linux-user-for-7.2-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-11-03 10:55:05 -0400) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20221104 for you to fetch changes up to cead7fa4c06087c86c67c5ce815cc1ff0bfeac3a: target/arm: Two fixes for secure ptw (2022-11-04 10:58:58 +0000) ---------------------------------------------------------------- target-arm queue: * Fix regression booting Trusted Firmware * Honor HCR_E2H and HCR_TGE in ats_write64() * Copy the entire vector in DO_ZIP * Fix Privileged Access Never (PAN) for aarch32 * Make TLBIOS and TLBIRANGE ops trap on HCR_EL2.TTLB * Set SCR_EL3.HXEn when direct booting kernel * Set SME and SVE EL3 vector lengths when direct booting kernel ---------------------------------------------------------------- Ake Koomsin (1): target/arm: Honor HCR_E2H and HCR_TGE in ats_write64() Peter Maydell (3): hw/arm/boot: Set SME and SVE EL3 vector lengths when booting kernel hw/arm/boot: Set SCR_EL3.HXEn when booting kernel target/arm: Make TLBIOS and TLBIRANGE ops trap on HCR_EL2.TTLB Richard Henderson (2): target/arm: Copy the entire vector in DO_ZIP target/arm: Two fixes for secure ptw Timofey Kutergin (1): target/arm: Fix Privileged Access Never (PAN) for aarch32 hw/arm/boot.c | 5 ++++ target/arm/helper.c | 64 +++++++++++++++++++++++++++++-------------------- target/arm/ptw.c | 50 ++++++++++++++++++++++++++++---------- target/arm/sve_helper.c | 4 ++-- 4 files changed, 83 insertions(+), 40 deletions(-) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PULL 0/7] target-arm queue 2022-11-04 11:35 Peter Maydell @ 2022-11-05 12:34 ` Stefan Hajnoczi 0 siblings, 0 replies; 18+ messages in thread From: Stefan Hajnoczi @ 2022-11-05 12:34 UTC (permalink / raw) To: Peter Maydell; +Cc: qemu-devel [-- Attachment #1: Type: text/plain, Size: 115 bytes --] Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PULL 0/7] target-arm queue @ 2021-03-23 14:26 Peter Maydell 2021-03-23 22:28 ` Peter Maydell 0 siblings, 1 reply; 18+ messages in thread From: Peter Maydell @ 2021-03-23 14:26 UTC (permalink / raw) To: qemu-devel Small pullreq with some bug fixes to go into rc1. -- PMM The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' into staging (2021-03-22 18:50:25 +0000) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210323 for you to fetch changes up to dad90de78e9e9d47cefcbcd30115706b98e6ec87: target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill (2021-03-23 14:07:55 +0000) ---------------------------------------------------------------- target-arm queue: * hw/arm/virt: Disable pl011 clock migration if needed * target/arm: Make M-profile VTOR loads on reset handle memory aliasing * target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill ---------------------------------------------------------------- Gavin Shan (1): hw/arm/virt: Disable pl011 clock migration if needed Peter Maydell (5): memory: Make flatview_cb return bool, not int memory: Document flatview_for_each_range() memory: Add offset_in_region to flatview_cb arguments hw/core/loader: Add new function rom_ptr_for_as() target/arm: Make M-profile VTOR loads on reset handle memory aliasing Richard Henderson (1): target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill include/exec/memory.h | 32 +++++++++++++++--- include/hw/char/pl011.h | 1 + include/hw/loader.h | 31 +++++++++++++++++ hw/char/pl011.c | 9 +++++ hw/core/loader.c | 75 +++++++++++++++++++++++++++++++++++++++++ hw/core/machine.c | 1 + softmmu/memory.c | 4 ++- target/arm/cpu.c | 2 +- target/arm/tlb_helper.c | 1 + tests/qtest/fuzz/generic_fuzz.c | 11 +++--- 10 files changed, 157 insertions(+), 10 deletions(-) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PULL 0/7] target-arm queue 2021-03-23 14:26 Peter Maydell @ 2021-03-23 22:28 ` Peter Maydell 0 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2021-03-23 22:28 UTC (permalink / raw) To: QEMU Developers On Tue, 23 Mar 2021 at 14:26, Peter Maydell <peter.maydell@linaro.org> wrote: > > Small pullreq with some bug fixes to go into rc1. > > -- PMM > > The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: > > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' into staging (2021-03-22 18:50:25 +0000) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210323 > > for you to fetch changes up to dad90de78e9e9d47cefcbcd30115706b98e6ec87: > > target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill (2021-03-23 14:07:55 +0000) > > ---------------------------------------------------------------- > target-arm queue: > * hw/arm/virt: Disable pl011 clock migration if needed > * target/arm: Make M-profile VTOR loads on reset handle memory aliasing > * target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PULL 0/7] target-arm queue @ 2020-07-27 15:19 Peter Maydell 2020-07-28 18:43 ` Peter Maydell 0 siblings, 1 reply; 18+ messages in thread From: Peter Maydell @ 2020-07-27 15:19 UTC (permalink / raw) To: qemu-devel Just some bugfixes this time around. -- PMM The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.1-20200727' into staging (2020-07-27 09:33:04 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200727 for you to fetch changes up to d4f6dda182e19afa75706936805e18397cb95f07: target/arm: Improve IMPDEF algorithm for IRG (2020-07-27 16:12:11 +0100) ---------------------------------------------------------------- target-arm queue: * ACPI: Assert that we don't run out of the preallocated memory * hw/misc/aspeed_sdmc: Fix incorrect memory size * target/arm: Always pass cacheattr in S1_ptw_translate * docs/system/arm/virt: Document 'mte' machine option * hw/arm/boot: Fix PAUTH, MTE for EL3 direct kernel boot * target/arm: Improve IMPDEF algorithm for IRG ---------------------------------------------------------------- Dongjiu Geng (1): ACPI: Assert that we don't run out of the preallocated memory Peter Maydell (1): docs/system/arm/virt: Document 'mte' machine option Philippe Mathieu-Daudé (1): hw/misc/aspeed_sdmc: Fix incorrect memory size Richard Henderson (4): target/arm: Always pass cacheattr in S1_ptw_translate hw/arm/boot: Fix PAUTH for EL3 direct kernel boot hw/arm/boot: Fix MTE for EL3 direct kernel boot target/arm: Improve IMPDEF algorithm for IRG docs/system/arm/virt.rst | 4 ++++ hw/acpi/ghes.c | 12 ++++-------- hw/arm/boot.c | 6 ++++++ hw/misc/aspeed_sdmc.c | 7 ++++--- target/arm/helper.c | 19 ++++++------------- target/arm/mte_helper.c | 37 ++++++++++++++++++++++++++++++------- 6 files changed, 54 insertions(+), 31 deletions(-) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PULL 0/7] target-arm queue 2020-07-27 15:19 Peter Maydell @ 2020-07-28 18:43 ` Peter Maydell 0 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2020-07-28 18:43 UTC (permalink / raw) To: QEMU Developers On Mon, 27 Jul 2020 at 16:19, Peter Maydell <peter.maydell@linaro.org> wrote: > > Just some bugfixes this time around. > > -- PMM > > The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.1-20200727' into staging (2020-07-27 09:33:04 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200727 > > for you to fetch changes up to d4f6dda182e19afa75706936805e18397cb95f07: > > target/arm: Improve IMPDEF algorithm for IRG (2020-07-27 16:12:11 +0100) > > ---------------------------------------------------------------- > target-arm queue: > * ACPI: Assert that we don't run out of the preallocated memory > * hw/misc/aspeed_sdmc: Fix incorrect memory size > * target/arm: Always pass cacheattr in S1_ptw_translate > * docs/system/arm/virt: Document 'mte' machine option > * hw/arm/boot: Fix PAUTH, MTE for EL3 direct kernel boot > * target/arm: Improve IMPDEF algorithm for IRG > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PULL 0/7] target-arm queue @ 2019-11-19 13:31 Peter Maydell 2019-11-19 15:55 ` Peter Maydell 0 siblings, 1 reply; 18+ messages in thread From: Peter Maydell @ 2019-11-19 13:31 UTC (permalink / raw) To: qemu-devel Target-arm queue for rc2 -- just some minor bugfixes. thanks -- PMM The following changes since commit 6e5d4999c761ffa082f60d72a14e5c953515b417: Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2019-11-19' into staging (2019-11-19 11:29:01 +0000) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20191119 for you to fetch changes up to 04c9c81b8fa2ee33f59a26265700fae6fc646062: target/arm: Support EL0 v7m msr/mrs for CONFIG_USER_ONLY (2019-11-19 13:20:28 +0000) ---------------------------------------------------------------- target-arm queue: * Support EL0 v7m msr/mrs for CONFIG_USER_ONLY * Relax r13 restriction for ldrex/strex for v8.0 * Do not reject rt == rt2 for strexd * net/cadence_gem: Set PHY autonegotiation restart status * ssi: xilinx_spips: Skip spi bus update for a few register writes * pl031: Expose RTCICR as proper WC register ---------------------------------------------------------------- Alexander Graf (1): pl031: Expose RTCICR as proper WC register Linus Ziegert (1): net/cadence_gem: Set PHY autonegotiation restart status Richard Henderson (4): target/arm: Merge arm_cpu_vq_map_next_smaller into sole caller target/arm: Do not reject rt == rt2 for strexd target/arm: Relax r13 restriction for ldrex/strex for v8.0 target/arm: Support EL0 v7m msr/mrs for CONFIG_USER_ONLY Sai Pavan Boddu (1): ssi: xilinx_spips: Skip spi bus update for a few register writes target/arm/cpu.h | 5 +-- hw/net/cadence_gem.c | 9 ++-- hw/rtc/pl031.c | 6 +-- hw/ssi/xilinx_spips.c | 22 ++++++++-- target/arm/cpu64.c | 15 ------- target/arm/helper.c | 9 +++- target/arm/m_helper.c | 114 ++++++++++++++++++++++++++++++------------------- target/arm/translate.c | 14 +++--- 8 files changed, 113 insertions(+), 81 deletions(-) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PULL 0/7] target-arm queue 2019-11-19 13:31 Peter Maydell @ 2019-11-19 15:55 ` Peter Maydell 0 siblings, 0 replies; 18+ messages in thread From: Peter Maydell @ 2019-11-19 15:55 UTC (permalink / raw) To: QEMU Developers On Tue, 19 Nov 2019 at 13:31, Peter Maydell <peter.maydell@linaro.org> wrote: > > Target-arm queue for rc2 -- just some minor bugfixes. > > thanks > -- PMM > > The following changes since commit 6e5d4999c761ffa082f60d72a14e5c953515b417: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2019-11-19' into staging (2019-11-19 11:29:01 +0000) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20191119 > > for you to fetch changes up to 04c9c81b8fa2ee33f59a26265700fae6fc646062: > > target/arm: Support EL0 v7m msr/mrs for CONFIG_USER_ONLY (2019-11-19 13:20:28 +0000) > > ---------------------------------------------------------------- > target-arm queue: > * Support EL0 v7m msr/mrs for CONFIG_USER_ONLY > * Relax r13 restriction for ldrex/strex for v8.0 > * Do not reject rt == rt2 for strexd > * net/cadence_gem: Set PHY autonegotiation restart status > * ssi: xilinx_spips: Skip spi bus update for a few register writes > * pl031: Expose RTCICR as proper WC register > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-03-25 12:37 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-25 12:35 [PULL 0/7] target-arm queue Peter Maydell 2024-03-25 12:35 ` [PULL 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line Peter Maydell 2024-03-25 12:35 ` [PULL 2/7] tests/unit/socket-helpers: Don't close(-1) Peter Maydell 2024-03-25 12:35 ` [PULL 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() Peter Maydell 2024-03-25 12:35 ` [PULL 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions Peter Maydell 2024-03-25 12:35 ` [PULL 5/7] hw/nvram/mac_nvram: Report failure to write data Peter Maydell 2024-03-25 12:35 ` [PULL 6/7] tests/unit/test-throttle: Avoid unintended integer division Peter Maydell 2024-03-25 12:35 ` [PULL 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2023-07-17 12:47 [PULL 0/7] target-arm queue Peter Maydell 2023-07-17 19:12 ` Richard Henderson 2022-11-04 11:35 Peter Maydell 2022-11-05 12:34 ` Stefan Hajnoczi 2021-03-23 14:26 Peter Maydell 2021-03-23 22:28 ` Peter Maydell 2020-07-27 15:19 Peter Maydell 2020-07-28 18:43 ` Peter Maydell 2019-11-19 13:31 Peter Maydell 2019-11-19 15:55 ` Peter Maydell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).