From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 5/9] aspeed: Make the ast1030-a1 SoC not user creatable
Date: Mon, 25 Mar 2024 15:12:06 +0100 [thread overview]
Message-ID: <20240325141210.788356-6-thuth@redhat.com> (raw)
In-Reply-To: <20240325141210.788356-1-thuth@redhat.com>
From: Cédric Le Goater <clg@redhat.com>
Aspeed SoCs are complex devices that can not be specified on the
command line. Fix that to avoid QEMU aborts.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227
Fixes: 356b230ed138 ("aspeed/soc : Add AST1030 support")
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240319150903.413662-2-clg@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/arm/aspeed_ast10x0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c
index 2634e0f654..9f98ad8e87 100644
--- a/hw/arm/aspeed_ast10x0.c
+++ b/hw/arm/aspeed_ast10x0.c
@@ -424,6 +424,8 @@ static void aspeed_soc_ast1030_class_init(ObjectClass *klass, void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
AspeedSoCClass *sc = ASPEED_SOC_CLASS(dc);
+ /* Reason: The Aspeed SoC can only be instantiated from a board */
+ dc->user_creatable = false;
dc->realize = aspeed_soc_ast1030_realize;
sc->name = "ast1030-a1";
--
2.44.0
next prev parent reply other threads:[~2024-03-25 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 14:12 [PULL 0/9] Patches for QEMU 9.0-rc1 Thomas Huth
2024-03-25 14:12 ` [PULL 1/9] .travis.yml: Shorten the runtime of the problematic jobs Thomas Huth
2024-03-25 14:12 ` [PULL 2/9] .travis.yml: Remove the unused xfslib-dev package Thomas Huth
2024-03-25 14:12 ` [PULL 3/9] hw/microblaze: Do not allow xlnx-zynqmp-pmu-soc to be created by the user Thomas Huth
2024-03-25 14:12 ` [PULL 4/9] aspeed: Make the ast2600-a3 SoC not user creatable Thomas Huth
2024-03-25 14:12 ` Thomas Huth [this message]
2024-03-25 14:12 ` [PULL 6/9] misc/pca955*: Move models under hw/gpio Thomas Huth
2024-03-25 14:12 ` [PULL 7/9] libqos/virtio.c: Correct 'flags' reading in qvirtqueue_kick Thomas Huth
2024-03-25 14:12 ` [PULL 8/9] target/s390x: Use mutable temporary value for op_ts Thomas Huth
2024-03-25 14:12 ` [PULL 9/9] tests/tcg/s390x: Test TEST AND SET Thomas Huth
2024-03-25 16:46 ` [PULL 0/9] Patches for QEMU 9.0-rc1 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325141210.788356-6-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=clg@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).