From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yuval Shaia" <yuval.shaia.ml@gmail.com>,
qemu-block@nongnu.org,
"Dr. David Alan Gilbert" <dave@treblig.org>,
integration@gluster.org, "Peter Xu" <peterx@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Li Zhijian" <lizhijian@fujitsu.com>,
devel@lists.libvirt.org, "Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Song Gao" <gaosong@loongson.cn>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Eric Blake" <eblake@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cornelia Huck" <cohuck@redhat.com>
Subject: Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device
Date: Thu, 28 Mar 2024 05:59:40 -0400 [thread overview]
Message-ID: <20240328055821-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <4a43ca17-fc42-402e-8df9-925bc4da8d2c@redhat.com>
On Thu, Mar 28, 2024 at 07:43:06AM +0100, Thomas Huth wrote:
> On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote:
> > The whole RDMA subsystem was deprecated in commit e9a54265f5
> > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> > released in v8.2. Time to remove it.
> >
> > Keep the RAM_SAVE_FLAG_HOOK definition since it might appears
> > in old migration streams.
> >
> > Remove the dependencies on libibumad and libibverbs.
> >
> > Remove the generated vmw_pvrdma/ directory from linux-headers.
> >
> > Remove RDMA handling from migration.
> >
> > Remove RDMA handling in GlusterFS block driver.
> >
> > Remove rdmacm-mux tool from contrib/.
> >
> > Remove PVRDMA device.
> >
> > Cc: Peter Xu <peterx@redhat.com>
> > Cc: Li Zhijian <lizhijian@fujitsu.com>
> > Cc: Yuval Shaia <yuval.shaia.ml@gmail.com>
> > Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > MAINTAINERS | 17 -
> > docs/about/deprecated.rst | 9 -
> > docs/about/removed-features.rst | 4 +
> > docs/devel/migration/main.rst | 6 -
> > docs/pvrdma.txt | 345 --
> > docs/rdma.txt | 420 --
> > docs/system/device-url-syntax.rst.inc | 4 +-
> > docs/system/loongarch/virt.rst | 2 +-
> > docs/system/qemu-block-drivers.rst.inc | 1 -
> > meson.build | 59 -
> > qapi/machine.json | 17 -
> > qapi/migration.json | 31 +-
> > qapi/qapi-schema.json | 1 -
> > qapi/rdma.json | 38 -
> > contrib/rdmacm-mux/rdmacm-mux.h | 61 -
> > hw/rdma/rdma_backend.h | 129 -
> > hw/rdma/rdma_backend_defs.h | 76 -
> > hw/rdma/rdma_rm.h | 97 -
> > hw/rdma/rdma_rm_defs.h | 146 -
> > hw/rdma/rdma_utils.h | 63 -
> > hw/rdma/trace.h | 1 -
> > hw/rdma/vmw/pvrdma.h | 144 -
> > hw/rdma/vmw/pvrdma_dev_ring.h | 46 -
> > hw/rdma/vmw/pvrdma_qp_ops.h | 28 -
> > hw/rdma/vmw/trace.h | 1 -
> > include/hw/rdma/rdma.h | 37 -
> > include/monitor/hmp.h | 1 -
> > .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 685 ---
> > .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 348 --
> > .../standard-headers/rdma/vmw_pvrdma-abi.h | 310 --
> > migration/migration-stats.h | 6 +-
> > migration/migration.h | 9 -
> > migration/options.h | 2 -
> > migration/rdma.h | 69 -
> > block/gluster.c | 39 -
> > contrib/rdmacm-mux/main.c | 831 ----
> > hw/core/machine-qmp-cmds.c | 32 -
> > hw/rdma/rdma.c | 30 -
> > hw/rdma/rdma_backend.c | 1401 ------
> > hw/rdma/rdma_rm.c | 812 ----
> > hw/rdma/rdma_utils.c | 126 -
> > hw/rdma/vmw/pvrdma_cmd.c | 815 ----
> > hw/rdma/vmw/pvrdma_dev_ring.c | 141 -
> > hw/rdma/vmw/pvrdma_main.c | 735 ---
> > hw/rdma/vmw/pvrdma_qp_ops.c | 298 --
> > migration/migration-stats.c | 5 +-
> > migration/migration.c | 31 -
> > migration/options.c | 16 -
> > migration/qemu-file.c | 1 -
> > migration/ram.c | 86 +-
> > migration/rdma.c | 4184 -----------------
> > migration/savevm.c | 2 +-
> > monitor/qmp-cmds.c | 1 -
> > Kconfig.host | 3 -
> > contrib/rdmacm-mux/meson.build | 7 -
> > hmp-commands-info.hx | 13 -
> > hw/Kconfig | 1 -
> > hw/meson.build | 1 -
> > hw/rdma/Kconfig | 3 -
> > hw/rdma/meson.build | 12 -
> > hw/rdma/trace-events | 31 -
> > hw/rdma/vmw/trace-events | 17 -
> > meson_options.txt | 4 -
> > migration/meson.build | 1 -
> > migration/trace-events | 68 +-
> > qapi/meson.build | 1 -
> > qemu-options.hx | 6 -
> > .../ci/org.centos/stream/8/x86_64/configure | 1 -
> > scripts/ci/setup/build-environment.yml | 2 -
> > scripts/coverity-scan/run-coverity-scan | 2 +-
> > scripts/meson-buildoptions.sh | 6 -
> > scripts/update-linux-headers.sh | 27 -
> > tests/lcitool/projects/qemu.yml | 2 -
> > tests/migration/guestperf/engine.py | 4 +-
> > 74 files changed, 20 insertions(+), 12991 deletions(-)
> > delete mode 100644 docs/pvrdma.txt
> > delete mode 100644 docs/rdma.txt
> > delete mode 100644 qapi/rdma.json
> > delete mode 100644 contrib/rdmacm-mux/rdmacm-mux.h
> > delete mode 100644 hw/rdma/rdma_backend.h
> > delete mode 100644 hw/rdma/rdma_backend_defs.h
> > delete mode 100644 hw/rdma/rdma_rm.h
> > delete mode 100644 hw/rdma/rdma_rm_defs.h
> > delete mode 100644 hw/rdma/rdma_utils.h
> > delete mode 100644 hw/rdma/trace.h
> > delete mode 100644 hw/rdma/vmw/pvrdma.h
> > delete mode 100644 hw/rdma/vmw/pvrdma_dev_ring.h
> > delete mode 100644 hw/rdma/vmw/pvrdma_qp_ops.h
> > delete mode 100644 hw/rdma/vmw/trace.h
> > delete mode 100644 include/hw/rdma/rdma.h
> > delete mode 100644 include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h
> > delete mode 100644 include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
> > delete mode 100644 include/standard-headers/rdma/vmw_pvrdma-abi.h
> > delete mode 100644 migration/rdma.h
> > delete mode 100644 contrib/rdmacm-mux/main.c
> > delete mode 100644 hw/rdma/rdma.c
> > delete mode 100644 hw/rdma/rdma_backend.c
> > delete mode 100644 hw/rdma/rdma_rm.c
> > delete mode 100644 hw/rdma/rdma_utils.c
> > delete mode 100644 hw/rdma/vmw/pvrdma_cmd.c
> > delete mode 100644 hw/rdma/vmw/pvrdma_dev_ring.c
> > delete mode 100644 hw/rdma/vmw/pvrdma_main.c
> > delete mode 100644 hw/rdma/vmw/pvrdma_qp_ops.c
> > delete mode 100644 migration/rdma.c
> > delete mode 100644 contrib/rdmacm-mux/meson.build
> > delete mode 100644 hw/rdma/Kconfig
> > delete mode 100644 hw/rdma/meson.build
> > delete mode 100644 hw/rdma/trace-events
> > delete mode 100644 hw/rdma/vmw/trace-events
>
> Hi Philippe!
>
> Looking at this rdma stuff again after I while, I realized that there are
> actually 3 parts in QEMU related to RDMA:
> 1) The "pvrdma" device in hw/rdma/vmw/
> 2) The rdma subsystem in hw/rda/*.[ch]
> 3) The rdma migration code in the migration/ folder.
>
> While the deprecation note in docs/about/deprecated.rst clearly talks about
> the "pvrdma" device and the rdma subsystem, I'm unsure whether that includes
> the rdma migration code or not.
>
> Anyway, could you please split your patch at least in two (maybe even in
> three) parts, so that the removal of the rdma migration code is in a
> separate patch? That way we can discuss that separately (and maybe also
> revert it more easily in the future if necessary).
>
> Thanks,
> Thomas
I agree. E.g. rdma migration would be up to migration maintainers.
--
MST
next prev parent reply other threads:[~2024-03-28 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 10:55 [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device Philippe Mathieu-Daudé
2024-03-27 14:32 ` Fabiano Rosas
2024-03-28 6:43 ` Thomas Huth
2024-03-28 9:59 ` Michael S. Tsirkin [this message]
2024-03-28 7:51 ` Paolo Bonzini
2024-03-28 9:06 ` Daniel P. Berrangé
2024-03-28 12:57 ` Philippe Mathieu-Daudé
2024-03-28 13:01 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328055821-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=cohuck@redhat.com \
--cc=dave@treblig.org \
--cc=devel@lists.libvirt.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=gaosong@loongson.cn \
--cc=hreitz@redhat.com \
--cc=integration@gluster.org \
--cc=kwolf@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=yuval.shaia.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).