From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PULL 2/7] linux-user: Fix shmat() strace
Date: Fri, 29 Mar 2024 12:20:32 -1000 [thread overview]
Message-ID: <20240329222037.1735350-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240329222037.1735350-1-richard.henderson@linaro.org>
From: Ilya Leoshkevich <iii@linux.ibm.com>
The indices of arguments passed to print_shmat() are all off-by-1,
because arg1 is the ipc() command. Fix them.
New output for linux-shmat-maps test:
3501769 shmat(4784214,0x0000000000800000,SHM_RND) = 0
Fixes: 9f7c97324c27 ("linux-user: Add strace for shmat")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20240325192436.561154-3-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/strace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 51a5bdd95f..b4d1098170 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -701,7 +701,7 @@ print_ipc(CPUArchState *cpu_env, const struct syscallname *name,
break;
case IPCOP_shmat:
print_shmat(cpu_env, &(const struct syscallname){ .name = "shmat" },
- arg1, arg4, arg2, 0, 0, 0);
+ arg2, arg5, arg3, 0, 0, 0);
break;
default:
qemu_log(("%s("
--
2.34.1
next prev parent reply other threads:[~2024-03-29 22:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 22:20 [PULL 0/7] tcg + linux-user patch queue Richard Henderson
2024-03-29 22:20 ` [PULL 1/7] linux-user: Fix semctl() strace Richard Henderson
2024-03-29 22:20 ` Richard Henderson [this message]
2024-03-29 22:20 ` [PULL 3/7] linux-user: Fix shmat(NULL) for h != g Richard Henderson
2024-03-29 22:20 ` [PULL 4/7] tests/tcg: Test shmat(NULL) Richard Henderson
2024-03-29 22:20 ` [PULL 5/7] tcg/optimize: Fix sign_mask for logical right-shift Richard Henderson
2024-03-29 22:20 ` [PULL 6/7] disas: Show opcodes for target_disas and monitor_disas Richard Henderson
2024-03-29 22:20 ` [PULL 7/7] accel/tcg: Use CPUState.get_pc in cpu_io_recompile Richard Henderson
2024-03-31 15:42 ` [PULL 0/7] tcg + linux-user patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329222037.1735350-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).