qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>, qemu-ppc@nongnu.org
Subject: [PULL 7/8] tests/avocado: Fix ppc_hv_tests.py xorriso dependency guard
Date: Sun, 31 Mar 2024 17:33:44 +1000	[thread overview]
Message-ID: <20240331073349.88324-8-npiggin@gmail.com> (raw)
In-Reply-To: <20240331073349.88324-1-npiggin@gmail.com>

For some reason the skipIf missing_deps() check fails to skip the test
if it comes after the skipUnless lines, causing an error running on
systems without xorriso.

Avocado implements skipUnless is just an inverted skipIf, so it's not
clear what the bug is or why this fixes it. For now it's enough to
get things working.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2246
Fixes: c9cb496710758 ("tests/avocado: ppc add hypervisor tests")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 tests/avocado/ppc_hv_tests.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/avocado/ppc_hv_tests.py b/tests/avocado/ppc_hv_tests.py
index 5080358e25..2c8ddd9257 100644
--- a/tests/avocado/ppc_hv_tests.py
+++ b/tests/avocado/ppc_hv_tests.py
@@ -42,10 +42,11 @@ def missing_deps():
 # QEMU packages are downloaded and installed on each test. That's not a
 # large download, but it may be more polite to create qcow2 image with
 # QEMU already installed and use that.
+# XXX: The order of these tests seems to matter, see git blame.
+@skipIf(missing_deps(), 'dependencies (%s) not installed' % ','.join(deps))
 @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test sometimes gets stuck due to console handling problem')
 @skipUnless(os.getenv('AVOCADO_ALLOW_LARGE_STORAGE'), 'storage limited')
 @skipUnless(os.getenv('SPEED') == 'slow', 'runtime limited')
-@skipIf(missing_deps(), 'dependencies (%s) not installed' % ','.join(deps))
 class HypervisorTest(QemuSystemTest):
 
     timeout = 1000
-- 
2.43.0



  parent reply	other threads:[~2024-03-31  7:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-31  7:33 [PULL 0/8] ppc-for-9.0-3 queue Nicholas Piggin
2024-03-31  7:33 ` [PULL 1/8] spapr: nested: use bitwise NOT operator for flags check Nicholas Piggin
2024-03-31  7:33 ` [PULL 2/8] hw/ppc/spapr: Include missing 'sysemu/tcg.h' header Nicholas Piggin
2024-03-31  7:33 ` [PULL 3/8] target/ppc/mmu-radix64: Use correct string format in walk_tree() Nicholas Piggin
2024-03-31  7:33 ` [PULL 4/8] target/ppc: Restore [H]DEXCR to 64-bits Nicholas Piggin
2024-03-31  7:33 ` [PULL 5/8] target/ppc: Fix GDB register indexing on secondary CPUs Nicholas Piggin
2024-03-31  7:33 ` [PULL 6/8] target/ppc: Do not clear MSR[ME] on MCE interrupts to supervisor Nicholas Piggin
2024-03-31  7:33 ` Nicholas Piggin [this message]
2024-03-31  7:33 ` [PULL 8/8] tests/avocado: ppc_hv_tests.py set alpine time before setup-alpine Nicholas Piggin
2024-04-01 12:09 ` [PULL 0/8] ppc-for-9.0-3 queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240331073349.88324-8-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).