qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Helge Konetzka <hk@zapateado.de>
Subject: [PATCH for-9.1 6/4] vga: move dirty memory region code together
Date: Tue,  2 Apr 2024 13:34:08 +0200	[thread overview]
Message-ID: <20240402113408.18048-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20240402113408.18048-1-pbonzini@redhat.com>

Take into account split screen mode close to wrap around, which is the
other special case for dirty memory region computation.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/display/vga.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/display/vga.c b/hw/display/vga.c
index 77d709a3d69..e91a76bf76b 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1596,6 +1596,10 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
         region_end = s->vbe_size;
         force_shadow = true;
     }
+    if (s->params.line_compare < height) {
+        /* split screen mode */
+        region_start = 0;
+    }
 
     /*
      * Check whether we can share the surface with the backend
@@ -1667,10 +1671,6 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
     y1 = 0;
 
     if (!full_update) {
-        if (s->params.line_compare < height) {
-            /* split screen mode */
-            region_start = 0;
-        }
         snap = memory_region_snapshot_and_clear_dirty(&s->vram, region_start,
                                                       region_end - region_start,
                                                       DIRTY_MEMORY_VGA);
-- 
2.44.0



      parent reply	other threads:[~2024-04-02 11:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 11:34 [PATCH for-9.0 0/4] vga: fix assertion failure with 4- and 16-color modes Paolo Bonzini
2024-04-02 11:34 ` [PATCH for-9.0 1/4] vga: merge conditionals on shift control register Paolo Bonzini
2024-04-02 11:40   ` Philippe Mathieu-Daudé
2024-04-02 11:34 ` [PATCH for-9.0 2/4] vga: move computation of dirty memory region later Paolo Bonzini
2024-04-02 11:41   ` Philippe Mathieu-Daudé
2024-04-02 11:34 ` [PATCH for-9.0 3/4] vga: adjust dirty memory region if pel panning is active Paolo Bonzini
2024-04-02 11:43   ` Philippe Mathieu-Daudé
2024-04-02 11:34 ` [PATCH for-9.0 4/4] vga: do not treat horiz pel panning value of 8 as "enabled" Paolo Bonzini
2024-04-02 11:34 ` [PATCH for-9.1 5/4] vga: optimize computation of dirty memory region Paolo Bonzini
2024-04-02 11:34 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402113408.18048-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hk@zapateado.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).