qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author
@ 2024-04-02 11:59 Philippe Mathieu-Daudé
  2024-04-02 11:59 ` [PATCH v2 1/2] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org Philippe Mathieu-Daudé
  2024-04-02 11:59 ` [PATCH v2 2/2] scripts/checkpatch: Do not use mailmap Philippe Mathieu-Daudé
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-02 11:59 UTC (permalink / raw)
  To: qemu-devel
  Cc: Laurent Vivier, qemu-trivial, Michael Tokarev, Peter Maydell,
	Stefan Weil, Daniel P . Berrangé,
	Philippe Mathieu-Daudé

Since v1:
- Extend regexp to cover all lists (Peter)

* qemu-trivial@ is not checked
* mailmap hides the mistakes we want to catch

See https://lore.kernel.org/qemu-devel/60faa39d-52e8-46f1-8bd9-9d9661794880@tls.msk.ru/

Philippe Mathieu-Daudé (2):
  scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org
  scripts/checkpatch: Do not use mailmap

 scripts/checkpatch.pl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.41.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/2] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org
  2024-04-02 11:59 [PATCH v2 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author Philippe Mathieu-Daudé
@ 2024-04-02 11:59 ` Philippe Mathieu-Daudé
  2024-04-02 11:59 ` [PATCH v2 2/2] scripts/checkpatch: Do not use mailmap Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-02 11:59 UTC (permalink / raw)
  To: qemu-devel
  Cc: Laurent Vivier, qemu-trivial, Michael Tokarev, Peter Maydell,
	Stefan Weil, Daniel P . Berrangé,
	Philippe Mathieu-Daudé

Commit f5177798d8 ("scripts: report on author emails
that are mangled by the mailing list") added a check
for qemu-devel@ list, extend the regexp to cover more
such qemu-trivial@, qemu-block@ and qemu-ppc@.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7026895074..12e9028b10 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1573,7 +1573,7 @@ sub process {
 			$is_patch = 1;
 		}
 
-		if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
+		if ($line =~ /^(Author|From): .* via .*<qemu-\w+\@nongnu\.org>/) {
 		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
 		}
 
-- 
2.41.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] scripts/checkpatch: Do not use mailmap
  2024-04-02 11:59 [PATCH v2 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author Philippe Mathieu-Daudé
  2024-04-02 11:59 ` [PATCH v2 1/2] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org Philippe Mathieu-Daudé
@ 2024-04-02 11:59 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-02 11:59 UTC (permalink / raw)
  To: qemu-devel
  Cc: Laurent Vivier, qemu-trivial, Michael Tokarev, Peter Maydell,
	Stefan Weil, Daniel P . Berrangé,
	Philippe Mathieu-Daudé

The .mailmap file fixes mistake we already did.
Do not use it when running checkpatch.pl, otherwise
we might commit the very same mistakes.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 12e9028b10..76a0b79266 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -435,8 +435,8 @@ if ($chk_branch) {
 	my @patches;
 	my %git_commits = ();
 	my $HASH;
-	open($HASH, "-|", "git", "log", "--reverse", "--no-merges", "--format=%H %s", $ARGV[0]) ||
-		die "$P: git log --reverse --no-merges --format='%H %s' $ARGV[0] failed - $!\n";
+	open($HASH, "-|", "git", "log", "--reverse", "--no-merges", "--no-mailmap", "--format=%H %s", $ARGV[0]) ||
+		die "$P: git log --reverse --no-merges --no-mailmap --format='%H %s' $ARGV[0] failed - $!\n";
 
 	for my $line (<$HASH>) {
 		$line =~ /^([0-9a-fA-F]{40,40}) (.*)$/;
@@ -460,7 +460,7 @@ if ($chk_branch) {
                      "-c", "diff.renamelimit=0",
                      "-c", "diff.renames=True",
                      "-c", "diff.algorithm=histogram",
-                     "show",
+                     "show", "--no-mailmap",
                      "--patch-with-stat", $hash) ||
 			die "$P: git show $hash - $!\n";
 		while (<$FILE>) {
-- 
2.41.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-02 12:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-02 11:59 [PATCH v2 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author Philippe Mathieu-Daudé
2024-04-02 11:59 ` [PATCH v2 1/2] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org Philippe Mathieu-Daudé
2024-04-02 11:59 ` [PATCH v2 2/2] scripts/checkpatch: Do not use mailmap Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).