qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Chuhong Yuan <hslester96@gmail.com>
Subject: [PULL 6/7] lsi53c895a: detect invalid Block Move instruction
Date: Tue,  2 Apr 2024 15:16:48 +0200	[thread overview]
Message-ID: <20240402131649.23225-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20240402131649.23225-1-pbonzini@redhat.com>

The spec for the lsi53c895a says: "If the instruction is a Block Move
and a value of 0x000000 is loaded into the DBC register, an illegal
instruction interrupt occurs if the LSI53C895A is not in target mode,
Command phase".

Because QEMU only operates in initiator mode, generate the interrupt
unconditionally if the low 24 bits are 0x000000.

Reported-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi/lsi53c895a.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index eb9828dd5ef..1e18d88983b 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1205,6 +1205,15 @@ again:
             break;
         }
         s->dbc = insn & 0xffffff;
+        if (!s->dbc) {
+            /*
+             * If the instruction is a Block Move and a value of 0x000000 is
+             * loaded into the DBC register, an illegal instruction interrupt
+             * occurs if the LSI53C895A is not in target mode, Command phase.
+             */
+            lsi_script_dma_interrupt(s, LSI_DSTAT_IID);
+            break;
+        }
         s->rbc = s->dbc;
         /* ??? Set ESA.  */
         s->ia = s->dsp - 8;
-- 
2.44.0



  parent reply	other threads:[~2024-04-02 13:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 13:16 [PULL 0/7] lsi, vga fixes for 2024-04-02 Paolo Bonzini
2024-04-02 13:16 ` [PULL 1/7] vga: merge conditionals on shift control register Paolo Bonzini
2024-04-02 13:16 ` [PULL 2/7] vga: move computation of dirty memory region later Paolo Bonzini
2024-04-02 13:16 ` [PULL 3/7] vga: adjust dirty memory region if pel panning is active Paolo Bonzini
2024-04-02 13:16 ` [PULL 4/7] vga: do not treat horiz pel panning value of 8 as "enabled" Paolo Bonzini
2024-04-02 13:16 ` [PULL 5/7] lsi53c895a: avoid out of bounds access to s->msg[] Paolo Bonzini
2024-04-02 13:16 ` Paolo Bonzini [this message]
2024-04-02 13:16 ` [PULL 7/7] pc_q35: remove unnecessary m->alias assignment Paolo Bonzini
2024-04-02 15:22 ` [PULL 0/7] lsi, vga fixes for 2024-04-02 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402131649.23225-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hslester96@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).