qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Klaus Jensen" <k.jensen@samsung.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Keith Busch" <kbusch@kernel.org>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Jesper Devantier" <foss@defmacro.it>
Subject: [PULL 12/15] hw/nvme: fix -Werror=maybe-uninitialized
Date: Tue,  2 Apr 2024 16:24:27 +0200	[thread overview]
Message-ID: <20240402142431.70700-13-philmd@linaro.org> (raw)
In-Reply-To: <20240402142431.70700-1-philmd@linaro.org>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]

It's not obvious that 'result' is set in all code paths. When &result is
a returned argument, it's even less clear.

Looking at various assignments, 0 seems to be a suitable default value.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Message-ID: <20240328102052.3499331-18-marcandre.lureau@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/nvme/ctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index c2b17de987..127c3d2383 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -5894,7 +5894,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeRequest *req)
     uint32_t dw10 = le32_to_cpu(cmd->cdw10);
     uint32_t dw11 = le32_to_cpu(cmd->cdw11);
     uint32_t nsid = le32_to_cpu(cmd->nsid);
-    uint32_t result;
+    uint32_t result = 0;
     uint8_t fid = NVME_GETSETFEAT_FID(dw10);
     NvmeGetFeatureSelect sel = NVME_GETFEAT_SELECT(dw10);
     uint16_t iv;
-- 
2.41.0



  parent reply	other threads:[~2024-04-02 14:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 14:24 [PULL 00/15] Misc HW patches for 2024-04-02 Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 01/15] accel/tcg/plugin: Remove CONFIG_SOFTMMU_GATE definition Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 02/15] gdbstub: Correct invalid mentions of 'softmmu' by 'system' Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 03/15] gdbstub/system: Rename 'user_ctx' argument as 'ctx' Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 04/15] target/ppc: Rename init_excp_4xx_softmmu() -> init_excp_4xx() Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 05/15] hw/arm/smmu: Avoid using inlined functions with external linkage again Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 06/15] accel/hvf: Un-inline hvf_arch_supports_guest_debug() Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 07/15] qtest/libqos: Reduce size_to_prdtl() declaration scope Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 08/15] MAINTAINERS: Fix error-report.c entry Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 09/15] hw/i386/pc: Restrict CXL to PCI-based machines Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 10/15] block: Remove unnecessary NULL check in bdrv_pad_request() Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 11/15] plugins: fix -Werror=maybe-uninitialized false-positive Philippe Mathieu-Daudé
2024-04-02 14:24 ` Philippe Mathieu-Daudé [this message]
2024-04-02 14:24 ` [PULL 13/15] gpio/pca955x: Update maintainer email address Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 14/15] hw/xen_evtchn: Initialize flush_kvm_routes Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 15/15] hw/net/virtio-net: fix qemu set used ring flag even vhost started Philippe Mathieu-Daudé
2024-04-02 16:51 ` [PULL 00/15] Misc HW patches for 2024-04-02 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402142431.70700-13-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=foss@defmacro.it \
    --cc=its@irrelevant.dk \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).