From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 02/15] gdbstub: Correct invalid mentions of 'softmmu' by 'system'
Date: Tue, 2 Apr 2024 16:24:17 +0200 [thread overview]
Message-ID: <20240402142431.70700-3-philmd@linaro.org> (raw)
In-Reply-To: <20240402142431.70700-1-philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240313213339.82071-3-philmd@linaro.org>
---
gdbstub/internals.h | 20 ++++++++++----------
gdbstub/system.c | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/gdbstub/internals.h b/gdbstub/internals.h
index e83b179920..66c939c67f 100644
--- a/gdbstub/internals.h
+++ b/gdbstub/internals.h
@@ -115,7 +115,7 @@ void gdb_read_byte(uint8_t ch);
/*
* Packet acknowledgement - we handle this slightly differently
- * between user and softmmu mode, mainly to deal with the differences
+ * between user and system mode, mainly to deal with the differences
* between the flexible chardev and the direct fd approaches.
*
* We currently don't support a negotiated QStartNoAckMode
@@ -125,7 +125,7 @@ void gdb_read_byte(uint8_t ch);
* gdb_got_immediate_ack() - check ok to continue
*
* Returns true to continue, false to re-transmit for user only, the
- * softmmu stub always returns true.
+ * system stub always returns true.
*/
bool gdb_got_immediate_ack(void);
/* utility helpers */
@@ -135,12 +135,12 @@ CPUState *gdb_first_attached_cpu(void);
void gdb_append_thread_id(CPUState *cpu, GString *buf);
int gdb_get_cpu_index(CPUState *cpu);
unsigned int gdb_get_max_cpus(void); /* both */
-bool gdb_can_reverse(void); /* softmmu, stub for user */
+bool gdb_can_reverse(void); /* system emulation, stub for user */
int gdb_target_sigtrap(void); /* user */
void gdb_create_default_process(GDBState *s);
-/* signal mapping, common for softmmu, specialised for user-mode */
+/* signal mapping, common for system, specialised for user-mode */
int gdb_signal_to_target(int sig);
int gdb_target_signal_to_gdb(int sig);
@@ -157,12 +157,12 @@ void gdb_continue(void);
int gdb_continue_partial(char *newstates);
/*
- * Helpers with separate softmmu and user implementations
+ * Helpers with separate system and user implementations
*/
void gdb_put_buffer(const uint8_t *buf, int len);
/*
- * Command handlers - either specialised or softmmu or user only
+ * Command handlers - either specialised or system or user only
*/
void gdb_init_gdbserver_state(void);
@@ -187,7 +187,7 @@ typedef union GdbCmdVariant {
#define get_param(p, i) (&g_array_index(p, GdbCmdVariant, i))
-void gdb_handle_query_rcmd(GArray *params, void *user_ctx); /* softmmu */
+void gdb_handle_query_rcmd(GArray *params, void *user_ctx); /* system */
void gdb_handle_query_offsets(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_xfer_auxv(GArray *params, void *user_ctx); /*user */
void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx); /*user */
@@ -203,7 +203,7 @@ bool gdb_handle_detach_user(uint32_t pid); /* user */
void gdb_handle_query_attached(GArray *params, void *user_ctx); /* both */
-/* softmmu only */
+/* system only */
void gdb_handle_query_qemu_phy_mem_mode(GArray *params, void *user_ctx);
void gdb_handle_set_qemu_phy_mem_mode(GArray *params, void *user_ctx);
@@ -213,11 +213,11 @@ bool gdb_handled_syscall(void);
void gdb_disable_syscalls(void);
void gdb_syscall_reset(void);
-/* user/softmmu specific syscall handling */
+/* user/system specific syscall handling */
void gdb_syscall_handling(const char *syscall_packet);
/*
- * Break/Watch point support - there is an implementation for softmmu
+ * Break/Watch point support - there is an implementation for system
* and user mode.
*/
bool gdb_supports_guest_debug(void);
diff --git a/gdbstub/system.c b/gdbstub/system.c
index 83fd452800..a3ce384cd1 100644
--- a/gdbstub/system.c
+++ b/gdbstub/system.c
@@ -1,5 +1,5 @@
/*
- * gdb server stub - softmmu specific bits
+ * gdb server stub - system specific bits
*
* Debug integration depends on support from the individual
* accelerators so most of this involves calling the ops helpers.
--
2.41.0
next prev parent reply other threads:[~2024-04-02 14:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 14:24 [PULL 00/15] Misc HW patches for 2024-04-02 Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 01/15] accel/tcg/plugin: Remove CONFIG_SOFTMMU_GATE definition Philippe Mathieu-Daudé
2024-04-02 14:24 ` Philippe Mathieu-Daudé [this message]
2024-04-02 14:24 ` [PULL 03/15] gdbstub/system: Rename 'user_ctx' argument as 'ctx' Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 04/15] target/ppc: Rename init_excp_4xx_softmmu() -> init_excp_4xx() Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 05/15] hw/arm/smmu: Avoid using inlined functions with external linkage again Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 06/15] accel/hvf: Un-inline hvf_arch_supports_guest_debug() Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 07/15] qtest/libqos: Reduce size_to_prdtl() declaration scope Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 08/15] MAINTAINERS: Fix error-report.c entry Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 09/15] hw/i386/pc: Restrict CXL to PCI-based machines Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 10/15] block: Remove unnecessary NULL check in bdrv_pad_request() Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 11/15] plugins: fix -Werror=maybe-uninitialized false-positive Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 12/15] hw/nvme: fix -Werror=maybe-uninitialized Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 13/15] gpio/pca955x: Update maintainer email address Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 14/15] hw/xen_evtchn: Initialize flush_kvm_routes Philippe Mathieu-Daudé
2024-04-02 14:24 ` [PULL 15/15] hw/net/virtio-net: fix qemu set used ring flag even vhost started Philippe Mathieu-Daudé
2024-04-02 16:51 ` [PULL 00/15] Misc HW patches for 2024-04-02 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402142431.70700-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).