From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Chuhong Yuan" <hslester96@gmail.com>,
"Jason Wang" <jasowang@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH-for-9.0 v2 00/11] hw/net/lan9118: Fix overflow in TX FIFO
Date: Tue, 9 Apr 2024 15:37:49 +0200 [thread overview]
Message-ID: <20240409133801.23503-1-philmd@linaro.org> (raw)
Fix for https://gitlab.com/qemu-project/qemu/-/issues/2267
Since v1:
- Renamed definition as MIL_TXFIFO_SIZE
- Addressed Peter review comments in patches 1 & 2
(add comment, return TXE INT)
- Trivial patches while digesting Peter's analysis [*]
More work expected during 9.1.
[*] https://lore.kernel.org/qemu-devel/CAFEAcA8vvURMn2FaDP9tXtP5eCMs6-XFOCR9ypo=WBH+6g5prw@mail.gmail.com/
Philippe Mathieu-Daudé (11):
hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE
definition
hw/net/lan9118: Fix overflow in MIL TX FIFO
hw/net/lan9118: Remove duplicated assignment
hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definition
hw/net/lan9118: Add definitions for FIFO allocated sizes
hw/net/lan9118: Use TX_DATA_FIFO_BYTES definition
hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_bytes
hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definition
hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcount
hw/net/lan9118: Use RX_DATA_FIFO_BYTES definition
hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcount
hw/net/lan9118.c | 104 +++++++++++++++++++++++++++++++----------------
1 file changed, 70 insertions(+), 34 deletions(-)
--
2.41.0
next reply other threads:[~2024-04-09 13:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 13:37 Philippe Mathieu-Daudé [this message]
2024-04-09 13:37 ` [PATCH-for-9.0 v2 01/11] hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE definition Philippe Mathieu-Daudé
2024-04-09 13:40 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.0 v2 02/11] hw/net/lan9118: Fix overflow in MIL TX FIFO Philippe Mathieu-Daudé
2024-04-09 13:41 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 03/11] hw/net/lan9118: Remove duplicated assignment Philippe Mathieu-Daudé
2024-04-09 13:44 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 04/11] hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definition Philippe Mathieu-Daudé
2024-04-09 13:45 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 05/11] hw/net/lan9118: Add definitions for FIFO allocated sizes Philippe Mathieu-Daudé
2024-04-09 13:52 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 06/11] hw/net/lan9118: Use TX_DATA_FIFO_BYTES definition Philippe Mathieu-Daudé
2024-04-09 13:37 ` [PATCH-for-9.1 v2 07/11] hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_bytes Philippe Mathieu-Daudé
2024-04-09 13:55 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 08/11] hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definition Philippe Mathieu-Daudé
2024-04-09 13:59 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 09/11] hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcount Philippe Mathieu-Daudé
2024-04-09 14:03 ` Peter Maydell
2024-04-09 13:37 ` [PATCH-for-9.1 v2 10/11] hw/net/lan9118: Use RX_DATA_FIFO_BYTES definition Philippe Mathieu-Daudé
2024-04-09 14:05 ` Peter Maydell
2024-04-09 13:38 ` [PATCH-for-9.1 v2 11/11] hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcount Philippe Mathieu-Daudé
2024-04-09 14:34 ` [PATCH-for-9.0 v2 00/11] hw/net/lan9118: Fix overflow in TX FIFO Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409133801.23503-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alxndr@bu.edu \
--cc=hslester96@gmail.com \
--cc=jasowang@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).