From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E256CD1284 for ; Tue, 9 Apr 2024 13:39:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruBfs-0005mH-Op; Tue, 09 Apr 2024 09:38:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruBfr-0005lw-Bg for qemu-devel@nongnu.org; Tue, 09 Apr 2024 09:38:07 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruBfp-0008AA-N6 for qemu-devel@nongnu.org; Tue, 09 Apr 2024 09:38:07 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-343bccc0b2cso4086314f8f.1 for ; Tue, 09 Apr 2024 06:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712669884; x=1713274684; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vC3gmGFS//wOnrZqSqcK6FVhjByf7WW2EZPOHgM5S+0=; b=Ns31C5AE2r0CgJit01MP77FDt3WX9hYin4EO+OrHAVNoUORdE2elo+Ywt7p4XWljQO ImMz9LpekzwcOkydDu0dDFLcxTHTaFZOUbZIwrmq0voZ5lJsjGtTsiinKP1okDPdNS7M icUYO//FeAhphweoCha9RXEc8LHsAHgzThLwjLV9f6NSothG4IyVfPKUeny7wY41EMhf PCcZqlMY63YNJY66qJN5u/JlTihHHFzXAZGP87dUIOqCspwCAR9vTa0FJxI6YGXSe2Eg vwbkYVUSidqx4GJDZd9RMmKwcFCEGNpgEQueaWDyi00uZ2/l/L41Bo8XJ9HKzClnGsRA rf2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712669884; x=1713274684; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vC3gmGFS//wOnrZqSqcK6FVhjByf7WW2EZPOHgM5S+0=; b=uZrtPecDoCns2Bopq6rQ1Na2y0oYiiMlpSpucFqKD+R911cLFzm1RRKzLrR5YaaMaz VY+4wrhzBK6Uoc8f28W5m2rEVB9lbP6RawvnDPBygeJTs5Shlbhy/wKYL+XdEfFrFJIi AVz2gFVH4qtwlkQH8a0J8tzjNzmIYNCv4HTumGNwAEtvQ2rHj0/DUTQrj99QNiqzTKBy XMRJao6pDwoxvF9TuiCOB0gu3CoLaNueCJsPwkL+GpVPxMEXjh9QGMemNhdTGHc4DI5u 0592Ufvm6IF1cZzdfAYsghCPo2SBqio5jfSG5KQsT7VzU8zYCF66pwJa0nVuH0bY+DIL jBBg== X-Gm-Message-State: AOJu0YyE6NPzV+CrKM+FZmbWNTRoRQZYcS9LG+5+eky9iDqm1O/7Zdo5 bwMP7XVszAxyPsIrrDgZNstEI6ub6lJIQSYi8gkqeHqM6gALsSMVFuUsx7E+l3naTmayzQpodoa Q X-Google-Smtp-Source: AGHT+IE72wr3+MUSG77SnSnzdZqYKRAn91G6tdj9I6nGCD+sJyPb0hJa/no64ZpHYERNjEV1l5Bp/g== X-Received: by 2002:a05:6000:544:b0:346:311c:32f1 with SMTP id b4-20020a056000054400b00346311c32f1mr1308231wrf.50.1712669883810; Tue, 09 Apr 2024 06:38:03 -0700 (PDT) Received: from m1x-phil.lan ([176.176.160.134]) by smtp.gmail.com with ESMTPSA id p9-20020adff209000000b003432d61d6b7sm11468603wro.51.2024.04.09.06.38.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Apr 2024 06:38:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chuhong Yuan , Jason Wang , Alexander Bulekov , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 v2 00/11] hw/net/lan9118: Fix overflow in TX FIFO Date: Tue, 9 Apr 2024 15:37:49 +0200 Message-ID: <20240409133801.23503-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Fix for https://gitlab.com/qemu-project/qemu/-/issues/2267 Since v1: - Renamed definition as MIL_TXFIFO_SIZE - Addressed Peter review comments in patches 1 & 2 (add comment, return TXE INT) - Trivial patches while digesting Peter's analysis [*] More work expected during 9.1. [*] https://lore.kernel.org/qemu-devel/CAFEAcA8vvURMn2FaDP9tXtP5eCMs6-XFOCR9ypo=WBH+6g5prw@mail.gmail.com/ Philippe Mathieu-Daudé (11): hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE definition hw/net/lan9118: Fix overflow in MIL TX FIFO hw/net/lan9118: Remove duplicated assignment hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definition hw/net/lan9118: Add definitions for FIFO allocated sizes hw/net/lan9118: Use TX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_bytes hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definition hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcount hw/net/lan9118: Use RX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcount hw/net/lan9118.c | 104 +++++++++++++++++++++++++++++++---------------- 1 file changed, 70 insertions(+), 34 deletions(-) -- 2.41.0