From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-ppc@nongnu.org,
Philippe =?unknown-8bit?q?Mathieu-Daud=C3=A9?=
<philmd@linaro.org>
Subject: [PATCH v2 00/13] misc: Remove sprintf() due to macOS deprecation
Date: Thu, 11 Apr 2024 12:15:36 +0200 [thread overview]
Message-ID: <20240411101550.99392-1-philmd@linaro.org> (raw)
Since v1:
- Use snprintf() in patches 1-5
Hi,
sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience.
Suggestion to avoid the super-noisy warning on macOS forum are [*]:
* use -Wno-deprecated-declarations on the whole build
* surgically add #pragma clang diagnostic around each use.
None of these options seem reasonable, so we are somehow forced to
spend time converting each sprintf() call, even if they are safe
enough.
I'm so tired of seeing them than I started the conversion. This is
the first part. Help for the rest is welcomed.
Regards,
Phil.
[*] https://forums.developer.apple.com/forums/thread/714675
Philippe Mathieu-Daudé (13):
ui/console-vc: Replace sprintf() by snprintf()
hw/vfio/pci: Replace sprintf() by snprintf()
hw/ppc/spapr: Replace sprintf() by snprintf()
hw/mips/malta: Add re-usable rng_seed_hex_new() method
hw/mips/malta: Replace sprintf() by snprintf()
system/qtest: Replace sprintf() by g_string_append_printf()
util/hexdump: Rename @offset argument in qemu_hexdump_line()
util/hexdump: Have qemu_hexdump_line() return heap allocated buffer
util/hexdump: Replace sprintf() by g_string_append_printf()
hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf()
hw/ide/atapi: Use qemu_hexdump_line() to avoid sprintf()
hw/dma/pl330: Use qemu_hexdump_line() to avoid sprintf()
backends/tpm: Use qemu_hexdump_line() to avoid sprintf()
include/qemu/cutils.h | 17 ++++++++++++++---
backends/tpm/tpm_util.c | 24 ++++++++----------------
hw/dma/pl330.c | 12 +++---------
hw/ide/atapi.c | 8 ++------
hw/mips/malta.c | 23 ++++++++++++++---------
hw/ppc/spapr.c | 2 +-
hw/scsi/scsi-disk.c | 8 ++------
hw/vfio/pci.c | 2 +-
hw/virtio/vhost-vdpa.c | 11 ++++++-----
system/qtest.c | 8 +++-----
ui/console-vc.c | 2 +-
util/hexdump.c | 33 ++++++++++++++++++---------------
12 files changed, 73 insertions(+), 77 deletions(-)
--
2.41.0
next reply other threads:[~2024-04-11 10:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 10:15 Philippe Mathieu-Daudé [this message]
2024-04-11 10:15 ` [PATCH v2 01/13] ui/console-vc: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-04-11 10:21 ` Marc-André Lureau
2024-04-11 19:27 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 02/13] hw/vfio/pci: " Philippe Mathieu-Daudé
2024-04-11 19:42 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 03/13] hw/ppc/spapr: " Philippe Mathieu-Daudé
2024-04-11 19:47 ` Richard Henderson
2024-04-15 6:44 ` Harsh Prateek Bora
2024-04-11 10:15 ` [PATCH v2 04/13] hw/mips/malta: Add re-usable rng_seed_hex_new() method Philippe Mathieu-Daudé
2024-04-11 20:07 ` Richard Henderson
2024-04-11 20:31 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 05/13] hw/mips/malta: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 06/13] system/qtest: Replace sprintf() by g_string_append_printf() Philippe Mathieu-Daudé
2024-04-11 20:13 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 07/13] util/hexdump: Rename @offset argument in qemu_hexdump_line() Philippe Mathieu-Daudé
2024-04-11 20:34 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 08/13] util/hexdump: Have qemu_hexdump_line() return heap allocated buffer Philippe Mathieu-Daudé
2024-04-11 20:47 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 09/13] util/hexdump: Replace sprintf() by g_string_append_printf() Philippe Mathieu-Daudé
2024-04-11 20:43 ` Philippe Mathieu-Daudé
2024-04-11 20:50 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 10/13] hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf() Philippe Mathieu-Daudé
2024-04-11 20:53 ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 11/13] hw/ide/atapi: " Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 12/13] hw/dma/pl330: " Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 13/13] backends/tpm: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411101550.99392-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).