From: Zhao Liu <zhao1.liu@linux.intel.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>,
Fan Ni <fan.ni@samsung.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH 0/3] hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean
Date: Thu, 18 Apr 2024 18:04:30 +0800 [thread overview]
Message-ID: <20240418100433.1085447-1-zhao1.liu@linux.intel.com> (raw)
From: Zhao Liu <zhao1.liu@intel.com>
Hi list,
This series is the followup of the previous fix [1] to improve the error
handling.
As error.h suggested, the best practice for callee is to return
something to indicate success / failure instead of dereferencing @errp.
Thus make cxl_doe_cdat_init() as well as ct3_load_cdat() and
ct3_build_cdat() return boolean.
[1]: https://lore.kernel.org/qemu-devel/20240221094317.994454-1-zhao1.liu@linux.intel.com/
Thanks,
Zhao
---
Zhao Liu (3):
hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean
hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean
hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean
hw/cxl/cxl-cdat.c | 28 +++++++++++++++-------------
hw/mem/cxl_type3.c | 3 +--
hw/pci-bridge/cxl_upstream.c | 3 +--
include/hw/cxl/cxl_component.h | 2 +-
4 files changed, 18 insertions(+), 18 deletions(-)
--
2.34.1
next reply other threads:[~2024-04-18 9:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 10:04 Zhao Liu [this message]
2024-04-18 10:04 ` [PATCH 1/3] hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean Zhao Liu
2024-04-18 10:04 ` [PATCH 2/3] hw/cxl/cxl-cdat: Make ct3_build_cdat() " Zhao Liu
2024-04-18 10:04 ` [PATCH 3/3] hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() " Zhao Liu
2024-04-18 12:06 ` Philippe Mathieu-Daudé
2024-04-18 13:38 ` Zhao Liu
2024-04-18 12:06 ` [PATCH 0/3] " Philippe Mathieu-Daudé
2024-04-18 12:57 ` Jonathan Cameron via
2024-04-19 15:40 ` Philippe Mathieu-Daudé
2024-04-22 8:33 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418100433.1085447-1-zhao1.liu@linux.intel.com \
--to=zhao1.liu@linux.intel.com \
--cc=armbru@redhat.com \
--cc=fan.ni@samsung.com \
--cc=jonathan.cameron@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).