* [PATCH] hw/arm/npcm7xx: Store derivative OTP fuse key in little endian
@ 2024-04-22 12:58 Philippe Mathieu-Daudé
2024-04-30 14:47 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-22 12:58 UTC (permalink / raw)
To: qemu-devel
Cc: Tyrone Ting, Havard Skinnemoen, Peter Maydell, Hao Wu, qemu-arm,
Philippe Mathieu-Daudé, qemu-stable, Avi Fishman
Use little endian for derivative OTP fuse key.
Cc: qemu-stable@nongnu.org
Fixes: c752bb079b ("hw/nvram: NPCM7xx OTP device model")
Suggested-by: Avi Fishman <Avi.Fishman@nuvoton.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/npcm7xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c
index cc68b5d8f1..9f2d96c733 100644
--- a/hw/arm/npcm7xx.c
+++ b/hw/arm/npcm7xx.c
@@ -24,6 +24,7 @@
#include "hw/qdev-clock.h"
#include "hw/qdev-properties.h"
#include "qapi/error.h"
+#include "qemu/bswap.h"
#include "qemu/units.h"
#include "sysemu/sysemu.h"
#include "target/arm/cpu-qom.h"
@@ -386,7 +387,7 @@ static void npcm7xx_init_fuses(NPCM7xxState *s)
* The initial mask of disabled modules indicates the chip derivative (e.g.
* NPCM750 or NPCM730).
*/
- value = tswap32(nc->disabled_modules);
+ value = cpu_to_le32(nc->disabled_modules);
npcm7xx_otp_array_write(&s->fuse_array, &value, NPCM7XX_FUSE_DERIVATIVE,
sizeof(value));
}
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/arm/npcm7xx: Store derivative OTP fuse key in little endian
2024-04-22 12:58 [PATCH] hw/arm/npcm7xx: Store derivative OTP fuse key in little endian Philippe Mathieu-Daudé
@ 2024-04-30 14:47 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2024-04-30 14:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Tyrone Ting, Havard Skinnemoen, Hao Wu, qemu-arm,
qemu-stable, Avi Fishman
On Mon, 22 Apr 2024 at 13:58, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Use little endian for derivative OTP fuse key.
>
> Cc: qemu-stable@nongnu.org
> Fixes: c752bb079b ("hw/nvram: NPCM7xx OTP device model")
> Suggested-by: Avi Fishman <Avi.Fishman@nuvoton.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-30 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 12:58 [PATCH] hw/arm/npcm7xx: Store derivative OTP fuse key in little endian Philippe Mathieu-Daudé
2024-04-30 14:47 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).