qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Zhao Liu" <zhao1.liu@intel.com>
Subject: [PULL 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter
Date: Wed, 24 Apr 2024 10:03:35 +0200	[thread overview]
Message-ID: <20240424080337.2782594-9-armbru@redhat.com> (raw)
In-Reply-To: <20240424080337.2782594-1-armbru@redhat.com>

From: Philippe Mathieu-Daudé <philmd@linaro.org>

QERR_INVALID_PARAMETER_VALUE is defined as:

  #define QERR_INVALID_PARAMETER_VALUE \
      "Parameter '%s' expects %s"

The current error is formatted as:

  "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 MB/s"

Replace by:

  "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s"

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240312141343.3168265-9-armbru@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
[New error message corrected, commit message updated accordingly]
---
 migration/options.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/migration/options.c b/migration/options.c
index bfd7753b69..d7a773aea8 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1286,9 +1286,8 @@ bool migrate_params_check(MigrationParameters *params, Error **errp)
 
     if (params->has_vcpu_dirty_limit &&
         (params->vcpu_dirty_limit < 1)) {
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
-                   "vcpu_dirty_limit",
-                   "is invalid, it must greater then 1 MB/s");
+        error_setg(errp,
+                   "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s");
         return false;
     }
 
-- 
2.44.0



  parent reply	other threads:[~2024-04-24  8:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24  8:03 [PULL 00/10] Error reporting patches for 2024-04-24 Markus Armbruster
2024-04-24  8:03 ` [PULL 01/10] error: Drop superfluous #include "qapi/qmp/qerror.h" Markus Armbruster
2024-04-24  8:03 ` [PULL 02/10] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition Markus Armbruster
2024-04-24  8:03 ` [PULL 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition Markus Armbruster
2024-04-24  8:03 ` [PULL 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition Markus Armbruster
2024-04-24  8:03 ` [PULL 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER definition Markus Armbruster
2024-04-24  8:03 ` [PULL 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value) Markus Armbruster
2024-04-24  8:03 ` [PULL 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition Markus Armbruster
2024-04-24  8:03 ` Markus Armbruster [this message]
2024-04-24  8:03 ` [PULL 09/10] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition Markus Armbruster
2024-04-24  8:03 ` [PULL 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition Markus Armbruster
2024-04-24 18:47 ` [PULL 00/10] Error reporting patches for 2024-04-24 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424080337.2782594-9-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).