qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v6 09/10] util/bufferiszero: Add simd acceleration for aarch64
Date: Wed, 24 Apr 2024 15:57:04 -0700	[thread overview]
Message-ID: <20240424225705.929812-10-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240424225705.929812-1-richard.henderson@linaro.org>

Because non-embedded aarch64 is expected to have AdvSIMD enabled, merely
double-check with the compiler flags for __ARM_NEON and don't bother with
a runtime check.  Otherwise, model the loop after the x86 SSE2 function.

Use UMAXV for the vector reduction.  This is 3 cycles on cortex-a76 and
2 cycles on neoverse-n1.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 util/bufferiszero.c | 77 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

diff --git a/util/bufferiszero.c b/util/bufferiszero.c
index ff003dc40e..38477a3eac 100644
--- a/util/bufferiszero.c
+++ b/util/bufferiszero.c
@@ -213,7 +213,84 @@ bool test_buffer_is_zero_next_accel(void)
     }
     return false;
 }
+
+#elif defined(__aarch64__) && defined(__ARM_NEON)
+#include <arm_neon.h>
+
+#define REASSOC_BARRIER(vec0, vec1) asm("" : "+w"(vec0), "+w"(vec1))
+
+static bool buffer_is_zero_simd(const void *buf, size_t len)
+{
+    uint32x4_t t0, t1, t2, t3;
+
+    /* Align head/tail to 16-byte boundaries.  */
+    const uint32x4_t *p = QEMU_ALIGN_PTR_DOWN(buf + 16, 16);
+    const uint32x4_t *e = QEMU_ALIGN_PTR_DOWN(buf + len - 1, 16);
+
+    /* Unaligned loads at head/tail.  */
+    t0 = vld1q_u32(buf) | vld1q_u32(buf + len - 16);
+
+    /* Collect a partial block at tail end.  */
+    t1 = e[-7] | e[-6];
+    t2 = e[-5] | e[-4];
+    t3 = e[-3] | e[-2];
+    t0 |= e[-1];
+    REASSOC_BARRIER(t0, t1);
+    REASSOC_BARRIER(t2, t3);
+    t0 |= t1;
+    t2 |= t3;
+    REASSOC_BARRIER(t0, t2);
+    t0 |= t2;
+
+    /*
+     * Loop over complete 128-byte blocks.
+     * With the head and tail removed, e - p >= 14, so the loop
+     * must iterate at least once.
+     */
+    do {
+        /*
+         * Reduce via UMAXV.  Whatever the actual result,
+         * it will only be zero if all input bytes are zero.
+         */
+        if (unlikely(vmaxvq_u32(t0) != 0)) {
+            return false;
+        }
+
+        t0 = p[0] | p[1];
+        t1 = p[2] | p[3];
+        t2 = p[4] | p[5];
+        t3 = p[6] | p[7];
+        REASSOC_BARRIER(t0, t1);
+        REASSOC_BARRIER(t2, t3);
+        t0 |= t1;
+        t2 |= t3;
+        REASSOC_BARRIER(t0, t2);
+        t0 |= t2;
+        p += 8;
+    } while (p < e - 7);
+
+    return vmaxvq_u32(t0) == 0;
+}
+
+static biz_accel_fn const accel_table[] = {
+    buffer_is_zero_int_ge256,
+    buffer_is_zero_simd,
+};
+
+static unsigned accel_index = 1;
+#define INIT_ACCEL buffer_is_zero_simd
+
+bool test_buffer_is_zero_next_accel(void)
+{
+    if (accel_index != 0) {
+        buffer_is_zero_accel = accel_table[--accel_index];
+        return true;
+    }
+    return false;
+}
+
 #else
+
 bool test_buffer_is_zero_next_accel(void)
 {
     return false;
-- 
2.34.1



  parent reply	other threads:[~2024-04-24 22:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 22:56 [PATCH v6 00/10] Optimize buffer_is_zero Richard Henderson
2024-04-24 22:56 ` [PATCH v6 01/10] util/bufferiszero: Remove SSE4.1 variant Richard Henderson
2024-04-24 22:56 ` [PATCH v6 02/10] util/bufferiszero: Remove AVX512 variant Richard Henderson
2024-04-29 11:16   ` Daniel P. Berrangé
2024-04-29 11:29     ` Alexander Monakov
2024-04-24 22:56 ` [PATCH v6 03/10] util/bufferiszero: Reorganize for early test for acceleration Richard Henderson
2024-04-24 22:56 ` [PATCH v6 04/10] util/bufferiszero: Remove useless prefetches Richard Henderson
2024-04-24 22:57 ` [PATCH v6 05/10] util/bufferiszero: Optimize SSE2 and AVX2 variants Richard Henderson
2024-04-24 22:57 ` [PATCH v6 06/10] util/bufferiszero: Improve scalar variant Richard Henderson
2024-04-29 12:18   ` Philippe Mathieu-Daudé
2024-04-29 12:31     ` Richard Henderson
2024-04-29 13:21       ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` [PATCH v6 07/10] util/bufferiszero: Introduce biz_accel_fn typedef Richard Henderson
2024-04-29 11:14   ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` [PATCH v6 08/10] util/bufferiszero: Simplify test_buffer_is_zero_next_accel Richard Henderson
2024-04-29 11:05   ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` Richard Henderson [this message]
2024-04-29 11:06   ` [PATCH v6 09/10] util/bufferiszero: Add simd acceleration for aarch64 Philippe Mathieu-Daudé
2024-04-29 12:45   ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` [PATCH v6 10/10] tests/bench: Add bufferiszero-bench Richard Henderson
2024-04-29 11:12   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424225705.929812-10-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).