qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v6 07/10] util/bufferiszero: Introduce biz_accel_fn typedef
Date: Wed, 24 Apr 2024 15:57:02 -0700	[thread overview]
Message-ID: <20240424225705.929812-8-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240424225705.929812-1-richard.henderson@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 util/bufferiszero.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/util/bufferiszero.c b/util/bufferiszero.c
index c9a7ded016..eb8030a3f0 100644
--- a/util/bufferiszero.c
+++ b/util/bufferiszero.c
@@ -26,7 +26,8 @@
 #include "qemu/bswap.h"
 #include "host/cpuinfo.h"
 
-static bool (*buffer_is_zero_accel)(const void *, size_t);
+typedef bool (*biz_accel_fn)(const void *, size_t);
+static biz_accel_fn buffer_is_zero_accel;
 
 static bool buffer_is_zero_int_lt256(const void *buf, size_t len)
 {
@@ -178,13 +179,15 @@ buffer_zero_avx2(const void *buf, size_t len)
 }
 #endif /* CONFIG_AVX2_OPT */
 
+
+
 static unsigned __attribute__((noinline))
 select_accel_cpuinfo(unsigned info)
 {
     /* Array is sorted in order of algorithm preference. */
     static const struct {
         unsigned bit;
-        bool (*fn)(const void *, size_t);
+        biz_accel_fn fn;
     } all[] = {
 #ifdef CONFIG_AVX2_OPT
         { CPUINFO_AVX2,    buffer_zero_avx2 },
@@ -231,7 +234,7 @@ bool test_buffer_is_zero_next_accel(void)
 #define INIT_ACCEL buffer_is_zero_int_ge256
 #endif
 
-static bool (*buffer_is_zero_accel)(const void *, size_t) = INIT_ACCEL;
+static biz_accel_fn buffer_is_zero_accel = INIT_ACCEL;
 
 bool buffer_is_zero_ool(const void *buf, size_t len)
 {
-- 
2.34.1



  parent reply	other threads:[~2024-04-24 22:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 22:56 [PATCH v6 00/10] Optimize buffer_is_zero Richard Henderson
2024-04-24 22:56 ` [PATCH v6 01/10] util/bufferiszero: Remove SSE4.1 variant Richard Henderson
2024-04-24 22:56 ` [PATCH v6 02/10] util/bufferiszero: Remove AVX512 variant Richard Henderson
2024-04-29 11:16   ` Daniel P. Berrangé
2024-04-29 11:29     ` Alexander Monakov
2024-04-24 22:56 ` [PATCH v6 03/10] util/bufferiszero: Reorganize for early test for acceleration Richard Henderson
2024-04-24 22:56 ` [PATCH v6 04/10] util/bufferiszero: Remove useless prefetches Richard Henderson
2024-04-24 22:57 ` [PATCH v6 05/10] util/bufferiszero: Optimize SSE2 and AVX2 variants Richard Henderson
2024-04-24 22:57 ` [PATCH v6 06/10] util/bufferiszero: Improve scalar variant Richard Henderson
2024-04-29 12:18   ` Philippe Mathieu-Daudé
2024-04-29 12:31     ` Richard Henderson
2024-04-29 13:21       ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` Richard Henderson [this message]
2024-04-29 11:14   ` [PATCH v6 07/10] util/bufferiszero: Introduce biz_accel_fn typedef Philippe Mathieu-Daudé
2024-04-24 22:57 ` [PATCH v6 08/10] util/bufferiszero: Simplify test_buffer_is_zero_next_accel Richard Henderson
2024-04-29 11:05   ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` [PATCH v6 09/10] util/bufferiszero: Add simd acceleration for aarch64 Richard Henderson
2024-04-29 11:06   ` Philippe Mathieu-Daudé
2024-04-29 12:45   ` Philippe Mathieu-Daudé
2024-04-24 22:57 ` [PATCH v6 10/10] tests/bench: Add bufferiszero-bench Richard Henderson
2024-04-29 11:12   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424225705.929812-8-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).