From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Miroslav Rezanina <mrezanin@redhat.com>
Subject: [PATCH 2/3] hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA
Date: Thu, 25 Apr 2024 20:43:14 +0200 [thread overview]
Message-ID: <20240425184315.553329-3-thuth@redhat.com> (raw)
In-Reply-To: <20240425184315.553329-1-thuth@redhat.com>
The q35 machine can be used without floppy disk controller (FDC),
but due to our current Kconfig setup, the FDC code is still always
included in the binary. To fix this, the "PC" config option should
only imply the "FDC_ISA" instead of always selecting it.
The i440fx and the isa-pc machine currently always instantiate
the FDC, so we have to add the select statements now there instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/i386/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index a6ee052f9a..0b08580862 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -32,7 +32,7 @@ config PC
imply VGA_PCI
imply VIRTIO_VGA
imply NVDIMM
- select FDC_ISA
+ imply FDC_ISA
select I8259
select I8254
select PCKBD
@@ -70,6 +70,7 @@ config I440FX
imply VMPORT
imply VMMOUSE
select ACPI_PIIX4
+ select FDC_ISA
select PC_PCI
select PC_ACPI
select PCI_I440FX
@@ -83,6 +84,7 @@ config ISAPC
bool
imply VGA_ISA
select ISA_BUS
+ select FDC_ISA
select PC
select IDE_ISA
# FIXME: it is in the same file as i440fx, and does not compile
--
2.44.0
next prev parent reply other threads:[~2024-04-25 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:43 [PATCH 0/3] Make it possible to compile the x86 binaries without FDC Thomas Huth
2024-04-25 18:43 ` [PATCH 1/3] hw/i386/pc: Allow to compile without CONFIG_FDC_ISA Thomas Huth
2024-05-06 14:26 ` Philippe Mathieu-Daudé
2024-04-25 18:43 ` Thomas Huth [this message]
2024-04-25 18:43 ` [RFC PATCH 3/3] hw/i386: Add the possibility to use i440fx and isapc without FDC Thomas Huth
2024-04-25 20:56 ` [PATCH 0/3] Make it possible to compile the x86 binaries " Philippe Mathieu-Daudé
2024-04-26 5:08 ` Thomas Huth
2024-04-29 10:31 ` Kevin Wolf
2024-05-06 14:27 ` Philippe Mathieu-Daudé
2024-05-06 15:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425184315.553329-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mrezanin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).