From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [RFC PATCH 09/14] exec/cpu: Restrict user-specific page definitions
Date: Sat, 27 Apr 2024 17:57:09 +0200 [thread overview]
Message-ID: <20240427155714.53669-10-philmd@linaro.org> (raw)
In-Reply-To: <20240427155714.53669-1-philmd@linaro.org>
User-specific PAGE definitions shouldn't be used on system emulation.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/exec/page-prot-common.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/exec/page-prot-common.h b/include/exec/page-prot-common.h
index 2722ded724..b1fce45c15 100644
--- a/include/exec/page-prot-common.h
+++ b/include/exec/page-prot-common.h
@@ -17,16 +17,22 @@
/*
* Original state of the write flag (used when tracking self-modifying code)
*/
+#if defined(CONFIG_USER_ONLY)
#define PAGE_WRITE_ORG 0x0010
+#endif
/*
* Invalidate the TLB entry immediately, helpful for s390x
* Low-Address-Protection. Used with PAGE_WRITE in tlb_set_page_with_attrs()
*/
#define PAGE_WRITE_INV 0x0020
/* For use with page_set_flags: page is being replaced; target_data cleared. */
+#if defined(CONFIG_USER_ONLY)
#define PAGE_RESET 0x0040
+#endif
/* For linux-user, indicates that the page is MAP_ANON. */
+#if defined(CONFIG_USER_ONLY)
#define PAGE_ANON 0x0080
+#endif
/* Target-specific bits that will be used via page_get_flags(). */
#define PAGE_TARGET_1 0x0200
@@ -36,6 +42,8 @@
* For linux-user, indicates that the page is mapped with the same semantics
* in both guest and host.
*/
+#if defined(CONFIG_USER_ONLY)
#define PAGE_PASSTHROUGH 0x0800
+#endif
#endif
--
2.41.0
next prev parent reply other threads:[~2024-04-27 15:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 15:57 [PATCH 00/14] exec: Rework around CPUState user fields Philippe Mathieu-Daudé
2024-04-27 15:57 ` [PATCH 01/14] target/i386: Simplify get_memio_eip() Philippe Mathieu-Daudé
2024-04-28 18:11 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 02/14] plugins: Update stale comment Philippe Mathieu-Daudé
2024-04-28 18:13 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 03/14] plugins/api: Only include 'exec/ram_addr.h' with system emulation Philippe Mathieu-Daudé
2024-04-28 18:26 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 04/14] exec: Include missing license in 'exec/cpu-common.h' Philippe Mathieu-Daudé
2024-04-28 18:26 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 05/14] exec/cpu: Indent TARGET_PAGE_foo definitions Philippe Mathieu-Daudé
2024-04-28 18:27 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 06/14] exec/cpu: Remove obsolete PAGE_RESERVED definition Philippe Mathieu-Daudé
2024-04-28 18:28 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 07/14] exec/cpu: Remove duplicated PAGE_PASSTHROUGH definition Philippe Mathieu-Daudé
2024-04-28 18:28 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 08/14] exec/cpu: Extract page-protection definitions to page-prot-common.h Philippe Mathieu-Daudé
2024-04-28 18:29 ` Richard Henderson
2024-04-27 15:57 ` Philippe Mathieu-Daudé [this message]
2024-04-28 18:31 ` [RFC PATCH 09/14] exec/cpu: Restrict user-specific page definitions Richard Henderson
2024-04-28 20:11 ` Philippe Mathieu-Daudé
2024-04-27 15:57 ` [PATCH 10/14] exec/user: Restrict 'syscall-trace.h' to user emulation Philippe Mathieu-Daudé
2024-04-28 18:32 ` Richard Henderson
2024-04-28 20:13 ` Philippe Mathieu-Daudé
2024-04-27 15:57 ` [PATCH 11/14] accel/tcg: Use cpu_loop_exit_requested() in cpu_loop_exec_tb() Philippe Mathieu-Daudé
2024-04-28 18:35 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 12/14] accel/tcg: Remove pointless initialization of cflags_next_tb Philippe Mathieu-Daudé
2024-04-28 18:39 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 13/14] accel/tcg: Reset TCG specific fields in tcg_cpu_reset_hold() Philippe Mathieu-Daudé
2024-04-28 18:46 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 14/14] accel/tcg: Access tcg_cflags with getter / setter Philippe Mathieu-Daudé
2024-04-28 18:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240427155714.53669-10-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).