From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Anton Johansson" <anjo@rev.ng>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 15/24] accel/tcg: Restrict IcountDecr and CPUTLB to TCG
Date: Mon, 29 Apr 2024 00:14:41 +0200 [thread overview]
Message-ID: <20240428221450.26460-16-philmd@linaro.org> (raw)
In-Reply-To: <20240428221450.26460-1-philmd@linaro.org>
IcountDecr union, the CPUTLB* structures and the
"exec/tlb-common.h" header are only required for
TCG.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/exec/tlb-common.h | 4 ++++
include/hw/core/cpu.h | 9 ++++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/include/exec/tlb-common.h b/include/exec/tlb-common.h
index dc5a5faa0b..a529c9f056 100644
--- a/include/exec/tlb-common.h
+++ b/include/exec/tlb-common.h
@@ -19,6 +19,10 @@
#ifndef EXEC_TLB_COMMON_H
#define EXEC_TLB_COMMON_H 1
+#ifndef CONFIG_TCG
+#error Can only include this header with TCG
+#endif
+
#define CPU_TLB_ENTRY_BITS 5
/* Minimalized TLB entry for use by TCG fast path. */
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index ef8b85b6fe..dc28920bcc 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -27,7 +27,6 @@
#include "exec/vaddr.h"
#include "exec/memattrs.h"
#include "exec/mmu-access-type.h"
-#include "exec/tlb-common.h"
#include "qapi/qapi-types-run-state.h"
#include "qemu/bitmap.h"
#include "qemu/rcu_queue.h"
@@ -256,6 +255,9 @@ typedef struct CPUTLBEntryFull {
} extra;
} CPUTLBEntryFull;
+#ifdef CONFIG_TCG
+#include "exec/tlb-common.h"
+
/*
* Data elements that are per MMU mode, minus the bits accessed by
* the TCG fast path.
@@ -311,11 +313,9 @@ typedef struct CPUTLBCommon {
* negative offsets are at the end of the struct.
*/
typedef struct CPUTLB {
-#ifdef CONFIG_TCG
CPUTLBCommon c;
CPUTLBDesc d[NB_MMU_MODES];
CPUTLBDescFast f[NB_MMU_MODES];
-#endif
} CPUTLB;
/*
@@ -337,6 +337,7 @@ typedef union IcountDecr {
#endif
} u16;
} IcountDecr;
+#endif
/**
* CPUNegativeOffsetState: Elements of CPUState most efficiently accessed
@@ -346,6 +347,7 @@ typedef union IcountDecr {
* @plugin_state: per-CPU plugin state
*/
typedef struct CPUNegativeOffsetState {
+#ifdef CONFIG_TCG
CPUTLB tlb;
#ifdef CONFIG_PLUGIN
/*
@@ -356,6 +358,7 @@ typedef struct CPUNegativeOffsetState {
#endif
IcountDecr icount_decr;
bool can_do_io;
+#endif
} CPUNegativeOffsetState;
struct KVMState;
--
2.41.0
next prev parent reply other threads:[~2024-04-28 22:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 22:14 [PATCH 00/24] exec: Rework around CPUState user fields (part 2) Philippe Mathieu-Daudé
2024-04-28 22:14 ` [PATCH 01/24] exec/user: Move 'thunk.h' from 'exec/user' to 'user' Philippe Mathieu-Daudé
2024-04-29 0:49 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 02/24] coverity: Update user emulation regexp Philippe Mathieu-Daudé
2024-04-29 0:52 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 03/24] accel/tcg: Move user definition of cpu_interrupt() to user-exec.c Philippe Mathieu-Daudé
2024-04-29 0:54 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 04/24] accel/tcg: Duplicate cpu_exit() for user / system Philippe Mathieu-Daudé
2024-04-29 0:58 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 05/24] accel/tcg: Extract tcg_cpu_exit() from cpu_exit() Philippe Mathieu-Daudé
2024-04-29 1:02 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 06/24] accel: Introduce AccelOpsClass::exit_vcpu_thread() handler Philippe Mathieu-Daudé
2024-04-29 1:05 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 07/24] accel/tcg: Implement " Philippe Mathieu-Daudé
2024-04-29 1:09 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 08/24] user: Forward declare TaskState type definition Philippe Mathieu-Daudé
2024-04-29 1:13 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 09/24] user: Declare get_task_state() once in 'accel/tcg/vcpu-state.h' Philippe Mathieu-Daudé
2024-04-29 1:19 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 10/24] user: Use get_task_state() helper Philippe Mathieu-Daudé
2024-04-29 1:27 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 11/24] accel/tcg: Allocate per-vCPU accel state in create_vcpu_thread() Philippe Mathieu-Daudé
2024-04-29 14:23 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 12/24] accel/tcg: Move TaskState from CPUState to TCG AccelCPUState Philippe Mathieu-Daudé
2024-04-29 14:31 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 13/24] accel/tcg: Update CPUNegativeOffsetState::can_do_io field documentation Philippe Mathieu-Daudé
2024-04-29 14:33 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 14/24] accel/tcg: Move plugin fields to CPUNegativeOffsetState Philippe Mathieu-Daudé
2024-04-29 14:42 ` Richard Henderson
2024-04-29 20:54 ` Philippe Mathieu-Daudé
2024-04-28 22:14 ` Philippe Mathieu-Daudé [this message]
2024-04-29 14:03 ` [PATCH 15/24] accel/tcg: Restrict IcountDecr and CPUTLB to TCG Philippe Mathieu-Daudé
2024-04-29 14:46 ` Richard Henderson
2024-04-29 14:48 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 16/24] accel/tcg: Move @jmp_env from CPUState to TCG AccelCPUState Philippe Mathieu-Daudé
2024-04-29 14:51 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 17/24] accel/tcg: Move @mem_io_pc " Philippe Mathieu-Daudé
2024-04-29 15:02 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 18/24] accel/tcg: Move @cflags_next_tb " Philippe Mathieu-Daudé
2024-04-29 15:22 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 19/24] accel/tcg: Move @iommu_notifiers " Philippe Mathieu-Daudé
2024-04-29 15:25 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 20/24] accel/tcg: Move @tb_jmp_cache " Philippe Mathieu-Daudé
2024-04-29 19:15 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 21/24] accel/tcg: Remove NULL check in tcg_flush_jmp_cache() Philippe Mathieu-Daudé
2024-04-28 22:14 ` [PATCH 22/24] accel/tcg: Move @tcg_cflags from CPUState to TCG AccelCPUState Philippe Mathieu-Daudé
2024-04-29 19:30 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 23/24] accel/tcg: Restrict icount to system emulation Philippe Mathieu-Daudé
2024-04-29 21:07 ` Richard Henderson
2024-04-28 22:14 ` [PATCH 24/24] accel/tcg: Move icount fields from CPUState to TCG AccelCPUState Philippe Mathieu-Daudé
2024-04-29 21:08 ` Richard Henderson
2024-04-28 22:22 ` [PATCH 00/24] exec: Rework around CPUState user fields (part 2) Philippe Mathieu-Daudé
2024-04-29 21:04 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428221450.26460-16-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=anjo@rev.ng \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).