From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 11/20] plugins: Remove plugin helpers
Date: Wed, 1 May 2024 07:37:30 -0700 [thread overview]
Message-ID: <20240501143739.10541-12-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240501143739.10541-1-richard.henderson@linaro.org>
These placeholder helpers are no longer required.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/plugin-helpers.h | 5 -----
include/exec/helper-gen-common.h | 4 ----
include/exec/helper-proto-common.h | 4 ----
accel/tcg/plugin-gen.c | 20 --------------------
4 files changed, 33 deletions(-)
delete mode 100644 accel/tcg/plugin-helpers.h
diff --git a/accel/tcg/plugin-helpers.h b/accel/tcg/plugin-helpers.h
deleted file mode 100644
index 11796436f3..0000000000
--- a/accel/tcg/plugin-helpers.h
+++ /dev/null
@@ -1,5 +0,0 @@
-#ifdef CONFIG_PLUGIN
-DEF_HELPER_FLAGS_2(plugin_vcpu_udata_cb_no_wg, TCG_CALL_NO_WG | TCG_CALL_PLUGIN, void, i32, ptr)
-DEF_HELPER_FLAGS_2(plugin_vcpu_udata_cb_no_rwg, TCG_CALL_NO_RWG | TCG_CALL_PLUGIN, void, i32, ptr)
-DEF_HELPER_FLAGS_4(plugin_vcpu_mem_cb, TCG_CALL_NO_RWG | TCG_CALL_PLUGIN, void, i32, i32, i64, ptr)
-#endif
diff --git a/include/exec/helper-gen-common.h b/include/exec/helper-gen-common.h
index 5d6d78a625..834590dc4e 100644
--- a/include/exec/helper-gen-common.h
+++ b/include/exec/helper-gen-common.h
@@ -11,8 +11,4 @@
#include "exec/helper-gen.h.inc"
#undef HELPER_H
-#define HELPER_H "accel/tcg/plugin-helpers.h"
-#include "exec/helper-gen.h.inc"
-#undef HELPER_H
-
#endif /* HELPER_GEN_COMMON_H */
diff --git a/include/exec/helper-proto-common.h b/include/exec/helper-proto-common.h
index 8b67170a22..16782ef46c 100644
--- a/include/exec/helper-proto-common.h
+++ b/include/exec/helper-proto-common.h
@@ -13,8 +13,4 @@
#include "exec/helper-proto.h.inc"
#undef HELPER_H
-#define HELPER_H "accel/tcg/plugin-helpers.h"
-#include "exec/helper-proto.h.inc"
-#undef HELPER_H
-
#endif /* HELPER_PROTO_COMMON_H */
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index 8f8ae156b6..fb77585ac0 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -51,11 +51,6 @@
#include "exec/exec-all.h"
#include "exec/plugin-gen.h"
#include "exec/translator.h"
-#include "exec/helper-proto-common.h"
-
-#define HELPER_H "accel/tcg/plugin-helpers.h"
-#include "exec/helper-info.c.inc"
-#undef HELPER_H
/*
* plugin_cb_start TCG op args[]:
@@ -82,21 +77,6 @@ enum plugin_gen_cb {
PLUGIN_GEN_N_CBS,
};
-/*
- * These helpers are stubs that get dynamically switched out for calls
- * direct to the plugin if they are subscribed to.
- */
-void HELPER(plugin_vcpu_udata_cb_no_wg)(uint32_t cpu_index, void *udata)
-{ }
-
-void HELPER(plugin_vcpu_udata_cb_no_rwg)(uint32_t cpu_index, void *udata)
-{ }
-
-void HELPER(plugin_vcpu_mem_cb)(unsigned int vcpu_index,
- qemu_plugin_meminfo_t info, uint64_t vaddr,
- void *userdata)
-{ }
-
static void plugin_gen_empty_callback(enum plugin_gen_from from)
{
switch (from) {
--
2.34.1
next prev parent reply other threads:[~2024-05-01 14:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 14:37 [PULL 00/20] tcg patch queue Richard Henderson
2024-05-01 14:37 ` [PULL 01/20] tcg: Make tcg/helper-info.h self-contained Richard Henderson
2024-05-01 14:37 ` [PULL 02/20] tcg: Pass function pointer to tcg_gen_call* Richard Henderson
2024-05-01 14:37 ` [PULL 03/20] plugins: Zero new qemu_plugin_dyn_cb entries Richard Henderson
2024-05-01 14:37 ` [PULL 04/20] plugins: Move function pointer in qemu_plugin_dyn_cb Richard Henderson
2024-05-01 14:37 ` [PULL 05/20] plugins: Create TCGHelperInfo for all out-of-line callbacks Richard Henderson
2024-05-01 14:37 ` [PULL 06/20] plugins: Use emit_before_op for PLUGIN_GEN_AFTER_INSN Richard Henderson
2024-05-01 14:37 ` [PULL 07/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_TB Richard Henderson
2024-05-01 14:37 ` [PULL 08/20] plugins: Add PLUGIN_GEN_AFTER_TB Richard Henderson
2024-05-01 14:37 ` [PULL 09/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_INSN Richard Henderson
2024-05-01 14:37 ` [PULL 10/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_MEM Richard Henderson
2024-05-01 14:37 ` Richard Henderson [this message]
2024-05-01 14:37 ` [PULL 12/20] tcg: Remove TCG_CALL_PLUGIN Richard Henderson
2024-05-01 14:37 ` [PULL 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end} Richard Henderson
2024-05-01 14:37 ` [PULL 14/20] plugins: Simplify callback queues Richard Henderson
2024-05-01 14:37 ` [PULL 15/20] plugins: Introduce PLUGIN_CB_MEM_REGULAR Richard Henderson
2024-05-01 14:37 ` [PULL 16/20] plugins: Replace pr_ops with a proper debug dump flag Richard Henderson
2024-05-01 14:37 ` [PULL 17/20] plugins: Split out common cb expanders Richard Henderson
2024-05-01 14:37 ` [PULL 18/20] plugins: Merge qemu_plugin_tb_insn_get to plugin-gen.c Richard Henderson
2024-05-01 14:37 ` [PULL 19/20] plugins: Inline plugin_gen_empty_callback Richard Henderson
2024-05-01 14:37 ` [PULL 20/20] plugins: Update the documentation block for plugin-gen.c Richard Henderson
2024-05-02 0:17 ` [PULL 00/20] tcg patch queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501143739.10541-12-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).