From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: [PULL 15/20] plugins: Introduce PLUGIN_CB_MEM_REGULAR
Date: Wed, 1 May 2024 07:37:34 -0700 [thread overview]
Message-ID: <20240501143739.10541-16-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240501143739.10541-1-richard.henderson@linaro.org>
Use different enumerators for vcpu_udata and vcpu_mem callbacks.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/qemu/plugin.h | 1 +
accel/tcg/plugin-gen.c | 2 +-
plugins/core.c | 4 ++--
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h
index b679a22bae..f5a08b1220 100644
--- a/include/qemu/plugin.h
+++ b/include/qemu/plugin.h
@@ -68,6 +68,7 @@ union qemu_plugin_cb_sig {
enum plugin_dyn_cb_type {
PLUGIN_CB_REGULAR,
+ PLUGIN_CB_MEM_REGULAR,
PLUGIN_CB_INLINE,
};
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index e77ff2a565..c545303956 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -361,7 +361,7 @@ static void plugin_gen_inject(struct qemu_plugin_tb *plugin_tb)
if (cb->rw & rw) {
switch (cb->type) {
- case PLUGIN_CB_REGULAR:
+ case PLUGIN_CB_MEM_REGULAR:
gen_mem_cb(cb, meminfo, addr);
break;
case PLUGIN_CB_INLINE:
diff --git a/plugins/core.c b/plugins/core.c
index b0615f1e7f..0213513ec6 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -391,7 +391,7 @@ void plugin_register_vcpu_mem_cb(GArray **arr,
struct qemu_plugin_dyn_cb *dyn_cb = plugin_get_dyn_cb(arr);
dyn_cb->userp = udata;
- dyn_cb->type = PLUGIN_CB_REGULAR;
+ dyn_cb->type = PLUGIN_CB_MEM_REGULAR;
dyn_cb->rw = rw;
dyn_cb->regular.f.vcpu_mem = cb;
@@ -547,7 +547,7 @@ void qemu_plugin_vcpu_mem_cb(CPUState *cpu, uint64_t vaddr,
break;
}
switch (cb->type) {
- case PLUGIN_CB_REGULAR:
+ case PLUGIN_CB_MEM_REGULAR:
cb->regular.f.vcpu_mem(cpu->cpu_index, make_plugin_meminfo(oi, rw),
vaddr, cb->userp);
break;
--
2.34.1
next prev parent reply other threads:[~2024-05-01 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 14:37 [PULL 00/20] tcg patch queue Richard Henderson
2024-05-01 14:37 ` [PULL 01/20] tcg: Make tcg/helper-info.h self-contained Richard Henderson
2024-05-01 14:37 ` [PULL 02/20] tcg: Pass function pointer to tcg_gen_call* Richard Henderson
2024-05-01 14:37 ` [PULL 03/20] plugins: Zero new qemu_plugin_dyn_cb entries Richard Henderson
2024-05-01 14:37 ` [PULL 04/20] plugins: Move function pointer in qemu_plugin_dyn_cb Richard Henderson
2024-05-01 14:37 ` [PULL 05/20] plugins: Create TCGHelperInfo for all out-of-line callbacks Richard Henderson
2024-05-01 14:37 ` [PULL 06/20] plugins: Use emit_before_op for PLUGIN_GEN_AFTER_INSN Richard Henderson
2024-05-01 14:37 ` [PULL 07/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_TB Richard Henderson
2024-05-01 14:37 ` [PULL 08/20] plugins: Add PLUGIN_GEN_AFTER_TB Richard Henderson
2024-05-01 14:37 ` [PULL 09/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_INSN Richard Henderson
2024-05-01 14:37 ` [PULL 10/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_MEM Richard Henderson
2024-05-01 14:37 ` [PULL 11/20] plugins: Remove plugin helpers Richard Henderson
2024-05-01 14:37 ` [PULL 12/20] tcg: Remove TCG_CALL_PLUGIN Richard Henderson
2024-05-01 14:37 ` [PULL 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end} Richard Henderson
2024-05-01 14:37 ` [PULL 14/20] plugins: Simplify callback queues Richard Henderson
2024-05-01 14:37 ` Richard Henderson [this message]
2024-05-01 14:37 ` [PULL 16/20] plugins: Replace pr_ops with a proper debug dump flag Richard Henderson
2024-05-01 14:37 ` [PULL 17/20] plugins: Split out common cb expanders Richard Henderson
2024-05-01 14:37 ` [PULL 18/20] plugins: Merge qemu_plugin_tb_insn_get to plugin-gen.c Richard Henderson
2024-05-01 14:37 ` [PULL 19/20] plugins: Inline plugin_gen_empty_callback Richard Henderson
2024-05-01 14:37 ` [PULL 20/20] plugins: Update the documentation block for plugin-gen.c Richard Henderson
2024-05-02 0:17 ` [PULL 00/20] tcg patch queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501143739.10541-16-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).