From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 19/20] plugins: Inline plugin_gen_empty_callback
Date: Wed, 1 May 2024 07:37:38 -0700 [thread overview]
Message-ID: <20240501143739.10541-20-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240501143739.10541-1-richard.henderson@linaro.org>
Each caller can use tcg_gen_plugin_cb directly.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/plugin-gen.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index c0cbc26984..d914d64de0 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -60,19 +60,6 @@ enum plugin_gen_from {
PLUGIN_GEN_AFTER_TB,
};
-static void plugin_gen_empty_callback(enum plugin_gen_from from)
-{
- switch (from) {
- case PLUGIN_GEN_AFTER_INSN:
- case PLUGIN_GEN_FROM_TB:
- case PLUGIN_GEN_FROM_INSN:
- tcg_gen_plugin_cb(from);
- break;
- default:
- g_assert_not_reached();
- }
-}
-
/* called before finishing a TB with exit_tb, goto_tb or goto_ptr */
void plugin_gen_disable_mem_helpers(void)
{
@@ -362,7 +349,7 @@ bool plugin_gen_tb_start(CPUState *cpu, const DisasContextBase *db,
ptb->mem_only = mem_only;
ptb->mem_helper = false;
- plugin_gen_empty_callback(PLUGIN_GEN_FROM_TB);
+ tcg_gen_plugin_cb(PLUGIN_GEN_FROM_TB);
}
tcg_ctx->plugin_insn = NULL;
@@ -419,12 +406,12 @@ void plugin_gen_insn_start(CPUState *cpu, const DisasContextBase *db)
insn->haddr = ptb->haddr2 + pc - ptb->vaddr2;
}
- plugin_gen_empty_callback(PLUGIN_GEN_FROM_INSN);
+ tcg_gen_plugin_cb(PLUGIN_GEN_FROM_INSN);
}
void plugin_gen_insn_end(void)
{
- plugin_gen_empty_callback(PLUGIN_GEN_AFTER_INSN);
+ tcg_gen_plugin_cb(PLUGIN_GEN_AFTER_INSN);
}
/*
--
2.34.1
next prev parent reply other threads:[~2024-05-01 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 14:37 [PULL 00/20] tcg patch queue Richard Henderson
2024-05-01 14:37 ` [PULL 01/20] tcg: Make tcg/helper-info.h self-contained Richard Henderson
2024-05-01 14:37 ` [PULL 02/20] tcg: Pass function pointer to tcg_gen_call* Richard Henderson
2024-05-01 14:37 ` [PULL 03/20] plugins: Zero new qemu_plugin_dyn_cb entries Richard Henderson
2024-05-01 14:37 ` [PULL 04/20] plugins: Move function pointer in qemu_plugin_dyn_cb Richard Henderson
2024-05-01 14:37 ` [PULL 05/20] plugins: Create TCGHelperInfo for all out-of-line callbacks Richard Henderson
2024-05-01 14:37 ` [PULL 06/20] plugins: Use emit_before_op for PLUGIN_GEN_AFTER_INSN Richard Henderson
2024-05-01 14:37 ` [PULL 07/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_TB Richard Henderson
2024-05-01 14:37 ` [PULL 08/20] plugins: Add PLUGIN_GEN_AFTER_TB Richard Henderson
2024-05-01 14:37 ` [PULL 09/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_INSN Richard Henderson
2024-05-01 14:37 ` [PULL 10/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_MEM Richard Henderson
2024-05-01 14:37 ` [PULL 11/20] plugins: Remove plugin helpers Richard Henderson
2024-05-01 14:37 ` [PULL 12/20] tcg: Remove TCG_CALL_PLUGIN Richard Henderson
2024-05-01 14:37 ` [PULL 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end} Richard Henderson
2024-05-01 14:37 ` [PULL 14/20] plugins: Simplify callback queues Richard Henderson
2024-05-01 14:37 ` [PULL 15/20] plugins: Introduce PLUGIN_CB_MEM_REGULAR Richard Henderson
2024-05-01 14:37 ` [PULL 16/20] plugins: Replace pr_ops with a proper debug dump flag Richard Henderson
2024-05-01 14:37 ` [PULL 17/20] plugins: Split out common cb expanders Richard Henderson
2024-05-01 14:37 ` [PULL 18/20] plugins: Merge qemu_plugin_tb_insn_get to plugin-gen.c Richard Henderson
2024-05-01 14:37 ` Richard Henderson [this message]
2024-05-01 14:37 ` [PULL 20/20] plugins: Update the documentation block for plugin-gen.c Richard Henderson
2024-05-02 0:17 ` [PULL 00/20] tcg patch queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501143739.10541-20-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).