* [PATCH] tests/qtest: skip m48t59-test if the machine is not absent
@ 2024-05-03 8:51 Paolo Bonzini
2024-05-03 13:15 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2024-05-03 8:51 UTC (permalink / raw)
To: qemu-devel; +Cc: mark.cave-ayland
Together with the series at https://patchew.org/QEMU/20240423131612.28362-1-pbonzini@redhat.com/,
this allows adding sparc-softmmu to the target list of the
build-without-defaults CI job.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/qtest/m48t59-test.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/m48t59-test.c b/tests/qtest/m48t59-test.c
index b9cd209165a..605797ab785 100644
--- a/tests/qtest/m48t59-test.c
+++ b/tests/qtest/m48t59-test.c
@@ -262,11 +262,12 @@ int main(int argc, char **argv)
base_setup();
g_test_init(&argc, &argv, NULL);
-
- if (g_test_slow()) {
- /* Do not run this in timing-sensitive environments */
- qtest_add_func("/rtc/bcd-check-time", bcd_check_time);
+ if (qtest_has_machine(base_machine)) {
+ if (g_test_slow()) {
+ /* Do not run this in timing-sensitive environments */
+ qtest_add_func("/rtc/bcd-check-time", bcd_check_time);
+ }
+ qtest_add_func("/rtc/fuzz-registers", fuzz_registers);
}
- qtest_add_func("/rtc/fuzz-registers", fuzz_registers);
return g_test_run();
}
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tests/qtest: skip m48t59-test if the machine is not absent
2024-05-03 8:51 [PATCH] tests/qtest: skip m48t59-test if the machine is not absent Paolo Bonzini
@ 2024-05-03 13:15 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2024-05-03 13:15 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: mark.cave-ayland
On 5/3/24 01:51, Paolo Bonzini wrote:
> Together with the series at https://patchew.org/QEMU/20240423131612.28362-1-pbonzini@redhat.com/,
> this allows adding sparc-softmmu to the target list of the
> build-without-defaults CI job.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qtest/m48t59-test.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
s/absent/present/ in subject.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/tests/qtest/m48t59-test.c b/tests/qtest/m48t59-test.c
> index b9cd209165a..605797ab785 100644
> --- a/tests/qtest/m48t59-test.c
> +++ b/tests/qtest/m48t59-test.c
> @@ -262,11 +262,12 @@ int main(int argc, char **argv)
> base_setup();
>
> g_test_init(&argc, &argv, NULL);
> -
> - if (g_test_slow()) {
> - /* Do not run this in timing-sensitive environments */
> - qtest_add_func("/rtc/bcd-check-time", bcd_check_time);
> + if (qtest_has_machine(base_machine)) {
> + if (g_test_slow()) {
> + /* Do not run this in timing-sensitive environments */
> + qtest_add_func("/rtc/bcd-check-time", bcd_check_time);
> + }
> + qtest_add_func("/rtc/fuzz-registers", fuzz_registers);
> }
> - qtest_add_func("/rtc/fuzz-registers", fuzz_registers);
> return g_test_run();
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-03 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-03 8:51 [PATCH] tests/qtest: skip m48t59-test if the machine is not absent Paolo Bonzini
2024-05-03 13:15 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).