qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PULL 12/46] i386: switch boards to "default y"
Date: Mon,  6 May 2024 09:50:51 +0200	[thread overview]
Message-ID: <20240506075125.8238-13-pbonzini@redhat.com> (raw)
In-Reply-To: <20240506075125.8238-1-pbonzini@redhat.com>

Some targets use "default y" for boards to filter out those that require
TCG.  For consistency we are switching all other targets to do the same.
Continue with i386.

No changes to generated config-devices.mak files, other than
adding CONFIG_I386 to the x86_64-softmmu target.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configs/devices/i386-softmmu/default.mak | 11 +++++------
 .gitlab-ci.d/buildtest.yml               |  3 ++-
 hw/i386/Kconfig                          | 10 +++++++++-
 target/i386/Kconfig                      |  1 +
 4 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak
index 598c6646dfc..448e3e3b1ba 100644
--- a/configs/devices/i386-softmmu/default.mak
+++ b/configs/devices/i386-softmmu/default.mak
@@ -24,9 +24,8 @@
 #CONFIG_VTD=n
 #CONFIG_SGX=n
 
-# Boards:
-#
-CONFIG_ISAPC=y
-CONFIG_I440FX=y
-CONFIG_Q35=y
-CONFIG_MICROVM=y
+# Boards are selected by default, uncomment to keep out of the build.
+# CONFIG_ISAPC=n
+# CONFIG_I440FX=n
+# CONFIG_Q35=n
+# CONFIG_MICROVM=n
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 6531758d968..75222c4450b 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -648,7 +648,8 @@ build-tci:
     - make check-tcg
 
 # Check our reduced build configurations
-# requires libfdt: aarch64, arm
+# requires libfdt: aarch64, arm, i386, x86_64
+# does not build without boards: i386, x86_64
 build-without-defaults:
   extends: .native_build_job_template
   needs:
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index a6ee052f9a1..4362164962c 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -66,6 +66,8 @@ config PC_ACPI
 
 config I440FX
     bool
+    default y
+    depends on I386
     imply E1000_PCI
     imply VMPORT
     imply VMMOUSE
@@ -81,6 +83,8 @@ config I440FX
 
 config ISAPC
     bool
+    default y
+    depends on I386
     imply VGA_ISA
     select ISA_BUS
     select PC
@@ -91,6 +95,8 @@ config ISAPC
 
 config Q35
     bool
+    default y
+    depends on I386
     imply VTD
     imply AMD_IOMMU
     imply E1000E_PCI_EXPRESS
@@ -108,6 +114,8 @@ config Q35
 
 config MICROVM
     bool
+    default y
+    depends on I386
     select SERIAL_ISA # for serial_hds_isa_init()
     select ISA_BUS
     select APIC
@@ -142,4 +150,4 @@ config VMMOUSE
 config XEN_EMU
     bool
     default y
-    depends on KVM && (I386 || X86_64)
+    depends on KVM && I386
diff --git a/target/i386/Kconfig b/target/i386/Kconfig
index 46898946394..ad9291d3b8f 100644
--- a/target/i386/Kconfig
+++ b/target/i386/Kconfig
@@ -5,3 +5,4 @@ config I386
 
 config X86_64
     bool
+    select I386
-- 
2.44.0



  parent reply	other threads:[~2024-05-06  7:53 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06  7:50 [PULL 00/46] Mostly build system and other cleanups patches for 2024-05-06 Paolo Bonzini
2024-05-06  7:50 ` [PULL 01/46] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK Paolo Bonzini
2024-05-06  7:50 ` [PULL 02/46] Kconfig: kvm: allow building without any board Paolo Bonzini
2024-05-06  7:50 ` [PULL 03/46] tests/qtest: skip m48t59-test if the machine is absent Paolo Bonzini
2024-05-06  7:50 ` [PULL 04/46] gitlab-ci: adjust msys2-64bit to be able to run qtest Paolo Bonzini
2024-05-06  7:50 ` [PULL 05/46] kvm: ppc: disable sPAPR code if CONFIG_PSERIES is disabled Paolo Bonzini
2024-05-06  7:50 ` [PULL 06/46] configs: list "implied" device groups in the default configs Paolo Bonzini
2024-05-06  7:50 ` [PULL 07/46] alpha: switch boards to "default y" Paolo Bonzini
2024-05-06  7:50 ` [PULL 08/46] arm: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 09/46] avr: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 10/46] cris: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 11/46] hppa: " Paolo Bonzini
2024-05-06  7:50 ` Paolo Bonzini [this message]
2024-05-06  7:50 ` [PULL 13/46] loongarch: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 14/46] m68k: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 15/46] microblaze: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 16/46] meson: make target endianneess available to Kconfig Paolo Bonzini
2024-05-06  7:50 ` [PULL 17/46] mips: switch boards to "default y" Paolo Bonzini
2024-05-06  7:50 ` [PULL 18/46] openrisc: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 19/46] ppc: " Paolo Bonzini
2024-05-06  7:50 ` [PULL 20/46] riscv: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 21/46] rx: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 22/46] s390x: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 23/46] sh4: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 24/46] sparc: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 25/46] tricore: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 26/46] xtensa: " Paolo Bonzini
2024-05-06  7:51 ` [PULL 27/46] docs: document new convention for Kconfig board symbols Paolo Bonzini
2024-05-06  7:51 ` [PULL 28/46] target/i386: Introduce SapphireRapids-v3 to add missing features Paolo Bonzini
2024-05-06  7:51 ` [PULL 29/46] bitmap: Use g_try_new0/g_new0/g_renew Paolo Bonzini
2024-05-06  7:51 ` [PULL 30/46] build: do not build virtio-vga-gl if virgl/opengl not available Paolo Bonzini
2024-05-06  7:51 ` [PULL 31/46] fw_cfg: remove useless declarations from typedefs.h Paolo Bonzini
2024-05-06  7:51 ` [PULL 32/46] qdev-core: remove DeviceListener " Paolo Bonzini
2024-05-06  7:51 ` [PULL 33/46] numa: remove types " Paolo Bonzini
2024-05-06  7:51 ` [PULL 34/46] net: remove AnnounceTimer " Paolo Bonzini
2024-05-06  7:51 ` [PULL 35/46] qemu-option: remove QemuOpt " Paolo Bonzini
2024-05-06  7:51 ` [PULL 36/46] intc: remove PICCommonState " Paolo Bonzini
2024-05-06  7:51 ` [PULL 37/46] lockable: remove QemuLockable " Paolo Bonzini
2024-05-06  7:51 ` [PULL 38/46] migration: remove PostcopyDiscardState " Paolo Bonzini
2024-05-06  7:51 ` [PULL 39/46] monitor: remove MonitorDef " Paolo Bonzini
2024-05-06  7:51 ` [PULL 40/46] qapi/machine: remove types " Paolo Bonzini
2024-05-06  7:51 ` [PULL 41/46] display: remove GraphicHwOps " Paolo Bonzini
2024-05-06  7:51 ` [PULL 42/46] tcg: remove CPU* types " Paolo Bonzini
2024-05-06  7:51 ` [PULL 43/46] pci: remove some " Paolo Bonzini
2024-05-06  7:51 ` [PULL 44/46] kvm: move target-dependent interrupt routing out of kvm-all.c Paolo Bonzini
2024-05-06  7:51 ` [PULL 45/46] migration: do not include coroutine_int.h Paolo Bonzini
2024-05-06  7:51 ` [PULL 46/46] qga/commands-posix: fix typo in qmp_guest_set_user_password Paolo Bonzini
2024-05-06 17:17 ` [PULL 00/46] Mostly build system and other cleanups patches for 2024-05-06 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240506075125.8238-13-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).