From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: "Eric Farman" <farman@linux.ibm.com>,
"Cédric Le Goater" <clg@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 1/8] hw/s390x: Attach the sclpconsole to /machine/sclp/s390-sclp-event-facility
Date: Fri, 10 May 2024 08:39:54 +0200 [thread overview]
Message-ID: <20240510064001.26002-2-thuth@redhat.com> (raw)
In-Reply-To: <20240510064001.26002-1-thuth@redhat.com>
The sclpconsole currently does not have a proper parent in the QOM
tree, so it shows up under /machine/unattached - which is somewhat
ugly. We should rather attach it to /machine/sclp/s390-sclp-event-facility
where the other devices of type TYPE_SCLP_EVENT already reside.
Message-ID: <20240430190843.453903-1-thuth@redhat.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/s390x/s390-virtio-ccw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 4dcc213820..726c2ab436 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -239,11 +239,13 @@ static void s390_create_virtio_net(BusState *bus, const char *name)
static void s390_create_sclpconsole(const char *type, Chardev *chardev)
{
+ BusState *ev_fac_bus = sclp_get_event_facility_bus();
DeviceState *dev;
dev = qdev_new(type);
+ object_property_add_child(OBJECT(ev_fac_bus->parent), type, OBJECT(dev));
qdev_prop_set_chr(dev, "chardev", chardev);
- qdev_realize_and_unref(dev, sclp_get_event_facility_bus(), &error_fatal);
+ qdev_realize_and_unref(dev, ev_fac_bus, &error_fatal);
}
static void ccw_init(MachineState *machine)
--
2.45.0
next prev parent reply other threads:[~2024-05-10 6:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 6:39 [PULL 0/8] s390x and misc patches Thomas Huth
2024-05-10 6:39 ` Thomas Huth [this message]
2024-05-10 6:39 ` [PULL 2/8] s390x: Introduce a SCLPDevice pointer under the machine Thomas Huth
2024-05-10 6:39 ` [PULL 3/8] s390x/event-facility: Simplify sclp_get_event_facility_bus() Thomas Huth
2024-05-10 6:39 ` [PULL 4/8] s390x/sclp: Simplify get_sclp_device() Thomas Huth
2024-05-10 6:39 ` [PULL 5/8] target/s390x: report deprecated-props in cpu-model-expansion reply Thomas Huth
2024-05-10 6:39 ` [PULL 6/8] target/s390x: flag te and cte as deprecated Thomas Huth
2024-05-10 6:40 ` [PULL 7/8] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead Thomas Huth
2024-05-10 6:40 ` [PULL 8/8] tests/qtest: Add some test cases support on LoongArch Thomas Huth
2024-05-10 9:17 ` [PULL 0/8] s390x and misc patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510064001.26002-2-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).