qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: "Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 4/8] s390x/sclp: Simplify get_sclp_device()
Date: Fri, 10 May 2024 08:39:57 +0200	[thread overview]
Message-ID: <20240510064001.26002-5-thuth@redhat.com> (raw)
In-Reply-To: <20240510064001.26002-1-thuth@redhat.com>

From: Cédric Le Goater <clg@redhat.com>

get_sclp_device() scans the whole machine to find a TYPE_SCLP object.
Now that the SCLPDevice instance is available under the machine state,
use it to simplify the lookup. While at it, remove the inline to let
the compiler decide on how to optimize.

Signed-off-by: Cédric Le Goater <clg@redhat.com>
Message-ID: <20240502131533.377719-4-clg@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/s390x/sclp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
index d236dbaf0b..e725dcd5fd 100644
--- a/hw/s390x/sclp.c
+++ b/hw/s390x/sclp.c
@@ -21,13 +21,14 @@
 #include "hw/s390x/s390-pci-bus.h"
 #include "hw/s390x/ipl.h"
 #include "hw/s390x/cpu-topology.h"
+#include "hw/s390x/s390-virtio-ccw.h"
 
-static inline SCLPDevice *get_sclp_device(void)
+static SCLPDevice *get_sclp_device(void)
 {
     static SCLPDevice *sclp;
 
     if (!sclp) {
-        sclp = SCLP(object_resolve_path_type("", TYPE_SCLP, NULL));
+        sclp = S390_CCW_MACHINE(qdev_get_machine())->sclp;
     }
     return sclp;
 }
-- 
2.45.0



  parent reply	other threads:[~2024-05-10  6:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  6:39 [PULL 0/8] s390x and misc patches Thomas Huth
2024-05-10  6:39 ` [PULL 1/8] hw/s390x: Attach the sclpconsole to /machine/sclp/s390-sclp-event-facility Thomas Huth
2024-05-10  6:39 ` [PULL 2/8] s390x: Introduce a SCLPDevice pointer under the machine Thomas Huth
2024-05-10  6:39 ` [PULL 3/8] s390x/event-facility: Simplify sclp_get_event_facility_bus() Thomas Huth
2024-05-10  6:39 ` Thomas Huth [this message]
2024-05-10  6:39 ` [PULL 5/8] target/s390x: report deprecated-props in cpu-model-expansion reply Thomas Huth
2024-05-10  6:39 ` [PULL 6/8] target/s390x: flag te and cte as deprecated Thomas Huth
2024-05-10  6:40 ` [PULL 7/8] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead Thomas Huth
2024-05-10  6:40 ` [PULL 8/8] tests/qtest: Add some test cases support on LoongArch Thomas Huth
2024-05-10  9:17 ` [PULL 0/8] s390x and misc patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510064001.26002-5-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=clg@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).