From: Anton Johansson via <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com
Subject: [PATCH v2 0/4] target/hexagon: Minor idef-parser cleanup
Date: Fri, 10 May 2024 16:52:40 +0200 [thread overview]
Message-ID: <20240510145244.5615-1-anjo@rev.ng> (raw)
Was running idef-parser with valgrind and noticed we were leaking the
init_list GArray, which is used to hold instruction arguments that may
need initialization. This patchset fixes the leak, removes unused
macros and undefined functions, and simplifies gen_inst_init_args() to
only handle predicate values.
Changes in v2:
* Update comment in 3rd patch
* Follow style guide in 4th patch
Anton Johansson (4):
target/hexagon: idef-parser remove unused defines
target/hexagon: idef-parser remove undefined functions
target/hexagon: idef-parser fix leak of init_list
target/hexagon: idef-parser simplify predicate init
target/hexagon/idef-parser/idef-parser.h | 10 ------
target/hexagon/idef-parser/idef-parser.y | 2 --
target/hexagon/idef-parser/parser-helpers.c | 35 +++++++++++++--------
target/hexagon/idef-parser/parser-helpers.h | 13 --------
4 files changed, 22 insertions(+), 38 deletions(-)
--
2.45.0
next reply other threads:[~2024-05-10 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:52 Anton Johansson via [this message]
2024-05-10 14:52 ` [PATCH v2 1/4] target/hexagon: idef-parser remove unused defines Anton Johansson via
2024-05-10 14:52 ` [PATCH v2 2/4] target/hexagon: idef-parser remove undefined functions Anton Johansson via
2024-05-10 14:52 ` [PATCH v2 3/4] target/hexagon: idef-parser fix leak of init_list Anton Johansson via
2024-05-20 20:04 ` ltaylorsimpson
2024-05-10 14:52 ` [PATCH v2 4/4] target/hexagon: idef-parser simplify predicate init Anton Johansson via
2024-05-20 20:03 ` ltaylorsimpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510145244.5615-1-anjo@rev.ng \
--to=qemu-devel@nongnu.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=ltaylorsimpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).