qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@redhat.com>,
	"Dongwon Kim" <dongwon.kim@intel.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 1/5] ui/console: Only declare variable fence_fd when CONFIG_GBM is defined
Date: Fri, 17 May 2024 17:02:23 +0200	[thread overview]
Message-ID: <20240517150227.32205-2-philmd@linaro.org> (raw)
In-Reply-To: <20240517150227.32205-1-philmd@linaro.org>

From: Cédric Le Goater <clg@redhat.com>

This to avoid a build breakage :

../ui/gtk-egl.c: In function ‘gd_egl_draw’:
../ui/gtk-egl.c:73:9: error: unused variable ‘fence_fd’ [-Werror=unused-variable]
   73 |     int fence_fd;
      |         ^~~~~~~~

Fixes: fa6426805b12 ("ui/console: Use qemu_dmabuf_set_..() helpers instead")
Cc: Dongwon Kim <dongwon.kim@intel.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240515100520.574383-1-clg@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 ui/gtk-egl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 0473f689c9..9831c10e1b 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -68,9 +68,9 @@ void gd_egl_draw(VirtualConsole *vc)
     GdkWindow *window;
 #ifdef CONFIG_GBM
     QemuDmaBuf *dmabuf = vc->gfx.guest_fb.dmabuf;
+    int fence_fd;
 #endif
     int ww, wh, ws;
-    int fence_fd;
 
     if (!vc->gfx.gls) {
         return;
-- 
2.41.0



  reply	other threads:[~2024-05-17 15:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 15:02 [PULL 0/5] Misc HW patches & fixes for 2024-05-17 Philippe Mathieu-Daudé
2024-05-17 15:02 ` Philippe Mathieu-Daudé [this message]
2024-05-17 16:56   ` [PULL 1/5] ui/console: Only declare variable fence_fd when CONFIG_GBM is defined Kim, Dongwon
2024-05-17 15:02 ` [PULL 2/5] hw/pflash: fix block write start Philippe Mathieu-Daudé
2024-05-17 15:02 ` [PULL 3/5] hw/core: allow parameter=1 for SMP topology on any machine Philippe Mathieu-Daudé
2024-07-03  8:21   ` Daniel P. Berrangé
2024-07-03  8:39     ` Michael Tokarev
2024-05-17 15:02 ` [PULL 4/5] tests: add testing of parameter=1 for SMP topology Philippe Mathieu-Daudé
2024-05-17 15:02 ` [PULL 5/5] tests: Gently exit from GDB when tests complete Philippe Mathieu-Daudé
2024-05-18 13:26 ` [PULL 0/5] Misc HW patches & fixes for 2024-05-17 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240517150227.32205-2-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=clg@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).