From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Zhao Liu" <zhao1.liu@intel.com>, "Ján Tomko" <jtomko@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 4/5] tests: add testing of parameter=1 for SMP topology
Date: Fri, 17 May 2024 17:02:26 +0200 [thread overview]
Message-ID: <20240517150227.32205-5-philmd@linaro.org> (raw)
In-Reply-To: <20240517150227.32205-1-philmd@linaro.org>
From: Daniel P. Berrangé <berrange@redhat.com>
Validate that it is possible to pass 'parameter=1' for any SMP topology
parameter, since unsupported parameters are implicitly considered to
always have a value of 1.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Message-ID: <20240513123358.612355-3-berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/unit/test-smp-parse.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index 56165e6644..9fdba24fce 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -330,6 +330,14 @@ static const struct SMPTestData data_generic_valid[] = {
.config = SMP_CONFIG_GENERIC(T, 8, T, 2, T, 4, T, 2, T, 16),
.expect_prefer_sockets = CPU_TOPOLOGY_GENERIC(8, 2, 4, 2, 16),
.expect_prefer_cores = CPU_TOPOLOGY_GENERIC(8, 2, 4, 2, 16),
+ }, {
+ /*
+ * Unsupported parameters are always allowed to be set to '1'
+ * config: -smp 8,books=1,drawers=1,sockets=2,modules=1,dies=1,cores=2,threads=2,maxcpus=8
+ * expect: cpus=8,sockets=2,cores=2,threads=2,maxcpus=8 */
+ .config = SMP_CONFIG_WITH_FULL_TOPO(8, 1, 1, 2, 1, 1, 2, 2, 8),
+ .expect_prefer_sockets = CPU_TOPOLOGY_GENERIC(8, 2, 2, 2, 8),
+ .expect_prefer_cores = CPU_TOPOLOGY_GENERIC(8, 2, 2, 2, 8),
},
};
--
2.41.0
next prev parent reply other threads:[~2024-05-17 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 15:02 [PULL 0/5] Misc HW patches & fixes for 2024-05-17 Philippe Mathieu-Daudé
2024-05-17 15:02 ` [PULL 1/5] ui/console: Only declare variable fence_fd when CONFIG_GBM is defined Philippe Mathieu-Daudé
2024-05-17 16:56 ` Kim, Dongwon
2024-05-17 15:02 ` [PULL 2/5] hw/pflash: fix block write start Philippe Mathieu-Daudé
2024-05-17 15:02 ` [PULL 3/5] hw/core: allow parameter=1 for SMP topology on any machine Philippe Mathieu-Daudé
2024-07-03 8:21 ` Daniel P. Berrangé
2024-07-03 8:39 ` Michael Tokarev
2024-05-17 15:02 ` Philippe Mathieu-Daudé [this message]
2024-05-17 15:02 ` [PULL 5/5] tests: Gently exit from GDB when tests complete Philippe Mathieu-Daudé
2024-05-18 13:26 ` [PULL 0/5] Misc HW patches & fixes for 2024-05-17 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517150227.32205-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=jtomko@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).