From: Rayhan Faizel <rayhan.faizel@gmail.com>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org, peter.maydell@linaro.org, qemu-arm@nongnu.org,
Rayhan Faizel <rayhan.faizel@gmail.com>
Subject: [PATCH v2 0/3] Initial support for One-Time Programmable Memory (OTP) in BCM2835
Date: Sun, 19 May 2024 01:31:33 +0530 [thread overview]
Message-ID: <20240518200136.1448672-1-rayhan.faizel@gmail.com> (raw)
All BCM2835 boards have on-board OTP memory with 66 32-bit rows. Usually,
its contents are accessible via mailbox commands.
[Changes in v2]
- Replace read/write with get/set in bcm2835_otp.c.
- Use impl instead of valid in bcm2835_otp.c.
- Replace all constant values with macros defined in bcm2835_otp.h.
- Change memory region size of OTP device to 0x80.
- After further testing on a real Raspberry Pi 3, I noticed a few things
contrary to my initial assumptions:
-- The customer OTP lock bit is bit 6 of row 32, NOT bit 30 of row 30. This is
currently undocumented to my knowledge.
-- The above lock indeed applies to the private key as well.
Rayhan Faizel (3):
hw/nvram: Add BCM2835 OTP device
hw/arm: Connect OTP device to BCM2835
hw/misc: Implement mailbox properties for customer OTP and device
specific private keys
hw/arm/bcm2835_peripherals.c | 15 ++-
hw/misc/bcm2835_property.c | 87 +++++++++++++
hw/nvram/bcm2835_otp.c | 187 +++++++++++++++++++++++++++
hw/nvram/meson.build | 1 +
include/hw/arm/bcm2835_peripherals.h | 3 +-
include/hw/arm/raspberrypi-fw-defs.h | 2 +
include/hw/misc/bcm2835_property.h | 2 +
include/hw/nvram/bcm2835_otp.h | 67 ++++++++++
8 files changed, 362 insertions(+), 2 deletions(-)
create mode 100644 hw/nvram/bcm2835_otp.c
create mode 100644 include/hw/nvram/bcm2835_otp.h
--
2.34.1
next reply other threads:[~2024-05-18 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 20:01 Rayhan Faizel [this message]
2024-05-18 20:01 ` [PATCH v2 1/3] hw/nvram: Add BCM2835 OTP device Rayhan Faizel
2024-05-18 20:01 ` [PATCH v2 2/3] hw/arm: Connect OTP device to BCM2835 Rayhan Faizel
2024-05-18 20:01 ` [PATCH v2 3/3] hw/misc: Implement mailbox properties for customer OTP and device specific private keys Rayhan Faizel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240518200136.1448672-1-rayhan.faizel@gmail.com \
--to=rayhan.faizel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).