qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: npiggin@gmail.com, qemu-ppc@nongnu.org
Cc: danielhb413@gmail.com, qemu-devel@nongnu.org
Subject: [PATCH 2/6] target/ppc: optimize hreg_compute_pmu_hflags_value
Date: Mon, 20 May 2024 16:03:25 +0530	[thread overview]
Message-ID: <20240520103329.381158-3-harshpb@linux.ibm.com> (raw)
In-Reply-To: <20240520103329.381158-1-harshpb@linux.ibm.com>

Cache env->spr[SPR_POWER_MMCR0] in a local variable as used in multiple
conditions to avoid multiple indirect accesses.

Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
---
 target/ppc/helper_regs.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c
index 945fa1a596..5de0df5795 100644
--- a/target/ppc/helper_regs.c
+++ b/target/ppc/helper_regs.c
@@ -50,15 +50,16 @@ void hreg_swap_gpr_tgpr(CPUPPCState *env)
 static uint32_t hreg_compute_pmu_hflags_value(CPUPPCState *env)
 {
     uint32_t hflags = 0;
-
 #if defined(TARGET_PPC64)
-    if (env->spr[SPR_POWER_MMCR0] & MMCR0_PMCC0) {
+    target_ulong spr_power_mmcr0 = env->spr[SPR_POWER_MMCR0];
+
+    if (spr_power_mmcr0 & MMCR0_PMCC0) {
         hflags |= 1 << HFLAGS_PMCC0;
     }
-    if (env->spr[SPR_POWER_MMCR0] & MMCR0_PMCC1) {
+    if (spr_power_mmcr0 & MMCR0_PMCC1) {
         hflags |= 1 << HFLAGS_PMCC1;
     }
-    if (env->spr[SPR_POWER_MMCR0] & MMCR0_PMCjCE) {
+    if (spr_power_mmcr0 & MMCR0_PMCjCE) {
         hflags |= 1 << HFLAGS_PMCJCE;
     }
 
-- 
2.39.3



  parent reply	other threads:[~2024-05-20 10:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 10:33 [PATCH 0/6] target/ppc: misc ppc improvements/optimizations Harsh Prateek Bora
2024-05-20 10:33 ` [PATCH 1/6] target/ppc: use locally stored msr and avoid indirect access Harsh Prateek Bora
2024-05-20 10:33 ` Harsh Prateek Bora [this message]
2024-05-20 11:26   ` [PATCH 2/6] target/ppc: optimize hreg_compute_pmu_hflags_value BALATON Zoltan
2024-05-20 10:33 ` [PATCH 3/6] " Harsh Prateek Bora
2024-05-20 11:28   ` BALATON Zoltan
2024-05-20 10:33 ` [PATCH 4/6] target/ppc: optimize p9 exception handling routines Harsh Prateek Bora
2024-05-20 11:35   ` BALATON Zoltan
2024-05-20 11:36     ` BALATON Zoltan
2024-05-20 10:33 ` [PATCH 5/6] target/ppc: reduce duplicate code between init_proc_POWER{9, 10} Harsh Prateek Bora
2024-05-20 11:41   ` BALATON Zoltan
2024-05-20 10:33 ` [PATCH 6/6] target/ppc: redue code duplication across Power9/10 init code Harsh Prateek Bora
2024-05-20 11:52   ` BALATON Zoltan
2024-05-23  5:16     ` Harsh Prateek Bora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520103329.381158-3-harshpb@linux.ibm.com \
    --to=harshpb@linux.ibm.com \
    --cc=danielhb413@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).