From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk
Subject: [PATCH RISU v2 5/8] risugen: Be explicit about print destinations
Date: Tue, 21 May 2024 20:44:39 -0700 [thread overview]
Message-ID: <20240522034442.140293-6-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240522034442.140293-1-richard.henderson@linaro.org>
Printing directly to STDOUT and STDERR will allow the
print destination to be selected elsewhere.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
risugen_common.pm | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/risugen_common.pm b/risugen_common.pm
index 71ee996..5207c0e 100644
--- a/risugen_common.pm
+++ b/risugen_common.pm
@@ -76,7 +76,7 @@ sub progress_start($$)
($proglen, $progmax) = @_;
$proglen -= 2; # allow for [] chars
$| = 1; # disable buffering so we can see the meter...
- print "[" . " " x $proglen . "]\r";
+ print STDOUT "[" . " " x $proglen . "]\r";
$lastprog = 0;
}
@@ -87,13 +87,13 @@ sub progress_update($)
my $barlen = int($proglen * $done / $progmax);
if ($barlen != $lastprog) {
$lastprog = $barlen;
- print "[" . "-" x $barlen . " " x ($proglen - $barlen) . "]\r";
+ print STDOUT "[" . "-" x $barlen . " " x ($proglen - $barlen) . "]\r";
}
}
sub progress_end()
{
- print "[" . "-" x $proglen . "]\n";
+ print STDOUT "[" . "-" x $proglen . "]\n";
$| = 0;
}
@@ -124,7 +124,7 @@ sub eval_with_fields($$$$$) {
$evalstr .= "}";
my $v = eval $evalstr;
if ($@) {
- print "Syntax error detected evaluating $insnname $blockname string:\n$block\n$@";
+ print STDERR "Syntax error detected evaluating $insnname $blockname string:\n$block\n$@";
exit(1);
}
return $v;
@@ -163,20 +163,20 @@ sub dump_insn_details($$)
{
# Dump the instruction details for one insn
my ($insn, $rec) = @_;
- print "insn $insn: ";
+ print STDOUT "insn $insn: ";
my $insnwidth = $rec->{width};
my $fixedbits = $rec->{fixedbits};
my $fixedbitmask = $rec->{fixedbitmask};
my $constraint = $rec->{blocks}{"constraints"};
- print sprintf(" insnwidth %d fixedbits %08x mask %08x ", $insnwidth, $fixedbits, $fixedbitmask);
+ print STDOUT sprintf(" insnwidth %d fixedbits %08x mask %08x ", $insnwidth, $fixedbits, $fixedbitmask);
if (defined $constraint) {
- print "constraint $constraint ";
+ print STDOUT "constraint $constraint ";
}
for my $tuple (@{ $rec->{fields} }) {
my ($var, $pos, $mask) = @$tuple;
- print "($var, $pos, " . sprintf("%08x", $mask) . ") ";
+ print STDOUT "($var, $pos, " . sprintf("%08x", $mask) . ") ";
}
- print "\n";
+ print STDOUT "\n";
}
1;
--
2.34.1
next prev parent reply other threads:[~2024-05-22 3:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 3:44 [PATCH RISU v2 0/8] ELF and Sparc64 support Richard Henderson
2024-05-22 3:44 ` [PATCH RISU v2 1/8] risu: Allow use of ELF test files Richard Henderson
2024-05-22 3:44 ` [PATCH RISU v2 2/8] Build elf test cases instead of raw binaries Richard Henderson
2024-05-22 3:44 ` [PATCH RISU v2 3/8] Introduce host_context_t Richard Henderson
2024-05-22 3:44 ` [PATCH RISU v2 4/8] risu: Add initial sparc64 support Richard Henderson
2024-05-22 3:44 ` Richard Henderson [this message]
2024-05-22 3:44 ` [PATCH RISU v2 6/8] risugen: Add " Richard Henderson
2024-05-22 3:44 ` [PATCH RISU v2 7/8] sparc64: Add a few logical insns Richard Henderson
2024-05-22 3:44 ` [PATCH RISU v2 8/8] sparc64: Add VIS1 instructions Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522034442.140293-6-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).